All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Diffey <gdiffey@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, Felix Homann <linuxaudio@showlabor.de>
Subject: Re: A plea for help on mixer support for Fast Track Ultra (8R)
Date: Thu, 19 May 2011 10:51:55 +1000	[thread overview]
Message-ID: <BANLkTi=y-RO-LaiNsPLv8CJ-MWYYsePgCw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=2NeMGL6n7B0n-2p9La=45pM7ZHg@mail.gmail.com>

Daniel,

> The main problem at the moment is that snd_usb_create_mixer() will not be
> > called on quirked devices! Take a look at card.c: snd_usb_create_mixer()
> > will only be called if snd_usb_create_quirk() returns > 0. But why should
> we
> > assume that quirked devices don't have any mixers?
>
> That is indeed strange, yes. I can't explain that. Not to break
> existing devices, I would suggest adding a bit-wise "flags" field to
> snd_usb_audio_quirk and still create the mixers if a certain flag
> (something like "QUIRK_FLAG_CREATE_STANDARD_MIXERS") is set. Clemens,
> Takashi, would that be ok?
>
> In general, note that as long as functions are static, the can and
> should have short names. But once they're not, you're in the global
> kernel namespace, and all symbols must be well prefixed (with
> "snd_usb_" in that case) in order to avoid name collisions.
>
>
So this is probably a terrible idea but what about creating a new quirk

QUIRK_MIXER_STANDARD_INTERFACE and just having that eventually call
snd_usb_create_mixer()

because conceptually I could see this as two problems with two solutions.
one is that the interface type/blah is the mixer is a lie (vendor_specific
instead of UAC2 MIXER . (should be solved via a "quirk" in quirk-table.h)
and

The other is that the endpoint descriptors within that are wrong (solved in
mixer_quirks)

or am I thinking about this wrong?

Grant.

  reply	other threads:[~2011-05-19  0:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 15:19 A plea for help on mixer support for Fast Track Ultra (8R) Felix Homann
2011-05-18 15:29 ` Felix Homann
2011-05-18 17:51 ` Daniel Mack
2011-05-18 18:46   ` Felix Homann
2011-05-18 21:30     ` Daniel Mack
2011-05-19  0:51       ` Grant Diffey [this message]
2011-05-19  5:42       ` Takashi Iwai
2011-05-19  6:45         ` Felix Homann
2011-05-19  7:15           ` Clemens Ladisch
2011-05-19  7:24           ` Takashi Iwai
2011-05-19  8:14             ` Felix Homann
2011-05-19  8:52               ` Daniel Mack
2011-05-19 10:56                 ` Felix Homann
2011-05-19 11:05                 ` Daniel Mack
2011-05-19 12:23                   ` Felix Homann
2011-05-19 13:36                   ` Felix Homann
2011-05-19 13:42                   ` Felix Homann
2011-05-19 14:12                     ` Daniel Mack
2011-05-20 10:12                       ` Felix Homann
2011-05-20 11:12                         ` Daniel Mack
2011-05-20 11:14                         ` Felix Homann
2011-05-20 11:37                           ` Daniel Mack
2011-05-20 15:08                             ` Grant Diffey
2011-05-20 15:43                               ` Grant Diffey
2011-05-20 15:52                                 ` Felix Homann
2011-05-20 15:54                                 ` Daniel Mack
2011-05-20 16:25                                   ` Grant Diffey
2011-05-20 16:38                                     ` Daniel Mack
2011-05-20 16:44                                       ` Felix Homann
2011-05-20 16:52                                         ` Felix Homann
2011-05-24 10:11                               ` Felix Homann
2011-05-24 10:47                                 ` Daniel Mack
2011-05-24 11:54                                   ` Takashi Iwai
2011-05-24 23:55                                 ` Grant Diffey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=y-RO-LaiNsPLv8CJ-MWYYsePgCw@mail.gmail.com' \
    --to=gdiffey@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linuxaudio@showlabor.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.