From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Hui Date: Thu, 12 May 2011 13:31:22 +0800 Subject: [U-Boot] [PATCH V7 3/3] MX53: support for freescale MX53LOCO board In-Reply-To: <359310.456.qm@web39422.mail.mud.yahoo.com> References: <1305101022-22546-3-git-send-email-jason.hui@linaro.org> <359310.456.qm@web39422.mail.mud.yahoo.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Fabio, On Wed, May 11, 2011 at 8:03 PM, Fabio Estevam wrote: > Hi Jason, > > --- On Wed, 5/11/11, Jason Liu wrote: > ... >> diff --git a/arch/arm/cpu/armv7/mx5/soc.c >> b/arch/arm/cpu/armv7/mx5/soc.c >> index 6f4e8db..9c03474 100644 >> --- a/arch/arm/cpu/armv7/mx5/soc.c >> +++ b/arch/arm/cpu/armv7/mx5/soc.c > ... > > This file is not MX53Loco specific, so it should be part of another patch. > >> mxc_get_clock(MXC_ARM_CLK) / 1000000); >> -??? printf("Reset cause: %s\n", get_reset_cause()); >> +??? printf("Reset? cause: %s\n", get_reset_cause()); >> ???? return 0; > > What is the purpose of this change? Just make the print looks good. Nothing else. I can remove it. > >> index f687503..2d7e9ed 100644 >> --- a/arch/arm/include/asm/arch-mx5/sys_proto.h >> +++ b/arch/arm/include/asm/arch-mx5/sys_proto.h > > This file is not MX53Loco specific, so it should be part of another patch. Will move to another file as Stefano suggest. Jason > > Regards, > > Fabio Estevam >