From: Ben Gardiner <bengardiner@nanometrics.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] Davinci: ea20: Add NAND support
Date: Mon, 11 Apr 2011 09:05:09 -0400 [thread overview]
Message-ID: <BANLkTikKw+XAREeJZeeaCRhn3kRK=K0scw@mail.gmail.com> (raw)
In-Reply-To: <1302372335-30232-3-git-send-email-sbabic@denx.de>
On Sat, Apr 9, 2011 at 2:05 PM, Stefano Babic <sbabic@denx.de> wrote:
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Sandeep Paulraj <s-paulraj@ti.com>
> CC: Scott Wood <scottwood@freescale.com>
> [...]
> @@ -143,20 +144,20 @@ int board_init(void)
> ? ? ? ?irq_init();
> ?#endif
>
> -#ifdef CONFIG_NAND_DAVINCI
> ? ? ? ?/*
> ? ? ? ? * NAND CS setup - cycle counts based on da850evm NAND timings in the
> ? ? ? ? * Linux kernel @ 25MHz EMIFA
> ? ? ? ? */
> +#ifdef CONFIG_NAND_DAVINCI
> ? ? ? ?writel((DAVINCI_ABCR_WSETUP(0) |
> - ? ? ? ? ? ? ? DAVINCI_ABCR_WSTROBE(0) |
> + ? ? ? ? ? ? ? DAVINCI_ABCR_WSTROBE(1) |
If WSTROBE is modified then the timings are no longer solely based on
the NAND timings in arch/arm/mach-davinci/board-da850-evm.c in the
Linux kernel. Can you add an amendment to the comment describing the
motivation for the extra WSTROBE cycle?
> [...]
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca
next prev parent reply other threads:[~2011-04-11 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 18:05 [U-Boot] [PATCH 1/6] Davinci: ea20: set console on UART0 Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 2/6] Davinci: ea20: set GPIOs to hold MII-Phy in reset and set UART0-Switch for console Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 3/6] Davinci: ea20: Add NAND support Stefano Babic
2011-04-11 13:05 ` Ben Gardiner [this message]
2011-04-12 7:29 ` Stefano Babic
2011-04-12 16:09 ` Ben Gardiner
2011-04-09 18:05 ` [U-Boot] [PATCH 4/6] Davinci: ea20: Add early init to get early output from console Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 5/6] Davinci: ea20: Add default U-Boot environment Stefano Babic
2011-04-09 18:05 ` [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND Stefano Babic
2011-04-11 14:04 ` Ben Gardiner
2011-04-12 0:45 ` Jon Povey
2011-04-12 0:45 ` [U-Boot] " Jon Povey
2011-04-12 9:08 ` Stefano Babic
2011-04-12 12:47 ` Ben Gardiner
2011-04-12 12:47 ` [U-Boot] " Ben Gardiner
2011-04-11 19:16 ` Scott Wood
2011-04-12 9:44 ` Stefano Babic
2011-04-13 16:24 ` Scott Wood
2011-04-15 17:34 ` Stefano Babic
2011-04-15 20:29 ` Scott Wood
2011-04-22 7:13 ` Stefano Babic
2011-04-25 17:37 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikKw+XAREeJZeeaCRhn3kRK=K0scw@mail.gmail.com' \
--to=bengardiner@nanometrics.ca \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.