From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: Re: [PATCH] Fix save.py bug Date: Wed, 18 May 2011 09:00:11 -0400 Message-ID: References: Reply-To: rshriram@cs.ubc.ca Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1169898508==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" Cc: "Li, Xin" , Keir Fraser , Ian Jackson , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============1169898508== Content-Type: multipart/alternative; boundary=001517510e5466ae3604a38c7ab9 --001517510e5466ae3604a38c7ab9 Content-Type: text/plain; charset=ISO-8859-1 On Wed, May 18, 2011 at 4:30 AM, Liu, Jinsong wrote: > Resend it, it has been acked by Ian and Shriram, but seems to be ignored > and didn't in unstable tree :) > > Thanks, > Jinsong > > ================ > Fix save.py bug > > Fix save.py bug, to avoid compiling error under python2.4 > > Signed-off-by: Liu, Jinsong > Acked-by: Ian Campbell > Acked-by: Shriram Rajagopalan > > diff -r f9bb0bbea7c2 tools/python/xen/remus/save.py > --- a/tools/python/xen/remus/save.py Thu May 12 16:42:54 2011 +0100 > +++ b/tools/python/xen/remus/save.py Fri May 13 22:45:21 2011 +0800 > @@ -161,11 +161,12 @@ class Saver(object): > > self.checkpointer = xen.lowlevel.checkpoint.checkpointer() > try: > - self.checkpointer.open(self.vm.domid) > - self.checkpointer.start(self.fd, self.suspendcb, > self.resumecb, > - self.checkpointcb, self.interval) > - except xen.lowlevel.checkpoint.error, e: > - raise CheckpointError(e) > + try: > + self.checkpointer.open(self.vm.domid) > + self.checkpointer.start(self.fd, self.suspendcb, > self.resumecb, > + self.checkpointcb, self.interval) > + except xen.lowlevel.checkpoint.error, e: > + raise CheckpointError(e) > finally: > try: #errors in checkpoint close are not critical atm. > self.checkpointer.close() >>From my experience it takes couple of days for the patches to appear in the unstable tree, after they have been sent to the mailing list. No point resending it. :) shriram --001517510e5466ae3604a38c7ab9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Wed, May 18, 2011 at 4:30 AM, Liu, Jinsong <jinsong.liu@in= tel.com> wrote:
Resend it, it has been acked by Ian and Shriram, but seems to be ignored an= d didn't in unstable tree :)

Thanks,
Jinsong

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Fix save.py bug

Fix save.py bug, to avoid compiling error under python2.4

Signed-off-by: Liu, Jinsong <ji= nsong.liu@intel.com>
Acked-by: Ian Campbell <Ia= n.Campbell@eu.citrix.com>
Acked-by: Shriram Rajagopalan <rsh= riram@cs.ubc.ca>

diff -r f9bb0bbea7c2 tools/python/xen/remus/save.py
--- a/tools/python/xen/remus/save.py =A0 =A0Thu May 12 16:42:54 2011 +0100<= br> +++ b/tools/python/xen/remus/save.py =A0 =A0Fri May 13 22:45:21 2011 +0800<= br> @@ -161,11 +161,12 @@ class Saver(object):

=A0 =A0 =A0 =A0 self.checkpointer =3D xen.lowlevel.checkpoint.checkpointer= ()
=A0 =A0 =A0 =A0 try:
- =A0 =A0 =A0 =A0 =A0 =A0self.checkpointer.open(self.vm.domid)
- =A0 =A0 =A0 =A0 =A0 =A0self.checkpointer.start(self.fd, self.suspendcb, s= elf.resumecb,
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0se= lf.checkpointcb, self.interval)
- =A0 =A0 =A0 =A0except xen.lowlevel.checkpoint.error, e:
- =A0 =A0 =A0 =A0 =A0 =A0raise CheckpointError(e)
+ =A0 =A0 =A0 =A0 =A0 =A0try:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0self.checkpointer.open(self.vm.domid)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0self.checkpointer.start(self.fd, self.susp= endcb, self.resumecb,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0self.checkpointcb, self.interval)
+ =A0 =A0 =A0 =A0 =A0 =A0except xen.lowlevel.checkpoint.error, e:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0raise CheckpointError(e)
=A0 =A0 =A0 =A0 finally:
=A0 =A0 =A0 =A0 =A0 =A0 try: #errors in checkpoint close are not critical = atm.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 self.checkpointer.close()
From my experience it takes couple of days for the patches to appear in t= he unstable tree,
after they have been sent to the mailing list.
No p= oint resending it. :)
shriram
--001517510e5466ae3604a38c7ab9-- --===============1169898508== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1169898508==--