From: Javier Cardona <javier@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: netlink reverts
Date: Fri, 20 May 2011 17:05:12 -0700 [thread overview]
Message-ID: <BANLkTikjDhdYMssyivgRxAyB5-_FctQbSg@mail.gmail.com> (raw)
In-Reply-To: <1305917949.4640.16.camel@jlt3.sipsolutions.net>
On Fri, May 20, 2011 at 11:59 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2011-05-20 at 11:57 -0700, Johannes Berg wrote:
>> John,
>>
>> Please revert
>> 9c3990aaec0ad9f686ef6480f6861f2df89b2a7a
>> ASAP; you'll have to revert
>> 8958da779b92da60e90d9761549b88677a6a3eef
>> first. (alternatively, if you're feeling less pissed off than I am you
>> can fix it I guess)
>>
>> Javier fucked up the netlink attribute types again by inserting
>> something in the middle, and I'm really mad about it too.
>
> Hmm, maybe I shot first and then asked questions ;-) Looking at it again
> it _might_ have been introduced by merge issues?
Don't shoot me, please, it really _was_ a merge issue. My patch did
not insert anything in the middle:
https://patchwork.kernel.org/patch/752292 and it was sent a day
before you sent the patch adding WoWLAN support:
https://patchwork.kernel.org/patch/753772/
Cheers,
Javier
--
Javier Cardona
cozybit Inc.
http://www.cozybit.com
next prev parent reply other threads:[~2011-05-21 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 18:57 netlink reverts Johannes Berg
2011-05-20 18:59 ` Johannes Berg
2011-05-21 0:05 ` Javier Cardona [this message]
2011-05-21 8:42 ` Johannes Berg
2011-05-21 15:40 ` Javier Cardona
2011-05-24 15:49 ` Johannes Berg
2011-05-24 15:58 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikjDhdYMssyivgRxAyB5-_FctQbSg@mail.gmail.com \
--to=javier@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.