From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <liuw@liuw.name>
Subject: Re: Re: [PATCH] libxl: basic support for virtio disk
Date: Fri, 3 Jun 2011 09:22:52 +0800
Message-ID: <BANLkTikqCyG75CVmMHY-4YtS-Z0KRhuErg@mail.gmail.com>
References: <BANLkTikbJFnVzqhnRy0=Vb0S=pgENDZ_qw@mail.gmail.com>
	<alpine.DEB.2.00.1105271315270.12963@kaball-desktop>
	<BANLkTikM4AJz1jQi2v4vwM=EP7TEfUP-YQ@mail.gmail.com>
	<alpine.DEB.2.00.1105271559170.12963@kaball-desktop>
	<BANLkTikA_Gw8fgQ4K_=eEg=jkx1TDKMSwQ@mail.gmail.com>
	<alpine.DEB.2.00.1105311232300.12963@kaball-desktop>
	<BANLkTimiDzJLiM++TUR1ysksRjPYjBeu2Q@mail.gmail.com>
	<19942.17843.474817.123371@mariner.uk.xensource.com>
	<BANLkTi=HZvj_7BqOAoiJ4cB99OZJmEoLTA@mail.gmail.com>
	<alpine.DEB.2.00.1106021555561.12963@kaball-desktop>
	<19943.46165.598420.601751@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19943.46165.598420.601751@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jun 3, 2011 at 12:03 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wr=
ote:
> Stefano Stabellini writes ("Re: [Xen-devel] Re: [PATCH] libxl: basic supp=
ort for virtio disk"):
>> The limitation on the number of partitions is meaningless for virtio and
>> the limitation on the number of disks in arbitrary, as it is arbitrary
>> the current limitation on the number of scsi disks.
>
> So the code in libxl should accept any disk number that it can
> correctly format into an option to qemu, and allow qemu to deal with
> any resulting problems.
>
>> Device names like xvda1, xvda2, etc, are currently supported only with
>> PV guests.
>
> Currently the partition number is ignored. =C2=A0Nonzero partitions shoul=
d
> instead then be rejected.
>
>> There is no way to specify a single partition with HVM guests.
>> Considering that this patch is only meant for HVM guest, I think it is
>> correct to leave out the partition number.
>
> It should be checked, not ignored.
>
> Ian.
>

OK. Looks like the disk parsing code in libxl is going through a re-factori=
ng.

I will get back to this patch when your re-factoring is done.

Wei.