From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhi Yong Wu Subject: Re: [Qemu-devel] [RFC]QEMU disk I/O limits Date: Fri, 3 Jun 2011 14:56:42 +0800 Message-ID: References: <20110530050923.GF18832@f12.cn.ibm.com> <20110531195549.GL16382@redhat.com> <20110601031255.GG18832@f12.cn.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Vivek Goyal , kwolf@redhat.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, guijianfeng@cn.fujitsu.com, qemu-devel@nongnu.org, wuzhy@cn.ibm.com, herbert@gondor.hengli.com.au, ejt@redhat.com, luowenj@cn.ibm.com, raharper@us.ibm.com To: Michal Suchanek Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:41823 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890Ab1FCG4o convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2011 02:56:44 -0400 Received: by gyd10 with SMTP id 10so648354gyd.19 for ; Thu, 02 Jun 2011 23:56:43 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 2, 2011 at 5:33 PM, Michal Suchanek w= rote: > On 1 June 2011 05:12, Zhi Yong Wu wrote: >> On Tue, May 31, 2011 at 03:55:49PM -0400, Vivek Goyal wrote: >>>Date: Tue, 31 May 2011 15:55:49 -0400 >>>From: Vivek Goyal >>>To: Zhi Yong Wu >>>Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.c= om, >>> =A0 =A0 =A0 kvm@vger.kernel.org, guijianfeng@cn.fujitsu.com, >>> =A0 =A0 =A0 qemu-devel@nongnu.org, wuzhy@cn.ibm.com, >>> =A0 =A0 =A0 herbert@gondor.hengli.com.au, luowenj@cn.ibm.com, zhanx= @cn.ibm.com, >>> =A0 =A0 =A0 zhaoyang@cn.ibm.com, llim@redhat.com, raharper@us.ibm.c= om >>>Subject: Re: [Qemu-devel] [RFC]QEMU disk I/O limits >>>User-Agent: Mutt/1.5.21 (2010-09-15) >>> >>>On Mon, May 30, 2011 at 01:09:23PM +0800, Zhi Yong Wu wrote: >>> >>>[..] >>>> =A0 =A0 3.) How the users enable and play with it >>>> =A0 =A0 QEMU -drive option will be extended so that disk I/O limit= s can be specified on its command line, such as -drive [iops=3Dxxx,][th= roughput=3Dxxx] or -drive [iops_rd=3Dxxx,][iops_wr=3Dxxx,][throughput=3D= xxx] etc. When this argument is specified, it means that "disk I/O limi= ts" feature is enabled for this drive disk. >>> >>>How does throughput interface look like? is it bytes per second or s= omething >>>else? >> HI, Vivek, >> It will be a value based on bytes per second. >> >>> >>>Do we have read and write variants for throughput as we have for iop= s. >> QEMU code has two variants "rd_bytes, wr_bytes", but we maybe need t= o get their bytes per second. >> >>> >>>if you have bytes interface(as kenrel does), then "bps_rd" and "bps_= wr" >>>might be good names too for thoughput interface. >> I agree with you, and can change them as your suggestions. >> > > Changing them this way is not going to be an improvement. While > rd_bytes and wr_bytes lack the time interval specification bps_rd and right, rd_bytes and wr_bytes lack. > bps_wr is ambiguous. Is that bits? bytes? Sure, there should be some if we implement them, they will be bytes. > distinction by capitalization but that does not apply since qemu > arguments are all lowercase. Michal, maybe you misunderstand what i mean. I mean that two variables rd_bytes and wr_bytes exist in block.c file, and are not qemu arguments. But bps_rd and bps_wr wil be added as qemu arguments. Regards, Zhiyong Wu > > Thanks > > Michal > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > --=20 Regards, Zhi Yong Wu From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSOJK-0004Jg-It for qemu-devel@nongnu.org; Fri, 03 Jun 2011 02:56:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSOJI-000658-W2 for qemu-devel@nongnu.org; Fri, 03 Jun 2011 02:56:46 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:35661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSOJI-00064x-Np for qemu-devel@nongnu.org; Fri, 03 Jun 2011 02:56:44 -0400 Received: by gyg4 with SMTP id 4so766973gyg.4 for ; Thu, 02 Jun 2011 23:56:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110530050923.GF18832@f12.cn.ibm.com> <20110531195549.GL16382@redhat.com> <20110601031255.GG18832@f12.cn.ibm.com> Date: Fri, 3 Jun 2011 14:56:42 +0800 Message-ID: From: Zhi Yong Wu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC]QEMU disk I/O limits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Suchanek Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, guijianfeng@cn.fujitsu.com, qemu-devel@nongnu.org, wuzhy@cn.ibm.com, herbert@gondor.hengli.com.au, ejt@redhat.com, luowenj@cn.ibm.com, raharper@us.ibm.com, Vivek Goyal On Thu, Jun 2, 2011 at 5:33 PM, Michal Suchanek wrote= : > On 1 June 2011 05:12, Zhi Yong Wu wrote: >> On Tue, May 31, 2011 at 03:55:49PM -0400, Vivek Goyal wrote: >>>Date: Tue, 31 May 2011 15:55:49 -0400 >>>From: Vivek Goyal >>>To: Zhi Yong Wu >>>Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, >>> =A0 =A0 =A0 kvm@vger.kernel.org, guijianfeng@cn.fujitsu.com, >>> =A0 =A0 =A0 qemu-devel@nongnu.org, wuzhy@cn.ibm.com, >>> =A0 =A0 =A0 herbert@gondor.hengli.com.au, luowenj@cn.ibm.com, zhanx@cn.= ibm.com, >>> =A0 =A0 =A0 zhaoyang@cn.ibm.com, llim@redhat.com, raharper@us.ibm.com >>>Subject: Re: [Qemu-devel] [RFC]QEMU disk I/O limits >>>User-Agent: Mutt/1.5.21 (2010-09-15) >>> >>>On Mon, May 30, 2011 at 01:09:23PM +0800, Zhi Yong Wu wrote: >>> >>>[..] >>>> =A0 =A0 3.) How the users enable and play with it >>>> =A0 =A0 QEMU -drive option will be extended so that disk I/O limits ca= n be specified on its command line, such as -drive [iops=3Dxxx,][throughput= =3Dxxx] or -drive [iops_rd=3Dxxx,][iops_wr=3Dxxx,][throughput=3Dxxx] etc. W= hen this argument is specified, it means that "disk I/O limits" feature is = enabled for this drive disk. >>> >>>How does throughput interface look like? is it bytes per second or somet= hing >>>else? >> HI, Vivek, >> It will be a value based on bytes per second. >> >>> >>>Do we have read and write variants for throughput as we have for iops. >> QEMU code has two variants "rd_bytes, wr_bytes", but we maybe need to ge= t their bytes per second. >> >>> >>>if you have bytes interface(as kenrel does), then "bps_rd" and "bps_wr" >>>might be good names too for thoughput interface. >> I agree with you, and can change them as your suggestions. >> > > Changing them this way is not going to be an improvement. While > rd_bytes and wr_bytes lack the time interval specification bps_rd and right, rd_bytes and wr_bytes lack. > bps_wr is ambiguous. Is that bits? bytes? Sure, there should be some if we implement them, they will be bytes. > distinction by capitalization but that does not apply since qemu > arguments are all lowercase. Michal, maybe you misunderstand what i mean. I mean that two variables rd_bytes and wr_bytes exist in block.c file, and are not qemu arguments. But bps_rd and bps_wr wil be added as qemu arguments. Regards, Zhiyong Wu > > Thanks > > Michal > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > --=20 Regards, Zhi Yong Wu