From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935617Ab1ETKc0 (ORCPT ); Fri, 20 May 2011 06:32:26 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:53240 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935523Ab1ETKcY convert rfc822-to-8bit (ORCPT ); Fri, 20 May 2011 06:32:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xqwtJTt5YnppQc3asNIwX7hnDW00SDTJfznXt3KN7bZ/CrPmuMn/cGYSEkkszlLQbR Ud8IbuingYVG5m+jzW2u0ipQXUhzGay9WNNBrWeh7P+YKzijujXTxF6vEk86WWYAPXPI 3WSG9EEX5CA6Bt3CpVd401hmC2z4cJhmwU/o0= MIME-Version: 1.0 In-Reply-To: References: <1305807498-8785-1-git-send-email-benjamin.tissoires@enac.fr> <1305807498-8785-7-git-send-email-benjamin.tissoires@enac.fr> Date: Fri, 20 May 2011 12:32:23 +0200 X-Google-Sender-Auth: R9wpKE0YdqwzxcCuFQx2_7Tc5iY Message-ID: Subject: Re: [PATCH 6/6] hid-multitouch: class MT_CLS_STANTUM is redundant with MT_CLS_CONFIDENCE From: Benjamin Tissoires To: Jiri Kosina Cc: Dmitry Torokhov , Henrik Rydberg , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2011 at 10:35, Jiri Kosina wrote: > On Thu, 19 May 2011, Benjamin Tissoires wrote: > >> Stantum devices used to work with MT_CLS_STANTUM but MT_CLS_CONFIDENCE >> is exactly the same. This patch switches them to this generic class, >> and remove the unused MT_CLS_STANTUM. >> >> Signed-off-by: Benjamin Tissoires >> --- >>  drivers/hid/hid-multitouch.c |    9 +++------ >>  1 files changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c >> index feeb0b7..65b92d2 100644 >> --- a/drivers/hid/hid-multitouch.c >> +++ b/drivers/hid/hid-multitouch.c >> @@ -88,7 +88,6 @@ struct mt_class { >>  #define MT_CLS_DUAL_INRANGE_CONTACTNUMBER    3 >>  #define MT_CLS_CYPRESS                               4 >>  #define MT_CLS_EGALAX                                5 >> -#define MT_CLS_STANTUM                               6 >>  #define MT_CLS_3M                            7 >>  #define MT_CLS_CONFIDENCE                    8 >>  #define MT_CLS_CONFIDENCE_MINUS_ONE          9 > > Benjamin, > > is it intentional that you are leaving the hole in the numbering here? > > I don't think there would be any issue with re-numbering 7-10, would it? Well, the first time I tried to renumber those classes (to keep them alphabetically sorted), I've been told not to do it. That's why I let the hole in this case. There won't be any issue in renumbering those classes (and we could sort them). Maybe I can just send a new patch on top of this to sort them. Cheers, Benjamin PS: and thank you very much for applying so quickly the last patches I sent. > > -- > Jiri Kosina > SUSE Labs > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH 6/6] hid-multitouch: class MT_CLS_STANTUM is redundant with MT_CLS_CONFIDENCE Date: Fri, 20 May 2011 12:32:23 +0200 Message-ID: References: <1305807498-8785-1-git-send-email-benjamin.tissoires@enac.fr> <1305807498-8785-7-git-send-email-benjamin.tissoires@enac.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:53240 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935523Ab1ETKcY convert rfc822-to-8bit (ORCPT ); Fri, 20 May 2011 06:32:24 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Dmitry Torokhov , Henrik Rydberg , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, May 20, 2011 at 10:35, Jiri Kosina wrote: > On Thu, 19 May 2011, Benjamin Tissoires wrote: > >> Stantum devices used to work with MT_CLS_STANTUM but MT_CLS_CONFIDEN= CE >> is exactly the same. This patch switches them to this generic class, >> and remove the unused MT_CLS_STANTUM. >> >> Signed-off-by: Benjamin Tissoires >> --- >> =A0drivers/hid/hid-multitouch.c | =A0 =A09 +++------ >> =A01 files changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitou= ch.c >> index feeb0b7..65b92d2 100644 >> --- a/drivers/hid/hid-multitouch.c >> +++ b/drivers/hid/hid-multitouch.c >> @@ -88,7 +88,6 @@ struct mt_class { >> =A0#define MT_CLS_DUAL_INRANGE_CONTACTNUMBER =A0 =A03 >> =A0#define MT_CLS_CYPRESS =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 4 >> =A0#define MT_CLS_EGALAX =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A05 >> -#define MT_CLS_STANTUM =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 6 >> =A0#define MT_CLS_3M =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A07 >> =A0#define MT_CLS_CONFIDENCE =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= 8 >> =A0#define MT_CLS_CONFIDENCE_MINUS_ONE =A0 =A0 =A0 =A0 =A09 > > Benjamin, > > is it intentional that you are leaving the hole in the numbering here= ? > > I don't think there would be any issue with re-numbering 7-10, would = it? Well, the first time I tried to renumber those classes (to keep them alphabetically sorted), I've been told not to do it. That's why I let the hole in this case. There won't be any issue in renumbering those classes (and we could sor= t them). Maybe I can just send a new patch on top of this to sort them. Cheers, Benjamin PS: and thank you very much for applying so quickly the last patches I = sent. > > -- > Jiri Kosina > SUSE Labs > -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html