All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio@ossystems.com.br>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] busybox: enable mdev by default
Date: Mon, 23 May 2011 13:10:41 +0000	[thread overview]
Message-ID: <BANLkTim7rTzXxBtqdaC_Lw24T+hRsDrudA@mail.gmail.com> (raw)
In-Reply-To: <1306156002.2525.79.camel@phil-desktop>

On Mon, May 23, 2011 at 13:06, Phil Blundell <pb@pbcl.net> wrote:
> On Mon, 2011-05-23 at 12:13 +0000, Otavio Salvador wrote:
>>  CONFIG_LOSETUP=y
>>  # CONFIG_LSPCI is not set
>>  # CONFIG_LSUSB is not set
>> -# CONFIG_MDEV is not set
>> +CONFIG_MDEV=y
>>  # CONFIG_FEATURE_MDEV_CONF is not set
>>  # CONFIG_FEATURE_MDEV_RENAME is not set
>>  # CONFIG_FEATURE_MDEV_RENAME_REGEXP is not set
>
> This sort of thing, as we've seen previously in classic oe, doesn't
> really scale very well since everyone's requirements for busybox are
> subtly different.  Others will doubtless disagree but, personally, I
> think it would be best for you to just maintain a busybox.conf in your
> own distro layer which sets it up the way that you want.

Yes.

>> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
>> index 341c5c4..de711d2 100644
>> --- a/meta/recipes-core/busybox/busybox.inc
>> +++ b/meta/recipes-core/busybox/busybox.inc
>> @@ -29,7 +29,6 @@ INITSCRIPT_PARAMS_${PN}-mdev = "start 06 S ."
>>  INITSCRIPT_NAME_${PN}-udhcpd = "busybox-udhcpd"
>>  INITSCRIPT_NAME_${PN}-udhcpc = "busybox-udhcpc"
>>  CONFFILES_${PN}-syslog = "${sysconfdir}/syslog.conf.${PN}"
>> -CONFFILES_${PN}-mdev = "${sysconfdir}/mdev.conf"
>
> Agreed, it seems silly to declare the file as a CONFFILE if we aren't
> shipping it in the first place.

The idea is to not require it to be declared and do the right thing by default.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br



  reply	other threads:[~2011-05-23 13:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 12:13 [PATCH 0/3] Pull request with misc fixes from O.S. Systems tree Otavio Salvador
2011-05-23 12:13 ` [PATCH 1/3] send-pull-request: drop sendemail checks Otavio Salvador
2011-05-23 12:13 ` [PATCH 2/3] busybox: enable mdev by default Otavio Salvador
2011-05-23 13:06   ` Phil Blundell
2011-05-23 13:10     ` Otavio Salvador [this message]
2011-05-23 12:13 ` [PATCH 3/3] syslinux: rdepends on mtools Otavio Salvador
2011-05-25 17:16 ` [PATCH 0/3] Pull request with misc fixes from O.S. Systems tree Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTim7rTzXxBtqdaC_Lw24T+hRsDrudA@mail.gmail.com \
    --to=otavio@ossystems.com.br \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.