From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932900Ab1EaW4F (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2011 18:56:05 -0400
Received: from mail-pw0-f46.google.com ([209.85.160.46]:39800 "EHLO
	mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932869Ab1EaW4E convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2011 18:56:04 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=FxJ2bbBoy7tT2axI5Bxl8VYZoNaY3a6e2dUxo7lPkl14avboXQyyPw2HvuYObx+5Fr
         gRJKq0UZmB+ojLf54H4q4ZDGijLx95rUIra1RpPgS1WSfBw5o9NAgBg6RKd4CHUkYOIg
         +JyoAuJ4vOEzbIzS6cFl95c3Vb12dTc1FtKVc=
MIME-Version: 1.0
In-Reply-To: <1306301804-12319-1-git-send-email-lacombar@gmail.com>
References: <1306301804-12319-1-git-send-email-lacombar@gmail.com>
Date: Tue, 31 May 2011 18:56:02 -0400
Message-ID: <BANLkTim8=HGpN65sdRnwE_yPX4oO7CWOWA@mail.gmail.com>
Subject: Re: [PATCH] kconfig: do not overwrite symbol direct dependency in assignment
From: Arnaud Lacombe <lacombar@gmail.com>
To: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michal Marek <mmarek@suse.cz>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wed, May 25, 2011 at 1:36 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Considering the following configuration:
>
> config F
>    bool "F"
>
> choice AB
>    bool "AB"
> config A
>    bool "A"
> config B
>    bool "B"
> endchoice
>
> if A
> config D
>    bool
>    default y if F
>    select E
> config E
>    bool "E"
> endif
>
> if B
> config D
>    bool
>    default y if F
>    select E
> config E
>    bool "E"
> endif
>
> The following configuration:
>
> CONFIG_F=y
> CONFIG_A=y
> CONFIG_D=y
> CONFIG_E=y
>
> emits a spurious warning:
>
> (D) selects E which has unmet direct dependencies (B)
>
> If a symbol appears in two different branch of the tree, it should inherit the
> dependency of both parent, not just the last one.
>
> Reported-by: Yann E. Morin <yann.morin.1998@anciens.enib.fr>
> Tested-by: Yann E. Morin <yann.morin.1998@anciens.enib.fr>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
>  scripts/kconfig/menu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
ping ?

> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index 5fdf10d..d0c65e7 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -350,7 +350,7 @@ void menu_finalize(struct menu *parent)
>                        last_menu->next = NULL;
>                }
>
> -               sym->dir_dep.expr = parent->dep;
> +               sym->dir_dep.expr = expr_alloc_or(sym->dir_dep.expr, parent->dep);
>        }
>        for (menu = parent->list; menu; menu = menu->next) {
>                if (sym && sym_is_choice(sym) &&
> --
> 1.7.3.4.574.g608b.dirty
>
>