From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934622Ab1ETBIt (ORCPT ); Thu, 19 May 2011 21:08:49 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:55962 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934262Ab1ETBIs convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2011 21:08:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=iSgsiR9b2UjLpLS98WEB+W4SL6toa2DWRMZ1ChqDQ7u2+B7XAdMsXhJMoeTXeYhSqX zzknPWRH+B1N9fY/3A0oBj79INHSDIESFdLt2w3nRtVk/7q6Rwh7sO/Ifmq1v1Kx8aRG WxmUFoz3u4aQrmL3XNHAWyLa4J0k17EjPlR7M= MIME-Version: 1.0 In-Reply-To: <1305851709.7481.89.camel@pasglop> References: <1305753895-24845-1-git-send-email-ericvh@gmail.com> <1305753895-24845-2-git-send-email-ericvh@gmail.com> <1305851709.7481.89.camel@pasglop> Date: Thu, 19 May 2011 20:08:46 -0500 Message-ID: Subject: Re: [PATCH 2/7] [RFC] add bluegene entry to cputable From: Eric Van Hensbergen To: Benjamin Herrenschmidt Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bg-linux@lists.anl-external.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2011 at 7:35 PM, Benjamin Herrenschmidt wrote: > On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: >> +             .dcache_bsize           = 32, >> +             .cpu_setup              = __setup_cpu_460gt, >                                            ^^^^^^^^^^^^^^^^^^ > Are you sure ? > That surprised me too, I figured it must have been a close enough match (at least in the 2.6.29.1 time frame which is where I'm trying to merge the BG/P patches up from. The kittyhawk patches don't even use this, so its possible we could just remove it. _GLOBAL(__setup_cpu_460ex) _GLOBAL(__setup_cpu_460gt) mflr r4 bl __init_fpu_44x bl __fixup_440A_mcheck mtlr r4 blr Looks like the 460 setup invokes a bunch of 440 calls! Would you prefer I setup my own entry point (setup_cpu_bgp or setup_cpu_450) which makes the same calls? -eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-fx0-f51.google.com (mail-fx0-f51.google.com [209.85.161.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 2D5F6B71C1 for ; Fri, 20 May 2011 11:08:50 +1000 (EST) Received: by fxm5 with SMTP id 5so2702009fxm.38 for ; Thu, 19 May 2011 18:08:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1305851709.7481.89.camel@pasglop> References: <1305753895-24845-1-git-send-email-ericvh@gmail.com> <1305753895-24845-2-git-send-email-ericvh@gmail.com> <1305851709.7481.89.camel@pasglop> Date: Thu, 19 May 2011 20:08:46 -0500 Message-ID: Subject: Re: [PATCH 2/7] [RFC] add bluegene entry to cputable From: Eric Van Hensbergen To: Benjamin Herrenschmidt Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, bg-linux@lists.anl-external.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 19, 2011 at 7:35 PM, Benjamin Herrenschmidt wrote: > On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: >> + =A0 =A0 =A0 =A0 =A0 =A0 .dcache_bsize =A0 =A0 =A0 =A0 =A0 =3D 32, >> + =A0 =A0 =A0 =A0 =A0 =A0 .cpu_setup =A0 =A0 =A0 =A0 =A0 =A0 =A0=3D __se= tup_cpu_460gt, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0^^^^^^^^^^^^^^^^^^ > Are you sure ? > That surprised me too, I figured it must have been a close enough match (at least in the 2.6.29.1 time frame which is where I'm trying to merge the BG/P patches up from. The kittyhawk patches don't even use this, so its possible we could just remove it. _GLOBAL(__setup_cpu_460ex) _GLOBAL(__setup_cpu_460gt) mflr r4 bl __init_fpu_44x bl __fixup_440A_mcheck mtlr r4 blr Looks like the 460 setup invokes a bunch of 440 calls! Would you prefer I setup my own entry point (setup_cpu_bgp or setup_cpu_450) which makes the same calls? -eric