From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJNWG-0000sD-Cw for qemu-devel@nongnu.org; Mon, 09 May 2011 06:16:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJNWF-0004RA-JZ for qemu-devel@nongnu.org; Mon, 09 May 2011 06:16:52 -0400 MIME-Version: 1.0 In-Reply-To: <4DC79DEC.50401@redhat.com> References: <4DC29287.5030106@redhat.com> <4DC79DEC.50401@redhat.com> Date: Mon, 9 May 2011 12:16:50 +0200 Message-ID: From: Jan Vesely Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely --- hw/usb-uhci.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index a65e0b3..1e9c1e7 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -702,11 +702,15 @@ out: case USB_RET_STALL: td->ctrl |= TD_CTRL_STALL; td->ctrl &= ~TD_CTRL_ACTIVE; + s->status |= UHCI_STS_USBERR; + uhci_update_irq(s); return 1; case USB_RET_BABBLE: td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL; td->ctrl &= ~TD_CTRL_ACTIVE; + s->status |= UHCI_STS_USBERR; + uhci_update_irq(s); /* frame interrupted */ return -1; -- 1.7.3.4