All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>
Subject: Re: blame --reverse selecting wrong commit
Date: Sun, 29 May 2011 20:11:19 -0700	[thread overview]
Message-ID: <BANLkTimXppE9sCW8tMntbD8p5-bRVFLHmQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimAij28ibW3DV2HaHPK5z0D-CrDHQ@mail.gmail.com>

On Sun, May 29, 2011 at 19:33, Shawn Pearce <spearce@spearce.org> wrote:
> On Sun, May 29, 2011 at 19:21, Shawn Pearce <spearce@spearce.org> wrote:
>> Although blame shows Stefan Lay removed the block in commit 05fa1713,
>> this isn't what happened. It was actually removed in commit 2302a6d3
>> by Christian Halstrick. It looks like blame gets confused around this
>> section of the JGit history.

Oh. Re-reading the man page for git blame helps. It says blame shows
the last revision that a line exists in, rather than the revision that
removed the line. IMHO, I expected reverse to show me the revision
that deleted (or replaced) that line, so I can inspect the commit
message and the contents of the patch. Showing me one of the potential
parents of that revision seems to be nearly useless.

Rereading commit 85af7929ee ("git-blame --reverse"), it seems you left
this an "exercise for the reader"... and in the past 3 years, no
reader has stepped forward to implement the exercise as a patch to
blame. *sigh*

-- 
Shawn.

  reply	other threads:[~2011-05-30  3:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  2:21 blame --reverse selecting wrong commit Shawn Pearce
2011-05-30  2:33 ` Shawn Pearce
2011-05-30  3:11   ` Shawn Pearce [this message]
2011-05-30  6:47     ` Junio C Hamano
2011-05-30 17:57       ` Shawn Pearce
2011-05-30 20:01         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimXppE9sCW8tMntbD8p5-bRVFLHmQ@mail.gmail.com \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.