From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 26B916B0024 for ; Fri, 20 May 2011 00:03:36 -0400 (EDT) Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p4K43S4g012658 for ; Thu, 19 May 2011 21:03:33 -0700 Received: from qyk10 (qyk10.prod.google.com [10.241.83.138]) by kpbe17.cbf.corp.google.com with ESMTP id p4K43QOP030924 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 19 May 2011 21:03:27 -0700 Received: by qyk10 with SMTP id 10so2254613qyk.11 for ; Thu, 19 May 2011 21:03:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110520125046.963d06e9.kamezawa.hiroyu@jp.fujitsu.com> References: <1305861891-26140-1-git-send-email-yinghan@google.com> <1305861891-26140-3-git-send-email-yinghan@google.com> <20110520125046.963d06e9.kamezawa.hiroyu@jp.fujitsu.com> Date: Thu, 19 May 2011 21:03:26 -0700 Message-ID: Subject: Re: [PATCH V4 3/3] memcg: add memory.numastat api for numa statistics From: Ying Han Content-Type: multipart/alternative; boundary=000e0ce008bc2673df04a3ad3447 Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro , Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org --000e0ce008bc2673df04a3ad3447 Content-Type: text/plain; charset=ISO-8859-1 On Thu, May 19, 2011 at 8:50 PM, KAMEZAWA Hiroyuki < kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Thu, 19 May 2011 20:24:51 -0700 > Ying Han wrote: > > > The new API exports numa_maps per-memcg basis. This is a piece of useful > > information where it exports per-memcg page distribution across real numa > > nodes. > > > > One of the usecase is evaluating application performance by combining > this > > information w/ the cpu allocation to the application. > > > > The output of the memory.numastat tries to follow w/ simiar format of > numa_maps > > like: > > > > total= N0= N1= ... > > file= N0= N1= ... > > anon= N0= N1= ... > > unevictable= N0= N1= ... > > > > And we have per-node: > > total = file + anon + unevictable > > > > $ cat /dev/cgroup/memory/memory.numa_stat > > total=250020 N0=87620 N1=52367 N2=45298 N3=64735 > > file=225232 N0=83402 N1=46160 N2=40522 N3=55148 > > anon=21053 N0=3424 N1=6207 N2=4776 N3=6646 > > unevictable=3735 N0=794 N1=0 N2=0 N3=2941 > > > > change v4..v3: > > 1. add per-node "unevictable" value. > > 2. change the functions to be static. > > > > change v3..v2: > > 1. calculate the "total" based on the per-memcg lru size instead of > rss+cache. > > this makes the "total" value to be consistant w/ the per-node values > follows > > after. > > > > change v2..v1: > > 1. add also the file and anon pages on per-node distribution. > > > > Signed-off-by: Ying Han > > Seems fine. Thank you for patient work. > > Acked-by: KAMEZAWA Hiroyuki > Sure. thank you for reviewing it. Thanks --Ying --000e0ce008bc2673df04a3ad3447 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, May 19, 2011 at 8:50 PM, KAMEZAW= A Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
On Thu, 19 May 2011 20:24:51 -0700
Ying Han <yinghan@google.com&g= t; wrote:

> The new API exports numa_maps per-memcg basis. This is a piece of usef= ul
> information where it exports per-memcg page distribution across real n= uma
> nodes.
>
> One of the usecase is evaluating application performance by combining = this
> information w/ the cpu allocation to the application.
>
> The output of the memory.numastat tries to follow w/ simiar format of = numa_maps
> like:
>
> total=3D<total pages> N0=3D<node 0 pages> N1=3D<node 1 = pages> ...
> file=3D<total file pages> N0=3D<node 0 pages> N1=3D<nod= e 1 pages> ...
> anon=3D<total anon pages> N0=3D<node 0 pages> N1=3D<nod= e 1 pages> ...
> unevictable=3D<total anon pages> N0=3D<node 0 pages> N1=3D= <node 1 pages> ...
>
> And we have per-node:
> total =3D file + anon + unevictable
>
> $ cat /dev/cgroup/memory/memory.numa_stat
> total=3D250020 N0=3D87620 N1=3D52367 N2=3D45298 N3=3D64735
> file=3D225232 N0=3D83402 N1=3D46160 N2=3D40522 N3=3D55148
> anon=3D21053 N0=3D3424 N1=3D6207 N2=3D4776 N3=3D6646
> unevictable=3D3735 N0=3D794 N1=3D0 N2=3D0 N3=3D2941
>
> change v4..v3:
> 1. add per-node "unevictable" value.
> 2. change the functions to be static.
>
> change v3..v2:
> 1. calculate the "total" based on the per-memcg lru size ins= tead of rss+cache.
> this makes the "total" value to be consistant w/ the per-nod= e values follows
> after.
>
> change v2..v1:
> 1. add also the file and anon pages on per-node distribution.
>
> Signed-off-by: Ying Han <ying= han@google.com>

Seems fine. Thank you for patient work.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Sure. thank you for reviewing it.

Thanks

--Ying=A0

--000e0ce008bc2673df04a3ad3447-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org