From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:56429 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122Ab1EAIDB (ORCPT ); Sun, 1 May 2011 04:03:01 -0400 Received: by wwa36 with SMTP id 36so5458184wwa.1 for ; Sun, 01 May 2011 01:03:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 1 May 2011 01:02:59 -0700 Message-ID: (sfid-20110501_100307_527139_BE274AE9) Subject: Re: (no subject) From: Dan Carpenter To: Naveen Singh Cc: gregkh@suse.de, devel@linuxdriverproject.org, linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 5/1/11, Dan Carpenter wrote: > On 4/30/11, Naveen Singh wrote: >> --- a/drivers/staging/ath6kl/os/linux/cfg80211.c >> +++ b/drivers/staging/ath6kl/os/linux/cfg80211.c >> @@ -1455,6 +1455,11 @@ ar6k_cfg80211_init(struct device *dev) >> wdev->wiphy->cipher_suites = cipher_suites; >> wdev->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites); >> >> + /*Support the seprate keys for unicast and multicast packets >> + *This flag is needed because because nl80211 checks for this >> + *flag before calling cfg ops for setting the key.*/ >> + wdev->wiphy->flags |= WIPHY_FLAG_SUPPORTS_SEPARATE_DEFAULT_KEYS; >> + > > No subject. Comment style wrong. Please read CodingStyle and resend. > Also your email address is wrong so my reply bounced. (The 'n' and 's' were transposed). regards, dan carpenter