From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933458Ab1ESP7y (ORCPT ); Thu, 19 May 2011 11:59:54 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:59430 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933014Ab1ESP7x (ORCPT ); Thu, 19 May 2011 11:59:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ZGAL3gIhJoH/9Aa5kXMOoLaHETQjNQrGTXnMCtW5i6dpUPSj85quj+njJg8JZzWKEh 54NwH8DKaz6GVoVTnbMHEtQJiwxw1KYL/mXe3gkZe8BiKn1h1+qUyXgnS8UWbgzKvK0O zepTEiqXoAlH1+mZzBuFoSGpwnXNcUbWi519Y= MIME-Version: 1.0 In-Reply-To: References: <1305196419.2713.84.camel@localhost> <1305751647-3122-1-git-send-email-bengardiner@nanometrics.ca> Date: Thu, 19 May 2011 11:59:52 -0400 Message-ID: Subject: Re: [PATCH] UBIFS: don't fail on -EBADMSG when fixing free space From: "Matthew L. Creech" To: Ben Gardiner Cc: Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2011 at 9:28 AM, Ben Gardiner wrote: > > So I guess my particular situation is a problem with the davinci nand > driver's ECC for 0xFF data and is _not_ covered by the free space > fixup? > Yeah, that's what it sounds like. Can you reproduce the -EBADMSG with a simpler test case that leaves UBI/UBIFS out of the equation? Maybe enable write-verify in U-Boot and try using "nand write" again, or use mtd-utils "nandwrite" from an initramfs image then try to read back the data -- that should give a simpler test case that shows whether the ECC handling of empty space is wrong. If so, that probably needs to be fixed at the MTD level, since it will affect more than this particular UBIFS case. -- Matthew L. Creech From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vw0-f49.google.com ([209.85.212.49]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QN5dh-00064I-VJ for linux-mtd@lists.infradead.org; Thu, 19 May 2011 15:59:54 +0000 Received: by vws8 with SMTP id 8so2550887vws.36 for ; Thu, 19 May 2011 08:59:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1305196419.2713.84.camel@localhost> <1305751647-3122-1-git-send-email-bengardiner@nanometrics.ca> Date: Thu, 19 May 2011 11:59:52 -0400 Message-ID: Subject: Re: [PATCH] UBIFS: don't fail on -EBADMSG when fixing free space From: "Matthew L. Creech" To: Ben Gardiner Content-Type: text/plain; charset=ISO-8859-1 Cc: Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 19, 2011 at 9:28 AM, Ben Gardiner wrote: > > So I guess my particular situation is a problem with the davinci nand > driver's ECC for 0xFF data and is _not_ covered by the free space > fixup? > Yeah, that's what it sounds like. Can you reproduce the -EBADMSG with a simpler test case that leaves UBI/UBIFS out of the equation? Maybe enable write-verify in U-Boot and try using "nand write" again, or use mtd-utils "nandwrite" from an initramfs image then try to read back the data -- that should give a simpler test case that shows whether the ECC handling of empty space is wrong. If so, that probably needs to be fixed at the MTD level, since it will affect more than this particular UBIFS case. -- Matthew L. Creech