From: David Barr <davidbarr@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/3] protobuf: minimal implementation for compact in-memory structures
Date: Fri, 24 Jun 2011 07:39:42 -0700 [thread overview]
Message-ID: <BANLkTimov2ZFYZjU4=CXPE8yjH8cMs3HCg@mail.gmail.com> (raw)
In-Reply-To: <7voc1p64ap.fsf@alter.siamese.dyndns.org>
Junio,
Sorry for the repeat, accidentally sent as HTML, rejected by the list.
On Thursday, June 23, 2011, Junio C Hamano wrote:
David Barr <davidbarr@google.com> writes:
> One struct to capture all types, just 4 methods: decode_message,
> encode_message, sizeof_message, hash_field.
Adding to the review from yesterday, hash_field() looked quite out of
place. If you are going to implement a hash table that holds protobuf
objects in a separate file/module, I would imagine the function belongs
there, not here.
I agree completely, another artifact of refactoring from experimental code.
--
David Barr
next prev parent reply other threads:[~2011-06-24 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 7:33 [RFC/PATCH 0/3] David Barr
2011-06-22 7:33 ` [RFC/PATCH 1/3] protobuf: minimal implementation for compact in-memory structures David Barr
2011-06-22 19:42 ` Junio C Hamano
2011-06-24 14:39 ` David Barr [this message]
2011-06-24 16:04 ` David Barr
2011-06-24 16:48 ` Junio C Hamano
2011-06-23 17:22 ` Junio C Hamano
2011-06-22 7:33 ` [RFC/PATCH 2/3] small-alloc: add allocator for small objects David Barr
2011-06-22 20:49 ` Junio C Hamano
2011-06-24 14:38 ` David Barr
2011-06-24 17:02 ` David Barr
2011-06-23 17:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimov2ZFYZjU4=CXPE8yjH8cMs3HCg@mail.gmail.com' \
--to=davidbarr@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.