From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:32899)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QLcJv-00020r-TS
	for qemu-devel@nongnu.org; Sun, 15 May 2011 10:29:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QLcJv-0001uO-0g
	for qemu-devel@nongnu.org; Sun, 15 May 2011 10:29:23 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:41226)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1QLcJu-0001uK-U6
	for qemu-devel@nongnu.org; Sun, 15 May 2011 10:29:22 -0400
Received: by iym10 with SMTP id 10so3723226iym.4
	for <qemu-devel@nongnu.org>; Sun, 15 May 2011 07:29:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1305468801-6015-3-git-send-email-aurelien@aurel32.net>
References: <1305468801-6015-1-git-send-email-aurelien@aurel32.net>
	<1305468801-6015-3-git-send-email-aurelien@aurel32.net>
Date: Sun, 15 May 2011 15:29:21 +0100
Message-ID: <BANLkTimsBnz8UH90w1EqdONxjvPa7wosaw@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 02/11] target-mips/gdbstub: remove old
 CONFIG_SOFTFLOAT #ifdef
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 15 May 2011 15:13, Aurelien Jarno <aurelien@aurel32.net> wrote:
> target-mips has been switched to softfloat only long ago, but a
> few #ifdef CONFIG_SOFTFLOAT have been forgotten. Remove them.

> -#ifndef CONFIG_SOFTFLOAT
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* no floating point exception =
for native float */
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SET_FP_ENABLE(env->active_fpu.f=
cr31, 0);
> -#endif

Shouldn't the whole of this section be removed? This is
an #ifndef, not a #ifdef...

-- PMM