All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Jesper Juhl <jj@chaosbits.net>,
	linux-kernel@vger.kernel.org, Nick Piggin <npiggin@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] sysctl: remove impossible condition check
Date: Thu, 2 Jun 2011 10:51:15 -0300	[thread overview]
Message-ID: <BANLkTimu68E0_U0w8XAtLQztHY6vJqkPVQ@mail.gmail.com> (raw)
In-Reply-To: <m1y61kfj2a.fsf@fess.ebiederm.org>

On Thu, Jun 2, 2011 at 10:40 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>> Looking again at the code, I'm wondering if this is not actually a
>> bug. There might be entries with procname == NULL, meaning they are
>> not mirrored in /proc. What seems wrong is the condition in the for().
>> It should stop when all fields are 0 (meaning the end of the table)
>> instead of stopping when procname is NULL.
>
> It is not a bug.  The condition was originally p->ctlname then
> it became p->ctlname || p->procname and then finally I was able to
> kill ctl_name.
>
> What you see is a left over that didn't get removed.
>

Alright then.

> This is also the second time in the last couple of weeks someone has
> sent this patch.
>
> There is some ongoing work to make sysctl scale better that with
> any luck should be ready for 3.1.  Decide which version of this
> patch you like and please resend, and I will add this to my
> sysctl tree.

There's also the same thing in this file, in scan() function. I'll add
it to the previous patch and resend.

thanks
Lucas De Marchi

  reply	other threads:[~2011-06-02 13:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 13:15 [PATCH] sysctl: remove impossible condition check Lucas De Marchi
2011-06-01 13:25 ` Jesper Juhl
2011-06-01 14:11   ` Lucas De Marchi
2011-06-02 13:40     ` Eric W. Biederman
2011-06-02 13:51       ` Lucas De Marchi [this message]
2011-06-02 16:00         ` Lucas De Marchi
     [not found]           ` <1307684165-14742-1-git-send-email-lucas.demarchi@profusion.mobi>
2011-06-10  7:56             ` Jesper Juhl
2011-06-12  6:02               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimu68E0_U0w8XAtLQztHY6vJqkPVQ@mail.gmail.com \
    --to=lucas.demarchi@profusion.mobi \
    --cc=ebiederm@xmission.com \
    --cc=hch@lst.de \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@kernel.dk \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.