From: Khem Raj <raj.khem@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] distcc_2.18.3.bb: Fix compilation on uclibc
Date: Sat, 21 May 2011 16:03:52 -0700 [thread overview]
Message-ID: <BANLkTin-6yeHq3R9drDBysuHXWquQfOiDw@mail.gmail.com> (raw)
In-Reply-To: <2A972D3F-1633-4B54-8E59-87D815DECDAD@dominion.thruhere.net>
On Sat, May 21, 2011 at 12:17 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 21 mei 2011, om 09:19 heeft Khem Raj het volgende geschreven:
>
>>
>>
>> -Khem
>>
>> On May 20, 2011, at 11:34 PM, Phil Blundell <pb@pbcl.net> wrote:
>>
>>> On Fri, 2011-05-20 at 16:19 -0700, Khem Raj wrote:
>>>> -DEPENDS = "avahi gtk+"
>>>> +DEPENDS = "avahi ${GTKDEP}"
>>>> +GTKDEP-libc-uclibc = ""
>>>> +GTKDEP = "gtk+"
>>>
>>> Does that really work? Surely it should be "GTKDEP_libc-uclibc".
>>>
>>
>> No it does not RP pointed it out earlier and I have since fixed it
>>
>>>> -EXTRA_OECONF = " --with-gtk "
>>>> -
>>>> +EXTRA_OECONF_libc-glibc = " --with-gtk "
>>>> +EXTRA_OECONF_libc-uclibc = " --without-gtk --without-gnome "
>>>
>>> Can you make this use the same logic as above?
>>>
>>
>> Is there a problem with this logic ?
>>
>>>> +DESKTOPINSTALL = ""
>>>> +DESKTOPINSTALL_libc-glibc () {
>>>> + install -d ${D}${datadir}/distcc/
>>>> install -m 0644 ${WORKDIR}/distccmon-gnome.desktop ${D}${datadir}/distcc/
>>>> }
>>>
>>> Likewise, or find some way to eliminate it entirely.
>>>
>>>> -
>>>> -PACKAGES += "distcc-distmon-gnome"
>>>> +PACKAGES_append_libc-glibc = " distcc-distmon-gnome"
>>>
>>> Is that needed?
>>>
>>
>> May be not it will just be empty in uclibc case
>
> since ALLOW_EMPTY is not set, this change is unneeded.
I have include these comments in the new version pushed to pull
branch. Hopefully this time its ok.
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2011-05-21 23:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 23:19 [PATCH 0/2] Opkg and distcc fix Khem Raj
2011-05-20 23:19 ` [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS} Khem Raj
2011-05-20 23:30 ` Saul Wold
2011-05-21 0:41 ` Khem Raj
2011-05-21 8:00 ` Phil Blundell
2011-05-21 23:04 ` Khem Raj
2011-05-20 23:19 ` [PATCH 2/2] distcc_2.18.3.bb: Fix compilation on uclibc Khem Raj
2011-05-20 23:31 ` Richard Purdie
2011-05-21 0:43 ` Khem Raj
2011-05-21 0:48 ` Khem Raj
2011-05-21 6:23 ` Koen Kooi
2011-05-21 6:34 ` Phil Blundell
2011-05-21 7:19 ` Khem Raj
2011-05-21 7:45 ` Phil Blundell
2011-05-21 19:17 ` Koen Kooi
2011-05-21 23:03 ` Khem Raj [this message]
2011-05-23 19:09 ` [PATCH 0/2] Opkg and distcc fix Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTin-6yeHq3R9drDBysuHXWquQfOiDw@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.