From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 36A716B0012 for ; Thu, 19 May 2011 22:54:58 -0400 (EDT) Received: from hpaq6.eem.corp.google.com (hpaq6.eem.corp.google.com [172.25.149.6]) by smtp-out.google.com with ESMTP id p4K2ss2Y003773 for ; Thu, 19 May 2011 19:54:54 -0700 Received: from qyk2 (qyk2.prod.google.com [10.241.83.130]) by hpaq6.eem.corp.google.com with ESMTP id p4K2smRf013299 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 19 May 2011 19:54:53 -0700 Received: by qyk2 with SMTP id 2so53158qyk.0 for ; Thu, 19 May 2011 19:54:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110520111105.d6f5ca1b.nishimura@mxp.nes.nec.co.jp> References: <1305826360-2167-1-git-send-email-yinghan@google.com> <1305826360-2167-2-git-send-email-yinghan@google.com> <20110520111105.d6f5ca1b.nishimura@mxp.nes.nec.co.jp> Date: Thu, 19 May 2011 19:54:46 -0700 Message-ID: Subject: Re: [PATCH V3 2/3] memcg: fix a routine for counting pages in node From: Ying Han Content-Type: multipart/alternative; boundary=0016360e3f5c94710504a3ac3e96 Sender: owner-linux-mm@kvack.org List-ID: To: Daisuke Nishimura Cc: KOSAKI Motohiro , Minchan Kim , Balbir Singh , Tejun Heo , Pavel Emelyanov , KAMEZAWA Hiroyuki , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org --0016360e3f5c94710504a3ac3e96 Content-Type: text/plain; charset=ISO-8859-1 On Thu, May 19, 2011 at 7:11 PM, Daisuke Nishimura < nishimura@mxp.nes.nec.co.jp> wrote: > Acked-by: Daisuke Nishimura > > This is a bugfix for > memcg-reclaim-memory-from-nodes-in-round-robin-order.patch > in mmotm tree, so I think it would be better to note about it. > Sounds good, and I will add that comment in next post. Thanks for reviewing it. --Ying > > On Thu, 19 May 2011 10:32:39 -0700 > Ying Han wrote: > > > The value for counter base should be initialized. If not, > > this returns wrong value. > > > > Signed-off-by: KAMEZAWA Hiroyuki > > --- > > mm/memcontrol.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index da183dc..e14677c 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -679,7 +679,7 @@ static unsigned long > > mem_cgroup_get_zonestat_node(struct mem_cgroup *mem, int nid, enum > lru_list idx) > > { > > struct mem_cgroup_per_zone *mz; > > - u64 total; > > + u64 total = 0; > > int zid; > > > > for (zid = 0; zid < MAX_NR_ZONES; zid++) { > > -- > > 1.7.3.1 > > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign > http://stopthemeter.ca/ > Don't email: email@kvack.org > --0016360e3f5c94710504a3ac3e96 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, May 19, 2011 at 7:11 PM, Daisuke= Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>

This is a bugfix for memcg-reclaim-memory-from-nodes-in-round-robin-order.p= atch
in mmotm tree, so I think it would be better to note about it.

Sounds good, and I will add that comment in next po= st.

Thanks for reviewing it.

--Ying=A0

On Thu, 19 May 2011 10:32:39 -0700
Ying Han <yingha= n@google.com> wrote:

> The value for counter base should be initialized. If not,
> this returns wrong value.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > ---
> =A0mm/memcontrol.c | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index da183dc..e14677c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -679,7 +679,7 @@ static unsigned long
> =A0mem_cgroup_get_zonestat_node(struct mem_cgroup *mem, int nid, enum = lru_list idx)
> =A0{
> =A0 =A0 =A0 struct mem_cgroup_per_zone *mz;
> - =A0 =A0 u64 total;
> + =A0 =A0 u64 total =3D 0;
> =A0 =A0 =A0 int zid;
>
> =A0 =A0 =A0 for (zid =3D 0; zid < MAX_NR_ZONES; zid++) {
> --
> 1.7.3.1
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majord= omo@kvack.org. =A0For more info on Linux MM,
see: http://www.linu= x-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=3Dmailto:"dont@kvack.org"> email@kvack.org </a>

--0016360e3f5c94710504a3ac3e96-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org