From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNN0G-0000JL-GM for qemu-devel@nongnu.org; Fri, 20 May 2011 06:32:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNN0E-0001KN-Ru for qemu-devel@nongnu.org; Fri, 20 May 2011 06:32:20 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:50498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNN0E-0001K5-Ov for qemu-devel@nongnu.org; Fri, 20 May 2011 06:32:18 -0400 Received: by iwl42 with SMTP id 42so3455013iwl.4 for ; Fri, 20 May 2011 03:32:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1305468801-6015-7-git-send-email-aurelien@aurel32.net> References: <1305468801-6015-1-git-send-email-aurelien@aurel32.net> <1305468801-6015-7-git-send-email-aurelien@aurel32.net> Date: Fri, 20 May 2011 11:32:17 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 06/11] target-i386: use floatx80 constants in helper_fld*_ST0() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , qemu-devel@nongnu.org On 15 May 2011 15:13, Aurelien Jarno wrote: > Instead of using a table which doesn't correspond to anything from > physical in the CPU, use directly the constants in helper_fld*_ST0(). Actually I rather suspect there is effectively a table in the CPU indexed by the last 3 bits of the FLD* opcode... It would be possible to implement this group of insns in QEMU with a single helper function that took the index into the array, but since the array seems to be causing weird compilation problems we might as well stick with the lots-of-helpers approach, at which point this is a sensible cleanup. Reviewed-by: Peter Maydell