From: Alexey Charkov <alchark@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 27/29] vt8500lcdfb: use display information in info not in
Date: Thu, 26 May 2011 03:54:26 +0000 [thread overview]
Message-ID: <BANLkTin6YzLUu=pjSigbH+bwMuXjcwX=dQ@mail.gmail.com> (raw)
In-Reply-To: <1306364301-8195-28-git-send-email-laurent.pinchart@ideasonboard.com>
2011/5/26 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> We must not use any information in the passed var besides xoffset,
> yoffset and vmode as otherwise applications might abuse it.
Agreed, thanks for the fix!
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Alexey Charkov <alchark@gmail.com>
> ---
> drivers/video/vt8500lcdfb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> index 0e120d6..c13c246 100644
> --- a/drivers/video/vt8500lcdfb.c
> +++ b/drivers/video/vt8500lcdfb.c
> @@ -210,8 +210,8 @@ static int vt8500lcd_pan_display(struct fb_var_screeninfo *var,
> struct vt8500lcd_info *fbi = to_vt8500lcd_info(info);
>
> writel((1 << 31)
> - | (((var->xres_virtual - var->xres) * pixlen / 4) << 20)
> - | (off >> 2), fbi->regbase + 0x20);
> + | (((info->var.xres_virtual - info->var.xres) * pixlen / 4) << 20)
> + | (off >> 2), fbi->regbase + 0x20);
> return 0;
> }
>
> --
> 1.7.3.4
>
>
Best regards,
Alexey
prev parent reply other threads:[~2011-05-26 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 22:58 [PATCH 27/29] vt8500lcdfb: use display information in info not in var for panning Laurent Pinchart
2011-05-26 3:54 ` Alexey Charkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTin6YzLUu=pjSigbH+bwMuXjcwX=dQ@mail.gmail.com' \
--to=alchark@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.