Re: [meta-oe][PATCH] conf/layer.conf: Use .= for BBPATH and += for BBFILES

[Khem Raj <raj.khem@gmail.com>]

On Fri, May 6, 2011 at 11:49 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 07-05-11 01:09, Khem Raj wrote:
>> On Fri, May 6, 2011 at 2:25 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> On 06-05-11 21:59, Khem Raj wrote:
>>>>> On Fri, May 6, 2011 at 12:29 AM, Phil Blundell <philb@gnu.org> wrote:
>>>>>> On Thu, 2011-05-05 at 20:47 -0700, raj.khem@gmail.com wrote:
>>>>>>>  # We have a conf and classes directory, prepend to BBPATH to prefer our versions
>>>>>>> -BBPATH := "${LAYERDIR}:${BBPATH}"
>>>>>>> +BBPATH .= ":${LAYERDIR}"
>>>>>>
>>>>>> This patch seems to cause the code to do the opposite of what the
>>>>>> comment says.  If changing it to be an append rather than a prepend is
>>>>>> deliberate, please adjust the comment to match.  (It would also be nice
>>>>>> to have some commentary in the commit message explaining why this is
>>>>>> being done, since it isn't obvious to me why append would be better.)
>>>>>>
>>>>> That comment should be fixed. Since previously I has prepend and then
>>>>> changed it to append but forgot
>>>>> to correct the comment.
>>>>> It needed to follow some order for consistency and I chose append. Now
>>>>> it depends on the order of
>>>>> layers specified in BBLAYERS from bblayer.conf. Which means 1st entry
>>>>> gets priority
>>>>> over second entry when bitbake searches BBPATH. Right now there are
>>>>> two criteria's
>>>>> BBFILES are selected per priority set by BBFILES_PRIORITY for the
>>>>> layer but BBPATHs dont have this
>>>>> capability they get searched as they appear in the list.  Ideally I
>>>>> would think it would be simpler to have just one order for BBFILES and
>>>>> BBPATH
>>>>> so if BBPATHS followed the BBFILES priority too would make it easier
>>>>> to comprehend.
>>
>> For meta-oe we need 2 different things:
>>
>> 1) prepend to BBPATH to get our classes in first (e.g. kernel.bbclass,
>> gnome.bbclass)
>> 2) append to BBFILES to use our version of recipes (.bbs) and overrides
>> (.bbappends)
>>
>> It seems that using layer priorities won't work the way we need it.
>>
>>> we can change the order in BBLAYERS define in oebb.sh to achieve that
>>> so higest priority layer in terms of BBPATH appears first and so on
>
> That only fixes BBPATH, but not BBFILES :(

BBFILES order does not matter its the BBFILES_PRIORITY that matters
when it comes to bitbake preferring recipes in contention
but some classes like metadata_scm.bbclass expects oe-core's entries
to appear first in the BBFILES list we can make that in oe-core
such that it prepends using =+ or even manually.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD4DBQFNxOuGMkyGM64RGpERArpFAJ9HNwWB8IfyttZh46IZCo37unkcwACXQnZi
> SCM+PoZfIwKgplELJyZD/A==
> =2TIM
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>