From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368Ab1E2SoI (ORCPT ); Sun, 29 May 2011 14:44:08 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42093 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085Ab1E2SoG (ORCPT ); Sun, 29 May 2011 14:44:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <20110529072256.GA20983@elte.hu> From: Linus Torvalds Date: Sun, 29 May 2011 11:43:23 -0700 Message-ID: Subject: Re: [PATCH] mm: Fix boot crash in mm_alloc() To: Ingo Molnar Cc: Andrew Morton , Thomas Gleixner , KOSAKI Motohiro , linux-kernel@vger.kernel.org, Peter Zijlstra , linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 29, 2011 at 10:19 AM, Linus Torvalds wrote: > > STILL TOTALLY UNTESTED! The fixes were just from eyeballing it a bit > more, not from any actual testing. Ok, I eyeballed it some more, and tested both the OFFSTACK and ONSTACK case, and decided that I had better commit it now rather than wait any later since I'll do the -rc1 later today, and will be on an airplane most of tomorrow. The exact placement of the cpu_vm_mask_var is up for grabs. For example, I started thinking that it might be better to put it *after* the mm_context_t, since for the non-OFFSTACK case it's generally touched at the beginning rather than the end. And the actual change to make the mm_cachep kmem_cache_create() use a variable-sized allocation for the OFFSTACK case is similarly left as an exercise for the the reader. So effectively, this reverts a lot of de03c72cfce5, but does so in a way that should make very it easy to get back to where KOSAKI was aiming for. Whatever. I was hoping to get comments on it, but I think I need to rather push it out to get tested and public than wait any longer. The patch *looks* fine, tests ok on my machine, and removes more lines than it adds despite the new big comment. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 4492B6B0012 for ; Sun, 29 May 2011 14:44:05 -0400 (EDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (authenticated bits=0) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p4TIhhJ3032623 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL) for ; Sun, 29 May 2011 11:43:44 -0700 Received: by wwi36 with SMTP id 36so2771054wwi.26 for ; Sun, 29 May 2011 11:43:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20110529072256.GA20983@elte.hu> From: Linus Torvalds Date: Sun, 29 May 2011 11:43:23 -0700 Message-ID: Subject: Re: [PATCH] mm: Fix boot crash in mm_alloc() Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Andrew Morton , Thomas Gleixner , KOSAKI Motohiro , linux-kernel@vger.kernel.org, Peter Zijlstra , linux-mm@kvack.org On Sun, May 29, 2011 at 10:19 AM, Linus Torvalds wrote: > > STILL TOTALLY UNTESTED! The fixes were just from eyeballing it a bit > more, not from any actual testing. Ok, I eyeballed it some more, and tested both the OFFSTACK and ONSTACK case, and decided that I had better commit it now rather than wait any later since I'll do the -rc1 later today, and will be on an airplane most of tomorrow. The exact placement of the cpu_vm_mask_var is up for grabs. For example, I started thinking that it might be better to put it *after* the mm_context_t, since for the non-OFFSTACK case it's generally touched at the beginning rather than the end. And the actual change to make the mm_cachep kmem_cache_create() use a variable-sized allocation for the OFFSTACK case is similarly left as an exercise for the the reader. So effectively, this reverts a lot of de03c72cfce5, but does so in a way that should make very it easy to get back to where KOSAKI was aiming for. Whatever. I was hoping to get comments on it, but I think I need to rather push it out to get tested and public than wait any longer. The patch *looks* fine, tests ok on my machine, and removes more lines than it adds despite the new big comment. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org