From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mohammed Shafi Date: Thu, 16 Jun 2011 09:48:21 +0530 Subject: [ath9k-devel] ath9k causes lockups since kernel 2.6.35 In-Reply-To: <20110615174451.15903ae4@toddler> References: <20110224182022.57e32862@toddler> <20110224200203.GB17412@elie> <20110610134310.4591668e@toddler> <20110610194747.26e0e87a@toddler> <20110615174451.15903ae4@toddler> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Wed, Jun 15, 2011 at 10:14 PM, Tony Houghton wrote: > On Tue, 14 Jun 2011 18:50:24 +0530 > Mohammed Shafi wrote: > >> I had removed a check that looks redundant. this will be anyway called >> in radio_disable. >> ?if some one has time and has easy way of applying the patch like in >> compat wireless, can they see if it fixes by any chance(less >> probably). >> FYI I had gone through the pcipowersave module itself and did not find >> any obvious deviation apart from some junk work around that need to be >> done for AR9285E which does not seems to be related to this >> >> diff --git a/drivers/net/wireless/ath/ath9k/main.c >> b/drivers/net/wireless/ath/ath9k/main.c >> index 7f94533..e7f8ef2 100644 >> --- a/drivers/net/wireless/ath/ath9k/main.c >> +++ b/drivers/net/wireless/ath/ath9k/main.c >> @@ -1259,7 +1259,6 @@ static void ath9k_stop(struct ieee80211_hw *hw) >> >> ? ? ? ? /* disable HAL and put h/w to sleep */ >> ? ? ? ? ath9k_hw_disable(ah); >> - ? ? ? ath9k_hw_configpcipowersave(ah, 1, 1); >> >> ? ? ? ? spin_unlock_bh(&sc->sc_pcu_lock); > > This does seem to work for me (with compat-wireless 2011-06-14). Better > wait for the other affected people to confirm before committing the fix > though. thats surprising because that just removes a redundant call, please check if you don't have Adrian's work around and also if it works without this patch itself :-) may be you can do some stress test to confirm if you have time > -- shafi