Re: [RFC/PATCH 03/13] net: wl12xx: remove some unnecessary prints

From: Eliad Peller <eliad@wizery.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Luciano Coelho <coelho@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC/PATCH 03/13] net: wl12xx: remove some unnecessary prints
Date: Sun, 22 May 2011 15:34:33 +0300	[thread overview]
Message-ID: <BANLkTinPipSVdsH5cTb24HKex_h7pOwpAg@mail.gmail.com> (raw)
In-Reply-To: <1305321990-22041-4-git-send-email-balbi@ti.com>

On Sat, May 14, 2011 at 12:26 AM, Felipe Balbi <balbi@ti.com> wrote:
> Those have little value. Remove those to make
> the driver less noisy.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
[...]
> @@ -287,8 +287,6 @@ static int __devinit wl1271_probe(struct sdio_func *func,
>        /* Tell PM core that we don't need the card to be powered now */
>        pm_runtime_put_noidle(&func->dev);
>
> -       wl1271_notice("initialized");
> -
>        return 0;
>

>  static void __exit wl1271_exit(void)
>  {
>        sdio_unregister_driver(&wl1271_sdio_driver);
> -
> -       wl1271_notice("unloaded");
>  }
>

in fact, i find these prints pretty useful.
does changing wl1271_notice to wl1271_debug(DEBUG_MAC80211) will solve
the "nosiness"?
(i use DEBUG_MAC80211 rather than DEBUG_SDIO, as DEBUG_SDIO is really
*very* noisy)

(i'll send it as a new patch as the original patch was already applied)

Eliad.