From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qc1YC-0006nl-Vu
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:39:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qc1YB-0001nH-FS
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:39:56 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:44665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qc1YA-0001n2-Ow
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:39:55 -0400
Received: by pzk30 with SMTP id 30so1361509pzk.4
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 13:39:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110629200711.GA32548@laped.lan>
References: <1309373591-30380-1-git-send-email-peter.maydell@linaro.org>
	<1309373591-30380-3-git-send-email-peter.maydell@linaro.org>
	<20110629200711.GA32548@laped.lan>
Date: Wed, 29 Jun 2011 21:39:52 +0100
Message-ID: <BANLkTinYrJjx-yGNuesCd4xw47vXx-v_ew@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about
 some writes to r/o registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Riku Voipio <riku.voipio@iki.fi>, =?UTF-8?Q?Juha_Riihim=C3=A4ki?= <juha.riihimaki@nokia.com>, qemu-devel@nongnu.org, patches@linaro.org

On 29 June 2011 21:07, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> On Wed, Jun 29, 2011 at 07:53:10PM +0100, Peter Maydell wrote:
>> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
>> kernel will do them anyway.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Hi Peter,
>
> I usually find this kind of logs useful.
> Maybe we should turn them into _log_mask(~0, xxx) so they only come out
> when -d is enabled?

I think the ideal would be to have all of this kind of message go
through some consistent path (ie not just printf) so you could
tell all of qemu "I'm doing OS development, warn about things which
indicate driver bugs" vs the more common "I'm just a user and I
don't really care".

You'd also want to be able to trace the guest program counter
and to do things like drop into gdb if running with the gdb stub
enabled.

In the absence of that kind of infrastructure I tend to default
to removing this kind of printf or relegating it to DPRINTF.

-- PMM