From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Thu, 30 Jun 2011 13:09:48 +0200 Subject: [U-Boot] [RFC PATCH 1/7] Adapt config.mk for usage in spl/Makefile In-Reply-To: <4E0C05B9.4070702@ti.com> References: <1309352967-5719-2-git-send-email-aneesh@ti.com> <201106291452.58967.vapier@gentoo.org> <4E0C05B9.4070702@ti.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Aneesh, On Thu, Jun 30, 2011 at 7:12 AM, Aneesh V wrote: > On Thursday 30 June 2011 12:22 AM, Mike Frysinger wrote: >> >> On Wednesday, June 29, 2011 09:09:21 Aneesh V wrote: >>> >>> -$(obj)%.s: ? ? %.S >>> +$(obj)%.s: ? ? $(src)%.S > > I too didn't understand why that was done. But I noticed it just before > sending the patches so decided to give it a try later. I tried removing > them now and it doesn't harm. Maybe, some of the changes I did to the > definition of OBJTREE obj etc would have rendered it irrelevant? > > Daniel, > Can you throw some light on this? > In my original patch I tweaked the src and obj variables to use spl as remote build directory. As a consequence I had to change the implicite make rules too. The regular way is: src = $(TOPDIR)/arch/ARCH/cpu/CPU/start.S obj = $(TOPDIR)/arch/ARCH/cpu/CPU/start.o (in-tree builds) obj = $(BUILDDIR)/arch/ARCH/cpu/CPU/start.o (out-of-tree builds) with spl as build directory: src = $(TOPDIR)/arch/ARCH/cpu/CPU/start.S obj = $(TOPDIR)/spl/arch/ARCH/cpu/CPU/start.o (in-tree builds) obj = $(BUILDDIR)/spl/arch/ARCH/cpu/CPU/start.o (out-of-tree builds) in the latter case I saw that $(src) got the value $(TOPDIR)/spl/arch/ARCH/cpu/CPU/start.S and the implicite make rules did not work anymore. I'am glad if this works without those changes. I'll try this for my boards too. Best regards, Daniel