All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] compat: add a getpass() compatibility function
@ 2011-05-19 11:37 Rafael Gieschke
  2011-05-19 12:17 ` Erik Faye-Lund
  2011-05-19 12:21 ` Erik Faye-Lund
  0 siblings, 2 replies; 19+ messages in thread
From: Rafael Gieschke @ 2011-05-19 11:37 UTC (permalink / raw)
  To: git, Junio C Hamano


If NO_GETPASS is set, getpass is provided in compat/getpass.c from
https://github.com/CyanogenMod/android_external_dropbear/raw/master/netbsd_getpass.c
(getpass was renamed to gitgetpass).

Signed-off-by: Rafael Gieschke <rafael@gieschke.de>
---
 Makefile          |    6 +++
 compat/getpass.c  |  114 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 git-compat-util.h |    5 ++
 3 files changed, 125 insertions(+), 0 deletions(-)
 create mode 100644 compat/getpass.c

diff --git a/Makefile b/Makefile
index d7147cf..e171fcd 100644
--- a/Makefile
+++ b/Makefile
@@ -71,6 +71,8 @@ all::
 #
 # Define NO_STRTOK_R if you don't have strtok_r in the C library.
 #
+# Define NO_GETPASS if you don't have getpass in the C library.
+#
 # Define NO_FNMATCH if you don't have fnmatch in the C library.
 #
 # Define NO_FNMATCH_CASEFOLD if your fnmatch function doesn't have the
@@ -1406,6 +1408,10 @@ ifdef NO_STRTOK_R
 	COMPAT_CFLAGS += -DNO_STRTOK_R
 	COMPAT_OBJS += compat/strtok_r.o
 endif
+ifdef NO_GETPASS
+	COMPAT_CFLAGS += -DNO_GETPASS
+	COMPAT_OBJS += compat/getpass.o
+endif
 ifdef NO_FNMATCH
 	COMPAT_CFLAGS += -Icompat/fnmatch
 	COMPAT_CFLAGS += -DNO_FNMATCH
diff --git a/compat/getpass.c b/compat/getpass.c
new file mode 100644
index 0000000..e13f29f
--- /dev/null
+++ b/compat/getpass.c
@@ -0,0 +1,114 @@
+/*	$NetBSD: getpass.c,v 1.15 2003/08/07 16:42:50 agc Exp $	*/
+
+/*
+ * Copyright (c) 1988, 1993
+ *	The Regents of the University of California.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. Neither the name of the University nor the names of its contributors
+ *    may be used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+
+#if 0
+#include <sys/cdefs.h>
+#if defined(LIBC_SCCS) && !defined(lint)
+#if 0
+static char sccsid[] = "@(#)getpass.c	8.1 (Berkeley) 6/4/93";
+#else
+__RCSID("$NetBSD: getpass.c,v 1.15 2003/08/07 16:42:50 agc Exp $");
+#endif
+#endif /* LIBC_SCCS and not lint */
+
+#include "namespace.h"
+#endif
+
+#include <assert.h>
+#include <paths.h>
+#include <pwd.h>
+#include <signal.h>
+#include <stdio.h>
+#include <termios.h>
+#include <unistd.h>
+
+#if 0
+#ifdef __weak_alias
+__weak_alias(getpass,_getpass)
+#endif
+#endif
+
+char *
+gitgetpass(prompt)
+	const char *prompt;
+{
+	struct termios term;
+	int ch;
+	char *p;
+	FILE *fp, *outfp;
+	int echo;
+	static char buf[_PASSWORD_LEN + 1];
+	sigset_t oset, nset;
+
+#if 0
+	_DIAGASSERT(prompt != NULL);
+#endif
+
+	/*
+	 * read and write to /dev/tty if possible; else read from
+	 * stdin and write to stderr.
+	 */
+	if ((outfp = fp = fopen(_PATH_TTY, "w+")) == NULL) {
+		outfp = stderr;
+		fp = stdin;
+	}
+
+	/*
+	 * note - blocking signals isn't necessarily the
+	 * right thing, but we leave it for now.
+	 */
+	sigemptyset(&nset);
+	sigaddset(&nset, SIGINT);
+	sigaddset(&nset, SIGTSTP);
+	(void)sigprocmask(SIG_BLOCK, &nset, &oset);
+
+	(void)tcgetattr(fileno(fp), &term);
+	if ((echo = (term.c_lflag & ECHO)) != 0) {
+		term.c_lflag &= ~ECHO;
+		(void)tcsetattr(fileno(fp), TCSAFLUSH /*|TCSASOFT*/, &term);
+	}
+	if (prompt != NULL)
+		(void)fputs(prompt, outfp);
+	rewind(outfp);			/* implied flush */
+	for (p = buf; (ch = getc(fp)) != EOF && ch != '\n';)
+		if (p < buf + _PASSWORD_LEN)
+			*p++ = ch;
+	*p = '\0';
+	(void)write(fileno(outfp), "\n", 1);
+	if (echo) {
+		term.c_lflag |= ECHO;
+		(void)tcsetattr(fileno(fp), TCSAFLUSH/*|TCSASOFT*/, &term);
+	}
+	(void)sigprocmask(SIG_SETMASK, &oset, NULL);
+	if (fp != stdin)
+		(void)fclose(fp);
+	return(buf);
+}
diff --git a/git-compat-util.h b/git-compat-util.h
index e0bb81e..2ea5ac9 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -352,6 +352,11 @@ extern uintmax_t gitstrtoumax(const char *, char **, int);
 extern char *gitstrtok_r(char *s, const char *delim, char **save_ptr);
 #endif
 
+#ifdef NO_GETPASS
+#define getpass gitgetpass
+extern char *gitgetpass(const char *prompt);
+#endif
+
 #ifdef NO_HSTRERROR
 #define hstrerror githstrerror
 extern const char *githstrerror(int herror);
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 11:37 [PATCH] compat: add a getpass() compatibility function Rafael Gieschke
@ 2011-05-19 12:17 ` Erik Faye-Lund
  2011-05-19 16:30   ` Junio C Hamano
  2011-05-19 17:01   ` Rafael Gieschke
  2011-05-19 12:21 ` Erik Faye-Lund
  1 sibling, 2 replies; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 12:17 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: git, Junio C Hamano

On Thu, May 19, 2011 at 1:37 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>
> If NO_GETPASS is set, getpass is provided in compat/getpass.c from
> https://github.com/CyanogenMod/android_external_dropbear/raw/master/netbsd_getpass.c
> (getpass was renamed to gitgetpass).

Nice.

But I can't help to think that this implementation of getpass looks a
bit heavy, especially since we already have our own getpass
implementation in compat/mingw.c.

Do we really need two implementations? Wouldn't it be better to factor
out the mingw-version to a separate source file, and then improve it?

Windows doesn't have /dev/tty, but the logic in this version handles
that by using stdin/stderr instead. The signal-stuff has a comment
that indicates it might not even be correct. tcgetattr/tcsetattr isn't
supported on Windows, but it's not needed if we use getch (as the
version in compat/mingw.c does). POSIX/curses getch respects the
echo-setting, while Windows getch never echo.

Given the information above, it sounds to me like we can enhance the
version we already have to behave as it should also on non-Windows
platforms, without having to maintain two versions. But it might not
be worth it, given the simplicity of the Windows version and the
increased dependency of curses, I dunno.

As a Windows-guy, I'm not entirely comfortable with putting something
in compat/[function-name].c that is only portable to POSIX-platforms.
This is not the current trend, but that might not be a conscious
choice.

> diff --git a/compat/getpass.c b/compat/getpass.c
> new file mode 100644
> index 0000000..e13f29f
> --- /dev/null
> +++ b/compat/getpass.c
> @@ -0,0 +1,114 @@
> +/*     $NetBSD: getpass.c,v 1.15 2003/08/07 16:42:50 agc Exp $ */
> +
> +/*
> + * Copyright (c) 1988, 1993
> + *     The Regents of the University of California.  All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of the University nor the names of its contributors
> + *    may be used to endorse or promote products derived from this software
> + *    without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + * SUCH DAMAGE.
> + */
> +
> +#if 0
> +#include <sys/cdefs.h>
> +#if defined(LIBC_SCCS) && !defined(lint)
> +#if 0
> +static char sccsid[] = "@(#)getpass.c  8.1 (Berkeley) 6/4/93";
> +#else
> +__RCSID("$NetBSD: getpass.c,v 1.15 2003/08/07 16:42:50 agc Exp $");
> +#endif
> +#endif /* LIBC_SCCS and not lint */

We usually don't keep dead code around. Since you've already edited
the file, perhaps you should just delete those lines?

> +
> +#if 0
> +#ifdef __weak_alias
> +__weak_alias(getpass,_getpass)
> +#endif
> +#endif


Same here.

> +
> +char *
> +gitgetpass(prompt)
> +       const char *prompt;
> +{
> +       struct termios term;
> +       int ch;
> +       char *p;
> +       FILE *fp, *outfp;
> +       int echo;
> +       static char buf[_PASSWORD_LEN + 1];

Is _PASSWORD_LEN portable? A google search of "site:opengroup.org
_PASSWORD_LEN " returns nothing...

The getpass implementation in compat/mingw.c uses a strbuf, so it
doesn't have a limit on the password-length. Perhaps that would be an
improvement here?

> +       sigset_t oset, nset;
> +
> +#if 0
> +       _DIAGASSERT(prompt != NULL);
> +#endif

Again, dead code.

> +
> +       /*
> +        * read and write to /dev/tty if possible; else read from
> +        * stdin and write to stderr.
> +        */
> +       if ((outfp = fp = fopen(_PATH_TTY, "w+")) == NULL) {

Is _PATH_TTY portable? A google search of "site:opengroup.org
_PATH_TTY" returns nothing...

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 11:37 [PATCH] compat: add a getpass() compatibility function Rafael Gieschke
  2011-05-19 12:17 ` Erik Faye-Lund
@ 2011-05-19 12:21 ` Erik Faye-Lund
  2011-05-19 15:14   ` Jonathan Nieder
  1 sibling, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 12:21 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: git, Junio C Hamano

On Thu, May 19, 2011 at 1:37 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
> diff --git a/compat/getpass.c b/compat/getpass.c
> new file mode 100644
> index 0000000..e13f29f
> --- /dev/null
> +++ b/compat/getpass.c
> @@ -0,0 +1,114 @@
> +/*     $NetBSD: getpass.c,v 1.15 2003/08/07 16:42:50 agc Exp $ */
> +
> +/*
> + * Copyright (c) 1988, 1993
> + *     The Regents of the University of California.  All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.

How do we plan to adhere to this clause? I guess all
package-maintainers could explicitly add this to their release notes /
documentation, but they will have to know that they should. I don't
think every package maintainer read every patch in-depth enough to
notice this.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 12:21 ` Erik Faye-Lund
@ 2011-05-19 15:14   ` Jonathan Nieder
  2011-05-19 15:29     ` Erik Faye-Lund
  2011-05-19 17:17     ` Junio C Hamano
  0 siblings, 2 replies; 19+ messages in thread
From: Jonathan Nieder @ 2011-05-19 15:14 UTC (permalink / raw)
  To: Erik Faye-Lund; +Cc: Rafael Gieschke, git, Junio C Hamano

Erik Faye-Lund wrote:
> On Thu, May 19, 2011 at 1:37 PM, Rafael Gieschke <rafael@gieschke.de> wrote:

>> + * 2. Redistributions in binary form must reproduce the above copyright
>> + *    notice, this list of conditions and the following disclaimer in the
>> + *    documentation and/or other materials provided with the distribution.
>
> How do we plan to adhere to this clause? I guess all
> package-maintainers could explicitly add this to their release notes /
> documentation, but they will have to know that they should. I don't
> think every package maintainer read every patch in-depth enough to
> notice this.

The vcs-svn/ directory is also under a two-clause BSD-style license
for what it's worth.  To give a vague summary of requirements from
different parts of the code base[1]:

 . COPYING requires a copy of the GPLv2 to be distributed along with
   the binaries and for the corresponding source code to be accessible
   from the same place (or a written offer under some circumstances,
   etc)

 . xdiff's license requires a copy of the LGPL (version 2.1 or later)
   to be distributed along with the binaries, unless your copy of the
   license notice is altered to refer to the GPL.  Likewise for
   compat/fnmatch, compat/regex, and compat/strtok_r.c.

 . vcs-svn/LICENSE the license to be distributed along with any
   binaries.  Likewise for compat/inet_ntop.c, compat/inet_pton.c,
   compat/nedmalloc/*, and contrib/fast-import/git-p4.

Maybe we should provide a file NOTICES with all the required notices?
I admit I'm happier sticking to the line "Please grep for
'[Cc]opyright' for detailed distribution terms.  If you ship the
corresponding source code with your binaries, you're probably in the
clear."  I suppose based on a strict reading we ought to have a copy
of the LPGL 2.1 in the source tree, though...  Maybe something like
this can help.

-- >8 --
Subject: provide a copy of the LGPLv2.1

The LGPL seems to require providing a copy of the license when
distributing xdiff, compat/fnmatch, and so on, or altering the license
notices to refer to the GPL intead.  Since we don't want to do the
latter, let's do the former.  It's nice to let people know their
rights anyway.

Inspired-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
[1] http://packages.debian.org/changelogs/pool/main/g/git/current/copyright

 LGPL-2.1 |  511 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 511 insertions(+), 0 deletions(-)
 create mode 100644 LGPL-2.1

diff --git a/LGPL-2.1 b/LGPL-2.1
new file mode 100644
index 0000000..d38b1b9
--- /dev/null
+++ b/LGPL-2.1
@@ -0,0 +1,511 @@
+
+ While most of this project is under the GPL (see COPYING), the xdiff/
+ library and some libc code from compat/ are licensed under the
+ GNU LGPL, version 2.1 or (at your option) any later version and some
+ other files are under other licenses.  Check the individual files to
+ be sure.
+
+----------------------------------------
+
+                  GNU LESSER GENERAL PUBLIC LICENSE
+                       Version 2.1, February 1999
+
+ Copyright (C) 1991, 1999 Free Software Foundation, Inc.
+ 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+[This is the first released version of the Lesser GPL.  It also counts
+ as the successor of the GNU Library Public License, version 2, hence
+ the version number 2.1.]
+
+                            Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+Licenses are intended to guarantee your freedom to share and change
+free software--to make sure the software is free for all its users.
+
+  This license, the Lesser General Public License, applies to some
+specially designated software packages--typically libraries--of the
+Free Software Foundation and other authors who decide to use it.  You
+can use it too, but we suggest you first think carefully about whether
+this license or the ordinary General Public License is the better
+strategy to use in any particular case, based on the explanations below.
+
+  When we speak of free software, we are referring to freedom of use,
+not price.  Our General Public Licenses are designed to make sure that
+you have the freedom to distribute copies of free software (and charge
+for this service if you wish); that you receive source code or can get
+it if you want it; that you can change the software and use pieces of
+it in new free programs; and that you are informed that you can do
+these things.
+
+  To protect your rights, we need to make restrictions that forbid
+distributors to deny you these rights or to ask you to surrender these
+rights.  These restrictions translate to certain responsibilities for
+you if you distribute copies of the library or if you modify it.
+
+  For example, if you distribute copies of the library, whether gratis
+or for a fee, you must give the recipients all the rights that we gave
+you.  You must make sure that they, too, receive or can get the source
+code.  If you link other code with the library, you must provide
+complete object files to the recipients, so that they can relink them
+with the library after making changes to the library and recompiling
+it.  And you must show them these terms so they know their rights.
+
+  We protect your rights with a two-step method: (1) we copyright the
+library, and (2) we offer you this license, which gives you legal
+permission to copy, distribute and/or modify the library.
+
+  To protect each distributor, we want to make it very clear that
+there is no warranty for the free library.  Also, if the library is
+modified by someone else and passed on, the recipients should know
+that what they have is not the original version, so that the original
+author's reputation will not be affected by problems that might be
+introduced by others.
+\f
+  Finally, software patents pose a constant threat to the existence of
+any free program.  We wish to make sure that a company cannot
+effectively restrict the users of a free program by obtaining a
+restrictive license from a patent holder.  Therefore, we insist that
+any patent license obtained for a version of the library must be
+consistent with the full freedom of use specified in this license.
+
+  Most GNU software, including some libraries, is covered by the
+ordinary GNU General Public License.  This license, the GNU Lesser
+General Public License, applies to certain designated libraries, and
+is quite different from the ordinary General Public License.  We use
+this license for certain libraries in order to permit linking those
+libraries into non-free programs.
+
+  When a program is linked with a library, whether statically or using
+a shared library, the combination of the two is legally speaking a
+combined work, a derivative of the original library.  The ordinary
+General Public License therefore permits such linking only if the
+entire combination fits its criteria of freedom.  The Lesser General
+Public License permits more lax criteria for linking other code with
+the library.
+
+  We call this license the "Lesser" General Public License because it
+does Less to protect the user's freedom than the ordinary General
+Public License.  It also provides other free software developers Less
+of an advantage over competing non-free programs.  These disadvantages
+are the reason we use the ordinary General Public License for many
+libraries.  However, the Lesser license provides advantages in certain
+special circumstances.
+
+  For example, on rare occasions, there may be a special need to
+encourage the widest possible use of a certain library, so that it becomes
+a de-facto standard.  To achieve this, non-free programs must be
+allowed to use the library.  A more frequent case is that a free
+library does the same job as widely used non-free libraries.  In this
+case, there is little to gain by limiting the free library to free
+software only, so we use the Lesser General Public License.
+
+  In other cases, permission to use a particular library in non-free
+programs enables a greater number of people to use a large body of
+free software.  For example, permission to use the GNU C Library in
+non-free programs enables many more people to use the whole GNU
+operating system, as well as its variant, the GNU/Linux operating
+system.
+
+  Although the Lesser General Public License is Less protective of the
+users' freedom, it does ensure that the user of a program that is
+linked with the Library has the freedom and the wherewithal to run
+that program using a modified version of the Library.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.  Pay close attention to the difference between a
+"work based on the library" and a "work that uses the library".  The
+former contains code derived from the library, whereas the latter must
+be combined with the library in order to run.
+\f
+                  GNU LESSER GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License Agreement applies to any software library or other
+program which contains a notice placed by the copyright holder or
+other authorized party saying it may be distributed under the terms of
+this Lesser General Public License (also called "this License").
+Each licensee is addressed as "you".
+
+  A "library" means a collection of software functions and/or data
+prepared so as to be conveniently linked with application programs
+(which use some of those functions and data) to form executables.
+
+  The "Library", below, refers to any such software library or work
+which has been distributed under these terms.  A "work based on the
+Library" means either the Library or any derivative work under
+copyright law: that is to say, a work containing the Library or a
+portion of it, either verbatim or with modifications and/or translated
+straightforwardly into another language.  (Hereinafter, translation is
+included without limitation in the term "modification".)
+
+  "Source code" for a work means the preferred form of the work for
+making modifications to it.  For a library, complete source code means
+all the source code for all modules it contains, plus any associated
+interface definition files, plus the scripts used to control compilation
+and installation of the library.
+
+  Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running a program using the Library is not restricted, and output from
+such a program is covered only if its contents constitute a work based
+on the Library (independent of the use of the Library in a tool for
+writing it).  Whether that is true depends on what the Library does
+and what the program that uses the Library does.
+
+  1. You may copy and distribute verbatim copies of the Library's
+complete source code as you receive it, in any medium, provided that
+you conspicuously and appropriately publish on each copy an
+appropriate copyright notice and disclaimer of warranty; keep intact
+all the notices that refer to this License and to the absence of any
+warranty; and distribute a copy of this License along with the
+Library.
+
+  You may charge a fee for the physical act of transferring a copy,
+and you may at your option offer warranty protection in exchange for a
+fee.
+\f
+  2. You may modify your copy or copies of the Library or any portion
+of it, thus forming a work based on the Library, and copy and
+distribute such modifications or work under the terms of Section 1
+above, provided that you also meet all of these conditions:
+
+    a) The modified work must itself be a software library.
+
+    b) You must cause the files modified to carry prominent notices
+    stating that you changed the files and the date of any change.
+
+    c) You must cause the whole of the work to be licensed at no
+    charge to all third parties under the terms of this License.
+
+    d) If a facility in the modified Library refers to a function or a
+    table of data to be supplied by an application program that uses
+    the facility, other than as an argument passed when the facility
+    is invoked, then you must make a good faith effort to ensure that,
+    in the event an application does not supply such function or
+    table, the facility still operates, and performs whatever part of
+    its purpose remains meaningful.
+
+    (For example, a function in a library to compute square roots has
+    a purpose that is entirely well-defined independent of the
+    application.  Therefore, Subsection 2d requires that any
+    application-supplied function or table used by this function must
+    be optional: if the application does not supply it, the square
+    root function must still compute square roots.)
+
+These requirements apply to the modified work as a whole.  If
+identifiable sections of that work are not derived from the Library,
+and can be reasonably considered independent and separate works in
+themselves, then this License, and its terms, do not apply to those
+sections when you distribute them as separate works.  But when you
+distribute the same sections as part of a whole which is a work based
+on the Library, the distribution of the whole must be on the terms of
+this License, whose permissions for other licensees extend to the
+entire whole, and thus to each and every part regardless of who wrote
+it.
+
+Thus, it is not the intent of this section to claim rights or contest
+your rights to work written entirely by you; rather, the intent is to
+exercise the right to control the distribution of derivative or
+collective works based on the Library.
+
+In addition, mere aggregation of another work not based on the Library
+with the Library (or with a work based on the Library) on a volume of
+a storage or distribution medium does not bring the other work under
+the scope of this License.
+
+  3. You may opt to apply the terms of the ordinary GNU General Public
+License instead of this License to a given copy of the Library.  To do
+this, you must alter all the notices that refer to this License, so
+that they refer to the ordinary GNU General Public License, version 2,
+instead of to this License.  (If a newer version than version 2 of the
+ordinary GNU General Public License has appeared, then you can specify
+that version instead if you wish.)  Do not make any other change in
+these notices.
+\f
+  Once this change is made in a given copy, it is irreversible for
+that copy, so the ordinary GNU General Public License applies to all
+subsequent copies and derivative works made from that copy.
+
+  This option is useful when you wish to copy part of the code of
+the Library into a program that is not a library.
+
+  4. You may copy and distribute the Library (or a portion or
+derivative of it, under Section 2) in object code or executable form
+under the terms of Sections 1 and 2 above provided that you accompany
+it with the complete corresponding machine-readable source code, which
+must be distributed under the terms of Sections 1 and 2 above on a
+medium customarily used for software interchange.
+
+  If distribution of object code is made by offering access to copy
+from a designated place, then offering equivalent access to copy the
+source code from the same place satisfies the requirement to
+distribute the source code, even though third parties are not
+compelled to copy the source along with the object code.
+
+  5. A program that contains no derivative of any portion of the
+Library, but is designed to work with the Library by being compiled or
+linked with it, is called a "work that uses the Library".  Such a
+work, in isolation, is not a derivative work of the Library, and
+therefore falls outside the scope of this License.
+
+  However, linking a "work that uses the Library" with the Library
+creates an executable that is a derivative of the Library (because it
+contains portions of the Library), rather than a "work that uses the
+library".  The executable is therefore covered by this License.
+Section 6 states terms for distribution of such executables.
+
+  When a "work that uses the Library" uses material from a header file
+that is part of the Library, the object code for the work may be a
+derivative work of the Library even though the source code is not.
+Whether this is true is especially significant if the work can be
+linked without the Library, or if the work is itself a library.  The
+threshold for this to be true is not precisely defined by law.
+
+  If such an object file uses only numerical parameters, data
+structure layouts and accessors, and small macros and small inline
+functions (ten lines or less in length), then the use of the object
+file is unrestricted, regardless of whether it is legally a derivative
+work.  (Executables containing this object code plus portions of the
+Library will still fall under Section 6.)
+
+  Otherwise, if the work is a derivative of the Library, you may
+distribute the object code for the work under the terms of Section 6.
+Any executables containing that work also fall under Section 6,
+whether or not they are linked directly with the Library itself.
+\f
+  6. As an exception to the Sections above, you may also combine or
+link a "work that uses the Library" with the Library to produce a
+work containing portions of the Library, and distribute that work
+under terms of your choice, provided that the terms permit
+modification of the work for the customer's own use and reverse
+engineering for debugging such modifications.
+
+  You must give prominent notice with each copy of the work that the
+Library is used in it and that the Library and its use are covered by
+this License.  You must supply a copy of this License.  If the work
+during execution displays copyright notices, you must include the
+copyright notice for the Library among them, as well as a reference
+directing the user to the copy of this License.  Also, you must do one
+of these things:
+
+    a) Accompany the work with the complete corresponding
+    machine-readable source code for the Library including whatever
+    changes were used in the work (which must be distributed under
+    Sections 1 and 2 above); and, if the work is an executable linked
+    with the Library, with the complete machine-readable "work that
+    uses the Library", as object code and/or source code, so that the
+    user can modify the Library and then relink to produce a modified
+    executable containing the modified Library.  (It is understood
+    that the user who changes the contents of definitions files in the
+    Library will not necessarily be able to recompile the application
+    to use the modified definitions.)
+
+    b) Use a suitable shared library mechanism for linking with the
+    Library.  A suitable mechanism is one that (1) uses at run time a
+    copy of the library already present on the user's computer system,
+    rather than copying library functions into the executable, and (2)
+    will operate properly with a modified version of the library, if
+    the user installs one, as long as the modified version is
+    interface-compatible with the version that the work was made with.
+
+    c) Accompany the work with a written offer, valid for at
+    least three years, to give the same user the materials
+    specified in Subsection 6a, above, for a charge no more
+    than the cost of performing this distribution.
+
+    d) If distribution of the work is made by offering access to copy
+    from a designated place, offer equivalent access to copy the above
+    specified materials from the same place.
+
+    e) Verify that the user has already received a copy of these
+    materials or that you have already sent this user a copy.
+
+  For an executable, the required form of the "work that uses the
+Library" must include any data and utility programs needed for
+reproducing the executable from it.  However, as a special exception,
+the materials to be distributed need not include anything that is
+normally distributed (in either source or binary form) with the major
+components (compiler, kernel, and so on) of the operating system on
+which the executable runs, unless that component itself accompanies
+the executable.
+
+  It may happen that this requirement contradicts the license
+restrictions of other proprietary libraries that do not normally
+accompany the operating system.  Such a contradiction means you cannot
+use both them and the Library together in an executable that you
+distribute.
+\f
+  7. You may place library facilities that are a work based on the
+Library side-by-side in a single library together with other library
+facilities not covered by this License, and distribute such a combined
+library, provided that the separate distribution of the work based on
+the Library and of the other library facilities is otherwise
+permitted, and provided that you do these two things:
+
+    a) Accompany the combined library with a copy of the same work
+    based on the Library, uncombined with any other library
+    facilities.  This must be distributed under the terms of the
+    Sections above.
+
+    b) Give prominent notice with the combined library of the fact
+    that part of it is a work based on the Library, and explaining
+    where to find the accompanying uncombined form of the same work.
+
+  8. You may not copy, modify, sublicense, link with, or distribute
+the Library except as expressly provided under this License.  Any
+attempt otherwise to copy, modify, sublicense, link with, or
+distribute the Library is void, and will automatically terminate your
+rights under this License.  However, parties who have received copies,
+or rights, from you under this License will not have their licenses
+terminated so long as such parties remain in full compliance.
+
+  9. You are not required to accept this License, since you have not
+signed it.  However, nothing else grants you permission to modify or
+distribute the Library or its derivative works.  These actions are
+prohibited by law if you do not accept this License.  Therefore, by
+modifying or distributing the Library (or any work based on the
+Library), you indicate your acceptance of this License to do so, and
+all its terms and conditions for copying, distributing or modifying
+the Library or works based on it.
+
+  10. Each time you redistribute the Library (or any work based on the
+Library), the recipient automatically receives a license from the
+original licensor to copy, distribute, link with or modify the Library
+subject to these terms and conditions.  You may not impose any further
+restrictions on the recipients' exercise of the rights granted herein.
+You are not responsible for enforcing compliance by third parties with
+this License.
+\f
+  11. If, as a consequence of a court judgment or allegation of patent
+infringement or for any other reason (not limited to patent issues),
+conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot
+distribute so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you
+may not distribute the Library at all.  For example, if a patent
+license would not permit royalty-free redistribution of the Library by
+all those who receive copies directly or indirectly through you, then
+the only way you could satisfy both it and this License would be to
+refrain entirely from distribution of the Library.
+
+If any portion of this section is held invalid or unenforceable under any
+particular circumstance, the balance of the section is intended to apply,
+and the section as a whole is intended to apply in other circumstances.
+
+It is not the purpose of this section to induce you to infringe any
+patents or other property right claims or to contest validity of any
+such claims; this section has the sole purpose of protecting the
+integrity of the free software distribution system which is
+implemented by public license practices.  Many people have made
+generous contributions to the wide range of software distributed
+through that system in reliance on consistent application of that
+system; it is up to the author/donor to decide if he or she is willing
+to distribute software through any other system and a licensee cannot
+impose that choice.
+
+This section is intended to make thoroughly clear what is believed to
+be a consequence of the rest of this License.
+
+  12. If the distribution and/or use of the Library is restricted in
+certain countries either by patents or by copyrighted interfaces, the
+original copyright holder who places the Library under this License may add
+an explicit geographical distribution limitation excluding those countries,
+so that distribution is permitted only in or among countries not thus
+excluded.  In such case, this License incorporates the limitation as if
+written in the body of this License.
+
+  13. The Free Software Foundation may publish revised and/or new
+versions of the Lesser General Public License from time to time.
+Such new versions will be similar in spirit to the present version,
+but may differ in detail to address new problems or concerns.
+
+Each version is given a distinguishing version number.  If the Library
+specifies a version number of this License which applies to it and
+"any later version", you have the option of following the terms and
+conditions either of that version or of any later version published by
+the Free Software Foundation.  If the Library does not specify a
+license version number, you may choose any version ever published by
+the Free Software Foundation.
+\f
+  14. If you wish to incorporate parts of the Library into other free
+programs whose distribution conditions are incompatible with these,
+write to the author to ask for permission.  For software which is
+copyrighted by the Free Software Foundation, write to the Free
+Software Foundation; we sometimes make exceptions for this.  Our
+decision will be guided by the two goals of preserving the free status
+of all derivatives of our free software and of promoting the sharing
+and reuse of software generally.
+
+                            NO WARRANTY
+
+  15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO
+WARRANTY FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW.
+EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR
+OTHER PARTIES PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY
+KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE
+LIBRARY IS WITH YOU.  SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME
+THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+  16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN
+WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY
+AND/OR REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU
+FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR
+CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE
+LIBRARY (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING
+RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A
+FAILURE OF THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF
+SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
+DAMAGES.
+
+                     END OF TERMS AND CONDITIONS
+\f
+           How to Apply These Terms to Your New Libraries
+
+  If you develop a new library, and you want it to be of the greatest
+possible use to the public, we recommend making it free software that
+everyone can redistribute and change.  You can do so by permitting
+redistribution under these terms (or, alternatively, under the terms of the
+ordinary General Public License).
+
+  To apply these terms, attach the following notices to the library.  It is
+safest to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least the
+"copyright" line and a pointer to where the full notice is found.
+
+    <one line to give the library's name and a brief idea of what it does.>
+    Copyright (C) <year>  <name of author>
+
+    This library is free software; you can redistribute it and/or
+    modify it under the terms of the GNU Lesser General Public
+    License as published by the Free Software Foundation; either
+    version 2.1 of the License, or (at your option) any later version.
+
+    This library is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+    Lesser General Public License for more details.
+
+    You should have received a copy of the GNU Lesser General Public
+    License along with this library; if not, write to the Free Software
+    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+Also add information on how to contact you by electronic and paper mail.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the library, if
+necessary.  Here is a sample; alter the names:
+
+  Yoyodyne, Inc., hereby disclaims all copyright interest in the
+  library `Frob' (a library for tweaking knobs) written by James Random Hacker.
+
+  <signature of Ty Coon>, 1 April 1990
+  Ty Coon, President of Vice
+
+That's all there is to it!
-- 
1.7.5.1

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 15:14   ` Jonathan Nieder
@ 2011-05-19 15:29     ` Erik Faye-Lund
  2011-05-19 17:17     ` Junio C Hamano
  1 sibling, 0 replies; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 15:29 UTC (permalink / raw)
  To: Jonathan Nieder; +Cc: Rafael Gieschke, git, Junio C Hamano

On Thu, May 19, 2011 at 5:14 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Erik Faye-Lund wrote:
>> On Thu, May 19, 2011 at 1:37 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>
>>> + * 2. Redistributions in binary form must reproduce the above copyright
>>> + *    notice, this list of conditions and the following disclaimer in the
>>> + *    documentation and/or other materials provided with the distribution.
>>
>> How do we plan to adhere to this clause? I guess all
>> package-maintainers could explicitly add this to their release notes /
>> documentation, but they will have to know that they should. I don't
>> think every package maintainer read every patch in-depth enough to
>> notice this.
>
> The vcs-svn/ directory is also under a two-clause BSD-style license
> for what it's worth.  To give a vague summary of requirements from
> different parts of the code base[1]:
>
>  . COPYING requires a copy of the GPLv2 to be distributed along with
>   the binaries and for the corresponding source code to be accessible
>   from the same place (or a written offer under some circumstances,
>   etc)
>
>  . xdiff's license requires a copy of the LGPL (version 2.1 or later)
>   to be distributed along with the binaries, unless your copy of the
>   license notice is altered to refer to the GPL.  Likewise for
>   compat/fnmatch, compat/regex, and compat/strtok_r.c.
>
>  . vcs-svn/LICENSE the license to be distributed along with any
>   binaries.  Likewise for compat/inet_ntop.c, compat/inet_pton.c,
>   compat/nedmalloc/*, and contrib/fast-import/git-p4.
>
> Maybe we should provide a file NOTICES with all the required notices?
> I admit I'm happier sticking to the line "Please grep for
> '[Cc]opyright' for detailed distribution terms.  If you ship the
> corresponding source code with your binaries, you're probably in the
> clear."

Having a file like NOTICES that contains all explicit copyright
notices required sounds like it will help package maintainers. But it
can also make them lazy and blindly copy the file, which can lead them
in (probably very minor) legal problems if we forget to update it.

This was the first instance I noticed that explicitly require a
copyright notice other than GPL (except for LGPL, which I for some
reason just assumed was covered by the GPL text), which is the reason
why I mentioned it. Examining every single source code before every
single release seems a bit kludgey, but perhaps it's the best thing to
do.

> I suppose based on a strict reading we ought to have a copy
> of the LPGL 2.1 in the source tree, though...  Maybe something like
> this can help.
>
> -- >8 --
> Subject: provide a copy of the LGPLv2.1
>

I'm a bit baffled that this is required for a GPL-program. But since
it apparently is, I think this makes sense.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 12:17 ` Erik Faye-Lund
@ 2011-05-19 16:30   ` Junio C Hamano
  2011-05-19 17:01   ` Rafael Gieschke
  1 sibling, 0 replies; 19+ messages in thread
From: Junio C Hamano @ 2011-05-19 16:30 UTC (permalink / raw)
  To: kusmabite; +Cc: Rafael Gieschke, git

Erik Faye-Lund <kusmabite@gmail.com> writes:

> Do we really need two implementations? Wouldn't it be better to factor
> out the mingw-version to a separate source file, and then improve it?

Thanks for reminding.

> Windows doesn't have /dev/tty, but the logic in this version handles
> that by using stdin/stderr instead. The signal-stuff has a comment
> that indicates it might not even be correct. tcgetattr/tcsetattr isn't
> supported on Windows, but it's not needed if we use getch (as the
> version in compat/mingw.c does). POSIX/curses getch respects the
> echo-setting, while Windows getch never echo.

I forgot to check how generic/reusable mingw version would look. As you
said, it does feel a lot more attractive approach if it is trivial to add
the "noecho" bit to it, tweak the tty-ness and deal with signals.

I however suspect the result would end up on the borderline to be called
"trivial", rough guestimate being 3-4 times as large as the 14-line mingw
version. But it certainly feels that it is worth a try.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 12:17 ` Erik Faye-Lund
  2011-05-19 16:30   ` Junio C Hamano
@ 2011-05-19 17:01   ` Rafael Gieschke
  2011-05-19 17:27     ` Junio C Hamano
  1 sibling, 1 reply; 19+ messages in thread
From: Rafael Gieschke @ 2011-05-19 17:01 UTC (permalink / raw)
  To: kusmabite; +Cc: git, Junio C Hamano


Am 19.05.2011 um 14:17 schrieb Erik Faye-Lund:

> But I can't help to think that this implementation of getpass looks a
> bit heavy, especially since we already have our own getpass
> implementation in compat/mingw.c.

> Do we really need two implementations? Wouldn't it be better to factor
> out the mingw-version to a separate source file, and then improve it?

Yes, I agree very much that it would be nicer to have a common version.


> Windows doesn't have /dev/tty, but the logic in this version handles
> that by using stdin/stderr instead. The signal-stuff has a comment
> that indicates it might not even be correct. tcgetattr/tcsetattr isn't
> supported on Windows, but it's not needed if we use getch (as the
> version in compat/mingw.c does). POSIX/curses getch respects the
> echo-setting, while Windows getch never echo.

Sadly, there is no curses.h on Android. So as my goal is compiling on Android, it wouldn't help much to create another dependency on curses.h.

So we would still need the /dev/tty opening and the tcgetattr/tcsetattr stuff, which would result in a very cluttered code if combined with getpass from compat/mingw.c. So I think, it will be easier to keep the two separated.

I do share your concern about the license and the heavyness of the code, so I switched to the getpass.c from uClibc and prepared a new patch. It is LGPL-v2.1 licensed, which seems like it has to be added anyway. I also tried to remove unused code from the new version as good possible.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 15:14   ` Jonathan Nieder
  2011-05-19 15:29     ` Erik Faye-Lund
@ 2011-05-19 17:17     ` Junio C Hamano
  1 sibling, 0 replies; 19+ messages in thread
From: Junio C Hamano @ 2011-05-19 17:17 UTC (permalink / raw)
  To: Jonathan Nieder; +Cc: Erik Faye-Lund, Rafael Gieschke, git

Jonathan Nieder <jrnieder@gmail.com> writes:

> Maybe we should provide a file NOTICES with all the required notices?
> I admit I'm happier sticking to the line "Please grep for
> '[Cc]opyright' for detailed distribution terms.  If you ship the
> corresponding source code with your binaries, you're probably in the
> clear."  I suppose based on a strict reading we ought to have a copy


> ...  I suppose based on a strict reading we ought to have a copy
> of the LPGL 2.1 in the source tree, though...  Maybe something like
> this can help.

Thanks.

> -- >8 --
> Subject: provide a copy of the LGPLv2.1
>
> The LGPL seems to require providing a copy of the license when
> distributing xdiff, compat/fnmatch, and so on, or altering the license
> notices to refer to the GPL intead.  Since we don't want to do the
> latter, let's do the former.  It's nice to let people know their
> rights anyway.
>
> Inspired-by: Erik Faye-Lund <kusmabite@gmail.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> [1] http://packages.debian.org/changelogs/pool/main/g/git/current/copyright
>
>  LGPL-2.1 |  511 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 511 insertions(+), 0 deletions(-)
>  create mode 100644 LGPL-2.1
>
> diff --git a/LGPL-2.1 b/LGPL-2.1
> new file mode 100644
> index 0000000..d38b1b9
> --- /dev/null
> +++ b/LGPL-2.1
> @@ -0,0 +1,511 @@
> +
> + While most of this project is under the GPL (see COPYING), the xdiff/
> + library and some libc code from compat/ are licensed under the
> + GNU LGPL, version 2.1 or (at your option) any later version and some
> + other files are under other licenses.  Check the individual files to
> + be sure.
> +
> +----------------------------------------
> +
> +                  GNU LESSER GENERAL PUBLIC LICENSE
> +                       Version 2.1, February 1999
> +
> + Copyright (C) 1991, 1999 Free Software Foundation, Inc.
> + 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
> + Everyone is permitted to copy and distribute verbatim copies
> + of this license document, but changing it is not allowed.
> +
> +[This is the first released version of the Lesser GPL.  It also counts
> + as the successor of the GNU Library Public License, version 2, hence
> + the version number 2.1.]
> +
> +                            Preamble
> +
> +  The licenses for most software are designed to take away your
> +freedom to share and change it.  By contrast, the GNU General Public
> +Licenses are intended to guarantee your freedom to share and change
> +free software--to make sure the software is free for all its users.
> +
> +  This license, the Lesser General Public License, applies to some
> +specially designated software packages--typically libraries--of the
> +Free Software Foundation and other authors who decide to use it.  You
> +can use it too, but we suggest you first think carefully about whether
> +this license or the ordinary General Public License is the better
> +strategy to use in any particular case, based on the explanations below.
> +
> +  When we speak of free software, we are referring to freedom of use,
> +not price.  Our General Public Licenses are designed to make sure that
> +you have the freedom to distribute copies of free software (and charge
> +for this service if you wish); that you receive source code or can get
> +it if you want it; that you can change the software and use pieces of
> +it in new free programs; and that you are informed that you can do
> +these things.
> +
> +  To protect your rights, we need to make restrictions that forbid
> +distributors to deny you these rights or to ask you to surrender these
> +rights.  These restrictions translate to certain responsibilities for
> +you if you distribute copies of the library or if you modify it.
> +
> +  For example, if you distribute copies of the library, whether gratis
> +or for a fee, you must give the recipients all the rights that we gave
> +you.  You must make sure that they, too, receive or can get the source
> +code.  If you link other code with the library, you must provide
> +complete object files to the recipients, so that they can relink them
> +with the library after making changes to the library and recompiling
> +it.  And you must show them these terms so they know their rights.
> +
> +  We protect your rights with a two-step method: (1) we copyright the
> +library, and (2) we offer you this license, which gives you legal
> +permission to copy, distribute and/or modify the library.
> +
> +  To protect each distributor, we want to make it very clear that
> +there is no warranty for the free library.  Also, if the library is
> +modified by someone else and passed on, the recipients should know
> +that what they have is not the original version, so that the original
> +author's reputation will not be affected by problems that might be
> +introduced by others.
> +\f
> +  Finally, software patents pose a constant threat to the existence of
> +any free program.  We wish to make sure that a company cannot
> +effectively restrict the users of a free program by obtaining a
> +restrictive license from a patent holder.  Therefore, we insist that
> +any patent license obtained for a version of the library must be
> +consistent with the full freedom of use specified in this license.
> +
> +  Most GNU software, including some libraries, is covered by the
> +ordinary GNU General Public License.  This license, the GNU Lesser
> +General Public License, applies to certain designated libraries, and
> +is quite different from the ordinary General Public License.  We use
> +this license for certain libraries in order to permit linking those
> +libraries into non-free programs.
> +
> +  When a program is linked with a library, whether statically or using
> +a shared library, the combination of the two is legally speaking a
> +combined work, a derivative of the original library.  The ordinary
> +General Public License therefore permits such linking only if the
> +entire combination fits its criteria of freedom.  The Lesser General
> +Public License permits more lax criteria for linking other code with
> +the library.
> +
> +  We call this license the "Lesser" General Public License because it
> +does Less to protect the user's freedom than the ordinary General
> +Public License.  It also provides other free software developers Less
> +of an advantage over competing non-free programs.  These disadvantages
> +are the reason we use the ordinary General Public License for many
> +libraries.  However, the Lesser license provides advantages in certain
> +special circumstances.
> +
> +  For example, on rare occasions, there may be a special need to
> +encourage the widest possible use of a certain library, so that it becomes
> +a de-facto standard.  To achieve this, non-free programs must be
> +allowed to use the library.  A more frequent case is that a free
> +library does the same job as widely used non-free libraries.  In this
> +case, there is little to gain by limiting the free library to free
> +software only, so we use the Lesser General Public License.
> +
> +  In other cases, permission to use a particular library in non-free
> +programs enables a greater number of people to use a large body of
> +free software.  For example, permission to use the GNU C Library in
> +non-free programs enables many more people to use the whole GNU
> +operating system, as well as its variant, the GNU/Linux operating
> +system.
> +
> +  Although the Lesser General Public License is Less protective of the
> +users' freedom, it does ensure that the user of a program that is
> +linked with the Library has the freedom and the wherewithal to run
> +that program using a modified version of the Library.
> +
> +  The precise terms and conditions for copying, distribution and
> +modification follow.  Pay close attention to the difference between a
> +"work based on the library" and a "work that uses the library".  The
> +former contains code derived from the library, whereas the latter must
> +be combined with the library in order to run.
> +\f
> +                  GNU LESSER GENERAL PUBLIC LICENSE
> +   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
> +
> +  0. This License Agreement applies to any software library or other
> +program which contains a notice placed by the copyright holder or
> +other authorized party saying it may be distributed under the terms of
> +this Lesser General Public License (also called "this License").
> +Each licensee is addressed as "you".
> +
> +  A "library" means a collection of software functions and/or data
> +prepared so as to be conveniently linked with application programs
> +(which use some of those functions and data) to form executables.
> +
> +  The "Library", below, refers to any such software library or work
> +which has been distributed under these terms.  A "work based on the
> +Library" means either the Library or any derivative work under
> +copyright law: that is to say, a work containing the Library or a
> +portion of it, either verbatim or with modifications and/or translated
> +straightforwardly into another language.  (Hereinafter, translation is
> +included without limitation in the term "modification".)
> +
> +  "Source code" for a work means the preferred form of the work for
> +making modifications to it.  For a library, complete source code means
> +all the source code for all modules it contains, plus any associated
> +interface definition files, plus the scripts used to control compilation
> +and installation of the library.
> +
> +  Activities other than copying, distribution and modification are not
> +covered by this License; they are outside its scope.  The act of
> +running a program using the Library is not restricted, and output from
> +such a program is covered only if its contents constitute a work based
> +on the Library (independent of the use of the Library in a tool for
> +writing it).  Whether that is true depends on what the Library does
> +and what the program that uses the Library does.
> +
> +  1. You may copy and distribute verbatim copies of the Library's
> +complete source code as you receive it, in any medium, provided that
> +you conspicuously and appropriately publish on each copy an
> +appropriate copyright notice and disclaimer of warranty; keep intact
> +all the notices that refer to this License and to the absence of any
> +warranty; and distribute a copy of this License along with the
> +Library.
> +
> +  You may charge a fee for the physical act of transferring a copy,
> +and you may at your option offer warranty protection in exchange for a
> +fee.
> +\f
> +  2. You may modify your copy or copies of the Library or any portion
> +of it, thus forming a work based on the Library, and copy and
> +distribute such modifications or work under the terms of Section 1
> +above, provided that you also meet all of these conditions:
> +
> +    a) The modified work must itself be a software library.
> +
> +    b) You must cause the files modified to carry prominent notices
> +    stating that you changed the files and the date of any change.
> +
> +    c) You must cause the whole of the work to be licensed at no
> +    charge to all third parties under the terms of this License.
> +
> +    d) If a facility in the modified Library refers to a function or a
> +    table of data to be supplied by an application program that uses
> +    the facility, other than as an argument passed when the facility
> +    is invoked, then you must make a good faith effort to ensure that,
> +    in the event an application does not supply such function or
> +    table, the facility still operates, and performs whatever part of
> +    its purpose remains meaningful.
> +
> +    (For example, a function in a library to compute square roots has
> +    a purpose that is entirely well-defined independent of the
> +    application.  Therefore, Subsection 2d requires that any
> +    application-supplied function or table used by this function must
> +    be optional: if the application does not supply it, the square
> +    root function must still compute square roots.)
> +
> +These requirements apply to the modified work as a whole.  If
> +identifiable sections of that work are not derived from the Library,
> +and can be reasonably considered independent and separate works in
> +themselves, then this License, and its terms, do not apply to those
> +sections when you distribute them as separate works.  But when you
> +distribute the same sections as part of a whole which is a work based
> +on the Library, the distribution of the whole must be on the terms of
> +this License, whose permissions for other licensees extend to the
> +entire whole, and thus to each and every part regardless of who wrote
> +it.
> +
> +Thus, it is not the intent of this section to claim rights or contest
> +your rights to work written entirely by you; rather, the intent is to
> +exercise the right to control the distribution of derivative or
> +collective works based on the Library.
> +
> +In addition, mere aggregation of another work not based on the Library
> +with the Library (or with a work based on the Library) on a volume of
> +a storage or distribution medium does not bring the other work under
> +the scope of this License.
> +
> +  3. You may opt to apply the terms of the ordinary GNU General Public
> +License instead of this License to a given copy of the Library.  To do
> +this, you must alter all the notices that refer to this License, so
> +that they refer to the ordinary GNU General Public License, version 2,
> +instead of to this License.  (If a newer version than version 2 of the
> +ordinary GNU General Public License has appeared, then you can specify
> +that version instead if you wish.)  Do not make any other change in
> +these notices.
> +\f
> +  Once this change is made in a given copy, it is irreversible for
> +that copy, so the ordinary GNU General Public License applies to all
> +subsequent copies and derivative works made from that copy.
> +
> +  This option is useful when you wish to copy part of the code of
> +the Library into a program that is not a library.
> +
> +  4. You may copy and distribute the Library (or a portion or
> +derivative of it, under Section 2) in object code or executable form
> +under the terms of Sections 1 and 2 above provided that you accompany
> +it with the complete corresponding machine-readable source code, which
> +must be distributed under the terms of Sections 1 and 2 above on a
> +medium customarily used for software interchange.
> +
> +  If distribution of object code is made by offering access to copy
> +from a designated place, then offering equivalent access to copy the
> +source code from the same place satisfies the requirement to
> +distribute the source code, even though third parties are not
> +compelled to copy the source along with the object code.
> +
> +  5. A program that contains no derivative of any portion of the
> +Library, but is designed to work with the Library by being compiled or
> +linked with it, is called a "work that uses the Library".  Such a
> +work, in isolation, is not a derivative work of the Library, and
> +therefore falls outside the scope of this License.
> +
> +  However, linking a "work that uses the Library" with the Library
> +creates an executable that is a derivative of the Library (because it
> +contains portions of the Library), rather than a "work that uses the
> +library".  The executable is therefore covered by this License.
> +Section 6 states terms for distribution of such executables.
> +
> +  When a "work that uses the Library" uses material from a header file
> +that is part of the Library, the object code for the work may be a
> +derivative work of the Library even though the source code is not.
> +Whether this is true is especially significant if the work can be
> +linked without the Library, or if the work is itself a library.  The
> +threshold for this to be true is not precisely defined by law.
> +
> +  If such an object file uses only numerical parameters, data
> +structure layouts and accessors, and small macros and small inline
> +functions (ten lines or less in length), then the use of the object
> +file is unrestricted, regardless of whether it is legally a derivative
> +work.  (Executables containing this object code plus portions of the
> +Library will still fall under Section 6.)
> +
> +  Otherwise, if the work is a derivative of the Library, you may
> +distribute the object code for the work under the terms of Section 6.
> +Any executables containing that work also fall under Section 6,
> +whether or not they are linked directly with the Library itself.
> +\f
> +  6. As an exception to the Sections above, you may also combine or
> +link a "work that uses the Library" with the Library to produce a
> +work containing portions of the Library, and distribute that work
> +under terms of your choice, provided that the terms permit
> +modification of the work for the customer's own use and reverse
> +engineering for debugging such modifications.
> +
> +  You must give prominent notice with each copy of the work that the
> +Library is used in it and that the Library and its use are covered by
> +this License.  You must supply a copy of this License.  If the work
> +during execution displays copyright notices, you must include the
> +copyright notice for the Library among them, as well as a reference
> +directing the user to the copy of this License.  Also, you must do one
> +of these things:
> +
> +    a) Accompany the work with the complete corresponding
> +    machine-readable source code for the Library including whatever
> +    changes were used in the work (which must be distributed under
> +    Sections 1 and 2 above); and, if the work is an executable linked
> +    with the Library, with the complete machine-readable "work that
> +    uses the Library", as object code and/or source code, so that the
> +    user can modify the Library and then relink to produce a modified
> +    executable containing the modified Library.  (It is understood
> +    that the user who changes the contents of definitions files in the
> +    Library will not necessarily be able to recompile the application
> +    to use the modified definitions.)
> +
> +    b) Use a suitable shared library mechanism for linking with the
> +    Library.  A suitable mechanism is one that (1) uses at run time a
> +    copy of the library already present on the user's computer system,
> +    rather than copying library functions into the executable, and (2)
> +    will operate properly with a modified version of the library, if
> +    the user installs one, as long as the modified version is
> +    interface-compatible with the version that the work was made with.
> +
> +    c) Accompany the work with a written offer, valid for at
> +    least three years, to give the same user the materials
> +    specified in Subsection 6a, above, for a charge no more
> +    than the cost of performing this distribution.
> +
> +    d) If distribution of the work is made by offering access to copy
> +    from a designated place, offer equivalent access to copy the above
> +    specified materials from the same place.
> +
> +    e) Verify that the user has already received a copy of these
> +    materials or that you have already sent this user a copy.
> +
> +  For an executable, the required form of the "work that uses the
> +Library" must include any data and utility programs needed for
> +reproducing the executable from it.  However, as a special exception,
> +the materials to be distributed need not include anything that is
> +normally distributed (in either source or binary form) with the major
> +components (compiler, kernel, and so on) of the operating system on
> +which the executable runs, unless that component itself accompanies
> +the executable.
> +
> +  It may happen that this requirement contradicts the license
> +restrictions of other proprietary libraries that do not normally
> +accompany the operating system.  Such a contradiction means you cannot
> +use both them and the Library together in an executable that you
> +distribute.
> +\f
> +  7. You may place library facilities that are a work based on the
> +Library side-by-side in a single library together with other library
> +facilities not covered by this License, and distribute such a combined
> +library, provided that the separate distribution of the work based on
> +the Library and of the other library facilities is otherwise
> +permitted, and provided that you do these two things:
> +
> +    a) Accompany the combined library with a copy of the same work
> +    based on the Library, uncombined with any other library
> +    facilities.  This must be distributed under the terms of the
> +    Sections above.
> +
> +    b) Give prominent notice with the combined library of the fact
> +    that part of it is a work based on the Library, and explaining
> +    where to find the accompanying uncombined form of the same work.
> +
> +  8. You may not copy, modify, sublicense, link with, or distribute
> +the Library except as expressly provided under this License.  Any
> +attempt otherwise to copy, modify, sublicense, link with, or
> +distribute the Library is void, and will automatically terminate your
> +rights under this License.  However, parties who have received copies,
> +or rights, from you under this License will not have their licenses
> +terminated so long as such parties remain in full compliance.
> +
> +  9. You are not required to accept this License, since you have not
> +signed it.  However, nothing else grants you permission to modify or
> +distribute the Library or its derivative works.  These actions are
> +prohibited by law if you do not accept this License.  Therefore, by
> +modifying or distributing the Library (or any work based on the
> +Library), you indicate your acceptance of this License to do so, and
> +all its terms and conditions for copying, distributing or modifying
> +the Library or works based on it.
> +
> +  10. Each time you redistribute the Library (or any work based on the
> +Library), the recipient automatically receives a license from the
> +original licensor to copy, distribute, link with or modify the Library
> +subject to these terms and conditions.  You may not impose any further
> +restrictions on the recipients' exercise of the rights granted herein.
> +You are not responsible for enforcing compliance by third parties with
> +this License.
> +\f
> +  11. If, as a consequence of a court judgment or allegation of patent
> +infringement or for any other reason (not limited to patent issues),
> +conditions are imposed on you (whether by court order, agreement or
> +otherwise) that contradict the conditions of this License, they do not
> +excuse you from the conditions of this License.  If you cannot
> +distribute so as to satisfy simultaneously your obligations under this
> +License and any other pertinent obligations, then as a consequence you
> +may not distribute the Library at all.  For example, if a patent
> +license would not permit royalty-free redistribution of the Library by
> +all those who receive copies directly or indirectly through you, then
> +the only way you could satisfy both it and this License would be to
> +refrain entirely from distribution of the Library.
> +
> +If any portion of this section is held invalid or unenforceable under any
> +particular circumstance, the balance of the section is intended to apply,
> +and the section as a whole is intended to apply in other circumstances.
> +
> +It is not the purpose of this section to induce you to infringe any
> +patents or other property right claims or to contest validity of any
> +such claims; this section has the sole purpose of protecting the
> +integrity of the free software distribution system which is
> +implemented by public license practices.  Many people have made
> +generous contributions to the wide range of software distributed
> +through that system in reliance on consistent application of that
> +system; it is up to the author/donor to decide if he or she is willing
> +to distribute software through any other system and a licensee cannot
> +impose that choice.
> +
> +This section is intended to make thoroughly clear what is believed to
> +be a consequence of the rest of this License.
> +
> +  12. If the distribution and/or use of the Library is restricted in
> +certain countries either by patents or by copyrighted interfaces, the
> +original copyright holder who places the Library under this License may add
> +an explicit geographical distribution limitation excluding those countries,
> +so that distribution is permitted only in or among countries not thus
> +excluded.  In such case, this License incorporates the limitation as if
> +written in the body of this License.
> +
> +  13. The Free Software Foundation may publish revised and/or new
> +versions of the Lesser General Public License from time to time.
> +Such new versions will be similar in spirit to the present version,
> +but may differ in detail to address new problems or concerns.
> +
> +Each version is given a distinguishing version number.  If the Library
> +specifies a version number of this License which applies to it and
> +"any later version", you have the option of following the terms and
> +conditions either of that version or of any later version published by
> +the Free Software Foundation.  If the Library does not specify a
> +license version number, you may choose any version ever published by
> +the Free Software Foundation.
> +\f
> +  14. If you wish to incorporate parts of the Library into other free
> +programs whose distribution conditions are incompatible with these,
> +write to the author to ask for permission.  For software which is
> +copyrighted by the Free Software Foundation, write to the Free
> +Software Foundation; we sometimes make exceptions for this.  Our
> +decision will be guided by the two goals of preserving the free status
> +of all derivatives of our free software and of promoting the sharing
> +and reuse of software generally.
> +
> +                            NO WARRANTY
> +
> +  15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO
> +WARRANTY FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW.
> +EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR
> +OTHER PARTIES PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY
> +KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE
> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> +PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE
> +LIBRARY IS WITH YOU.  SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME
> +THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
> +
> +  16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN
> +WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY
> +AND/OR REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU
> +FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR
> +CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE
> +LIBRARY (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING
> +RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A
> +FAILURE OF THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF
> +SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
> +DAMAGES.
> +
> +                     END OF TERMS AND CONDITIONS
> +\f
> +           How to Apply These Terms to Your New Libraries
> +
> +  If you develop a new library, and you want it to be of the greatest
> +possible use to the public, we recommend making it free software that
> +everyone can redistribute and change.  You can do so by permitting
> +redistribution under these terms (or, alternatively, under the terms of the
> +ordinary General Public License).
> +
> +  To apply these terms, attach the following notices to the library.  It is
> +safest to attach them to the start of each source file to most effectively
> +convey the exclusion of warranty; and each file should have at least the
> +"copyright" line and a pointer to where the full notice is found.
> +
> +    <one line to give the library's name and a brief idea of what it does.>
> +    Copyright (C) <year>  <name of author>
> +
> +    This library is free software; you can redistribute it and/or
> +    modify it under the terms of the GNU Lesser General Public
> +    License as published by the Free Software Foundation; either
> +    version 2.1 of the License, or (at your option) any later version.
> +
> +    This library is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +    Lesser General Public License for more details.
> +
> +    You should have received a copy of the GNU Lesser General Public
> +    License along with this library; if not, write to the Free Software
> +    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
> +
> +Also add information on how to contact you by electronic and paper mail.
> +
> +You should also get your employer (if you work as a programmer) or your
> +school, if any, to sign a "copyright disclaimer" for the library, if
> +necessary.  Here is a sample; alter the names:
> +
> +  Yoyodyne, Inc., hereby disclaims all copyright interest in the
> +  library `Frob' (a library for tweaking knobs) written by James Random Hacker.
> +
> +  <signature of Ty Coon>, 1 April 1990
> +  Ty Coon, President of Vice
> +
> +That's all there is to it!

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 17:01   ` Rafael Gieschke
@ 2011-05-19 17:27     ` Junio C Hamano
  2011-05-19 18:07       ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Junio C Hamano @ 2011-05-19 17:27 UTC (permalink / raw)
  To: kusmabite; +Cc: Rafael Gieschke, git

Rafael Gieschke <rafael@gieschke.de> writes:

>> Windows doesn't have /dev/tty, but the logic in this version handles
>> that by using stdin/stderr instead. The signal-stuff has a comment
>> that indicates it might not even be correct. tcgetattr/tcsetattr isn't
>> supported on Windows, but it's not needed if we use getch (as the
>> version in compat/mingw.c does). POSIX/curses getch respects the
>> echo-setting, while Windows getch never echo.

Probably a properly abstracted common version would look like a function
that calls four platform-dependent helper funcions in this order:

	0. prompt
	1. start "noecho" mode
        2. get whole line
        3. exit "noecho" mode

where Windows may use stderr for 0, have noop() implementation for 1 and
3, use _getch() that does not echo for 2, while POSIX may write to
/dev/tty for 0, use tc[gs]etattr() with perhaps some signal settings
sprinkled in for 1 and 3.

So I don't see a need for Windows to emulate tc[g]setattr nor curses in
order to get a generic getpass() abstraction between two platforms.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 17:27     ` Junio C Hamano
@ 2011-05-19 18:07       ` Erik Faye-Lund
  2011-05-19 19:16         ` Rafael Gieschke
  0 siblings, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 18:07 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Rafael Gieschke, Git Mailing List, Johannes Schindelin

On Thu, May 19, 2011 at 7:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Rafael Gieschke <rafael@gieschke.de> writes:
>
>>> Windows doesn't have /dev/tty, but the logic in this version handles
>>> that by using stdin/stderr instead. The signal-stuff has a comment
>>> that indicates it might not even be correct. tcgetattr/tcsetattr isn't
>>> supported on Windows, but it's not needed if we use getch (as the
>>> version in compat/mingw.c does). POSIX/curses getch respects the
>>> echo-setting, while Windows getch never echo.
>
> Probably a properly abstracted common version would look like a function
> that calls four platform-dependent helper funcions in this order:
>
>        0. prompt
>        1. start "noecho" mode
>        2. get whole line
>        3. exit "noecho" mode
>
> where Windows may use stderr for 0, have noop() implementation for 1 and
> 3, use _getch() that does not echo for 2, while POSIX may write to
> /dev/tty for 0, use tc[gs]etattr() with perhaps some signal settings
> sprinkled in for 1 and 3.
>
> So I don't see a need for Windows to emulate tc[g]setattr nor curses in
> order to get a generic getpass() abstraction between two platforms.
>

When I think about it a bit more, it feels a bit pointless:
0. is identical (fputs)
1. is different (tc[gs]etattr vs nop)
2. is different (getc vs _getch)
3. is different (tcsetattr vs nop)

So there's probably not much code to share here. There's a bit of
logic, but I'm not entirely sure this should be the same either,
because on Windows we have to take care of '\r' (since we open stdin
in binary mode at start-up).

But looking at the implementations, there's one thing that strike me:
both the netbsd and uclibc implementations fill a static buffer, while
our windows-version returns an allocated buffer. Reading POSIX, it's
not entirely clear if the returned pointer should be free'd or not:
http://pubs.opengroup.org/onlinepubs/007908799/xsh/getpass.html

But there is a hint: the limit of PASS_MAX bytes indicate that the
buffer is expected to be statically allocated. So perhaps we should do
this to prevent a leak?

diff --git a/compat/mingw.c b/compat/mingw.c
index 878b1de..dba3e64 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1668,17 +1668,19 @@ int link(const char *oldpath, const char *newpath)

 char *getpass(const char *prompt)
 {
-	struct strbuf buf = STRBUF_INIT;
+	static char buf[PASS_MAX];
+	int i;

 	fputs(prompt, stderr);
-	for (;;) {
+	for (i = 0; i < PASS_MAX - 1; ++i) {
 		char c = _getch();
 		if (c == '\r' || c == '\n')
 			break;
-		strbuf_addch(&buf, c);
+		buf[i] = c;
 	}
+	buf[i] = '\0';
 	fputs("\n", stderr);
-	return strbuf_detach(&buf, NULL);
+	return buf;
 }

 pid_t waitpid(pid_t pid, int *status, unsigned options)
diff --git a/compat/mingw.h b/compat/mingw.h
index 62eccd3..e37d557 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -48,6 +48,8 @@ typedef int socklen_t;
 #define EAFNOSUPPORT WSAEAFNOSUPPORT
 #define ECONNABORTED WSAECONNABORTED

+#define PASS_MAX 512
+
 struct passwd {
 	char *pw_name;
 	char *pw_gecos;

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 18:07       ` Erik Faye-Lund
@ 2011-05-19 19:16         ` Rafael Gieschke
  2011-05-19 19:19           ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Rafael Gieschke @ 2011-05-19 19:16 UTC (permalink / raw)
  To: kusmabite; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin


Am 19.05.2011 um 20:07 schrieb Erik Faye-Lund:

> On Thu, May 19, 2011 at 7:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Probably a properly abstracted common version would look like a function
>> that calls four platform-dependent helper funcions in this order:
>> 
>>        0. prompt
>>        1. start "noecho" mode
>>        2. get whole line
>>        3. exit "noecho" mode
>> 
> 
> When I think about it a bit more, it feels a bit pointless:
> 0. is identical (fputs)
> 1. is different (tc[gs]etattr vs nop)
> 2. is different (getc vs _getch)
> 3. is different (tcsetattr vs nop)
> 
> So there's probably not much code to share here. There's a bit of
> logic, but I'm not entirely sure this should be the same either,
> because on Windows we have to take care of '\r' (since we open stdin
> in binary mode at start-up).
> 

I agree, 0 would even have to be different, too, as we have to write to /dev/tty (which would have to be opened first) or (as fallback) stderr on POSIX.


> diff --git a/compat/mingw.h b/compat/mingw.h
> index 62eccd3..e37d557 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -48,6 +48,8 @@ typedef int socklen_t;
> #define EAFNOSUPPORT WSAEAFNOSUPPORT
> #define ECONNABORTED WSAECONNABORTED
> 
> +#define PASS_MAX 512
> +

It might be worth to have this in git-compat-util.h, so it can also be used by compat/getpass.c. I'm not sure about the name, however; it's a remote password and MAX_PASS is about local passwords AFAIK. Maybe PASS_MAX_REMOTE or something similiar. Like that, compat/getpass.c could also be used in case MAX_PASS has some insanely low value on a platform.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 19:16         ` Rafael Gieschke
@ 2011-05-19 19:19           ` Erik Faye-Lund
  2011-05-19 19:42             ` Rafael Gieschke
  0 siblings, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 19:19 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin

On Thu, May 19, 2011 at 9:16 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>
> Am 19.05.2011 um 20:07 schrieb Erik Faye-Lund:
>> diff --git a/compat/mingw.h b/compat/mingw.h
>> index 62eccd3..e37d557 100644
>> --- a/compat/mingw.h
>> +++ b/compat/mingw.h
>> @@ -48,6 +48,8 @@ typedef int socklen_t;
>> #define EAFNOSUPPORT WSAEAFNOSUPPORT
>> #define ECONNABORTED WSAECONNABORTED
>>
>> +#define PASS_MAX 512
>> +
>
> It might be worth to have this in git-compat-util.h, so it can also be used by compat/getpass.c. I'm not sure about the name, however; it's a remote password and MAX_PASS is about local passwords AFAIK. Maybe PASS_MAX_REMOTE or something similiar. Like that, compat/getpass.c could also be used in case MAX_PASS has some insanely low value on a platform.
>
>

PASS_MAX should be defined in limits.h (which is included by
git-compat-util.h) on POSIX platforms:
http://pubs.opengroup.org/onlinepubs/007908799/xsh/limits.h.html

If it turns out it's not on some platforms, perhaps a define-guarded
version would make sense in git-compat-util.h instead.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 19:19           ` Erik Faye-Lund
@ 2011-05-19 19:42             ` Rafael Gieschke
  2011-05-19 20:12               ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Rafael Gieschke @ 2011-05-19 19:42 UTC (permalink / raw)
  To: kusmabite; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin


Am 19.05.2011 um 21:19 schrieb Erik Faye-Lund:

> On Thu, May 19, 2011 at 9:16 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>> 
>> Am 19.05.2011 um 20:07 schrieb Erik Faye-Lund:
>>> diff --git a/compat/mingw.h b/compat/mingw.h
>>> index 62eccd3..e37d557 100644
>>> --- a/compat/mingw.h
>>> +++ b/compat/mingw.h
>>> @@ -48,6 +48,8 @@ typedef int socklen_t;
>>> #define EAFNOSUPPORT WSAEAFNOSUPPORT
>>> #define ECONNABORTED WSAECONNABORTED
>>> 
>>> +#define PASS_MAX 512
>>> +
>> 
>> It might be worth to have this in git-compat-util.h, so it can also be used by compat/getpass.c. I'm not sure about the name, however; it's a remote password and MAX_PASS is about local passwords AFAIK. Maybe PASS_MAX_REMOTE or something similiar. Like that, compat/getpass.c could also be used in case MAX_PASS has some insanely low value on a platform.
>> 
>> 
> 
> PASS_MAX should be defined in limits.h (which is included by
> git-compat-util.h) on POSIX platforms:
> http://pubs.opengroup.org/onlinepubs/007908799/xsh/limits.h.html
> 
> If it turns out it's not on some platforms, perhaps a define-guarded
> version would make sense in git-compat-util.h instead.

It is defined even on Android :-).

But I still wonder whether it's the right thing or if you should use it only for local passwords.

If you imagine a platform with MAX_PASS=8, git couldn't connect to an IMAP server with a password of 10 chars on this platform without any proper reason.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 19:42             ` Rafael Gieschke
@ 2011-05-19 20:12               ` Erik Faye-Lund
  2011-05-19 21:16                 ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 20:12 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin

On Thu, May 19, 2011 at 9:42 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>
> Am 19.05.2011 um 21:19 schrieb Erik Faye-Lund:
>
>> On Thu, May 19, 2011 at 9:16 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>>>
>>> Am 19.05.2011 um 20:07 schrieb Erik Faye-Lund:
>>>> diff --git a/compat/mingw.h b/compat/mingw.h
>>>> index 62eccd3..e37d557 100644
>>>> --- a/compat/mingw.h
>>>> +++ b/compat/mingw.h
>>>> @@ -48,6 +48,8 @@ typedef int socklen_t;
>>>> #define EAFNOSUPPORT WSAEAFNOSUPPORT
>>>> #define ECONNABORTED WSAECONNABORTED
>>>>
>>>> +#define PASS_MAX 512
>>>> +
>>>
>>> It might be worth to have this in git-compat-util.h, so it can also be used by compat/getpass.c. I'm not sure about the name, however; it's a remote password and MAX_PASS is about local passwords AFAIK. Maybe PASS_MAX_REMOTE or something similiar. Like that, compat/getpass.c could also be used in case MAX_PASS has some insanely low value on a platform.
>>>
>>>
>>
>> PASS_MAX should be defined in limits.h (which is included by
>> git-compat-util.h) on POSIX platforms:
>> http://pubs.opengroup.org/onlinepubs/007908799/xsh/limits.h.html
>>
>> If it turns out it's not on some platforms, perhaps a define-guarded
>> version would make sense in git-compat-util.h instead.
>
> It is defined even on Android :-).
>

Good to hear.

> But I still wonder whether it's the right thing or if you should use it only for local passwords.
>
> If you imagine a platform with MAX_PASS=8, git couldn't connect to an IMAP server with a password of 10 chars on this platform without any proper reason.
>

Well, those platforms would currently fail, since that's the limit on
the string returned from getpass. Since that hasn't happened yet, I
suspect that this is a very theoretical problem.

If we created our own define we could fix such problems by setting
NO_GETPASS and having a reasonable lengthy GIT_MAX_PASS. But let's
leave that theoretical fix for when/if it turns out to be real, huh?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 20:12               ` Erik Faye-Lund
@ 2011-05-19 21:16                 ` Erik Faye-Lund
  2011-05-20 10:06                   ` Rafael Gieschke
  0 siblings, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-19 21:16 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin

On Thu, May 19, 2011 at 10:12 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> On Thu, May 19, 2011 at 9:42 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>>
>> Am 19.05.2011 um 21:19 schrieb Erik Faye-Lund:
>>
>>> On Thu, May 19, 2011 at 9:16 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>>>>
>>>> Am 19.05.2011 um 20:07 schrieb Erik Faye-Lund:
>>>>> diff --git a/compat/mingw.h b/compat/mingw.h
>>>>> index 62eccd3..e37d557 100644
>>>>> --- a/compat/mingw.h
>>>>> +++ b/compat/mingw.h
>>>>> @@ -48,6 +48,8 @@ typedef int socklen_t;
>>>>> #define EAFNOSUPPORT WSAEAFNOSUPPORT
>>>>> #define ECONNABORTED WSAECONNABORTED
>>>>>
>>>>> +#define PASS_MAX 512
>>>>> +
>>>>
>>>> It might be worth to have this in git-compat-util.h, so it can also be used by compat/getpass.c. I'm not sure about the name, however; it's a remote password and MAX_PASS is about local passwords AFAIK. Maybe PASS_MAX_REMOTE or something similiar. Like that, compat/getpass.c could also be used in case MAX_PASS has some insanely low value on a platform.
>>>>
>>>>
>>>
>>> PASS_MAX should be defined in limits.h (which is included by
>>> git-compat-util.h) on POSIX platforms:
>>> http://pubs.opengroup.org/onlinepubs/007908799/xsh/limits.h.html
>>>
>>> If it turns out it's not on some platforms, perhaps a define-guarded
>>> version would make sense in git-compat-util.h instead.
>>
>> It is defined even on Android :-).
>>
>
> Good to hear.
>
>> But I still wonder whether it's the right thing or if you should use it only for local passwords.
>>
>> If you imagine a platform with MAX_PASS=8, git couldn't connect to an IMAP server with a password of 10 chars on this platform without any proper reason.
>>
>
> Well, those platforms would currently fail, since that's the limit on
> the string returned from getpass. Since that hasn't happened yet, I
> suspect that this is a very theoretical problem.
>
> If we created our own define we could fix such problems by setting
> NO_GETPASS and having a reasonable lengthy GIT_MAX_PASS. But let's
> leave that theoretical fix for when/if it turns out to be real, huh?
>

Whoa: http://www.opengroup.org/csq/view.mhtml?norationale=1&noreferences=1&RID=sun%2FSE2%2F10

It seems that Solaris has a MAX_PASS of 8... That should mean that
prompted passwords can't be above 8 characters there (without using
GIT_ASKPASS). Can this really be the case?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-19 21:16                 ` Erik Faye-Lund
@ 2011-05-20 10:06                   ` Rafael Gieschke
  2011-05-20 10:48                     ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Rafael Gieschke @ 2011-05-20 10:06 UTC (permalink / raw)
  To: kusmabite; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin


Am 19.05.2011 um 23:16 schrieb Erik Faye-Lund:
>> 
>> Well, those platforms would currently fail, since that's the limit on
>> the string returned from getpass. Since that hasn't happened yet, I
>> suspect that this is a very theoretical problem.
>> 
>> If we created our own define we could fix such problems by setting
>> NO_GETPASS and having a reasonable lengthy GIT_MAX_PASS. But let's
>> leave that theoretical fix for when/if it turns out to be real, huh?
>> 
> 
> Whoa: http://www.opengroup.org/csq/view.mhtml?norationale=1&noreferences=1&RID=sun%2FSE2%2F10
> 
> It seems that Solaris has a MAX_PASS of 8... That should mean that
> prompted passwords can't be above 8 characters there (without using
> GIT_ASKPASS). Can this really be the case?

Good find. At least under "SunOS opensolaris 5.11 snv_111b i86pc i386 i86pc" with packages from http://sunfreeware.com/indexintel10.html, I can confirm exactly this behavior. If you try to connect to an account with password > 8 chars, git-imap-send prints "IMAP command 'LOGIN <user> <pass>' returned response (NO) - incorrect password or account name", using <= 8 chars it works fine (couldn't check git clone on https because I only have an internal IP without NAT/proxy).

So maybe it would make sense to define NO_GETPASS and use compat/getpass.c on Solaris in the Makefile?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-20 10:06                   ` Rafael Gieschke
@ 2011-05-20 10:48                     ` Erik Faye-Lund
  2011-05-20 17:18                       ` Junio C Hamano
  0 siblings, 1 reply; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-20 10:48 UTC (permalink / raw)
  To: Rafael Gieschke; +Cc: Junio C Hamano, Git Mailing List, Johannes Schindelin

On Fri, May 20, 2011 at 12:06 PM, Rafael Gieschke <rafael@gieschke.de> wrote:
>
> Am 19.05.2011 um 23:16 schrieb Erik Faye-Lund:
>>>
>>> Well, those platforms would currently fail, since that's the limit on
>>> the string returned from getpass. Since that hasn't happened yet, I
>>> suspect that this is a very theoretical problem.
>>>
>>> If we created our own define we could fix such problems by setting
>>> NO_GETPASS and having a reasonable lengthy GIT_MAX_PASS. But let's
>>> leave that theoretical fix for when/if it turns out to be real, huh?
>>>
>>
>> Whoa: http://www.opengroup.org/csq/view.mhtml?norationale=1&noreferences=1&RID=sun%2FSE2%2F10
>>
>> It seems that Solaris has a MAX_PASS of 8... That should mean that
>> prompted passwords can't be above 8 characters there (without using
>> GIT_ASKPASS). Can this really be the case?
>
> Good find. At least under "SunOS opensolaris 5.11 snv_111b i86pc i386 i86pc" with packages from http://sunfreeware.com/indexintel10.html, I can confirm exactly this behavior. If you try to connect to an account with password > 8 chars, git-imap-send prints "IMAP command 'LOGIN <user> <pass>' returned response (NO) - incorrect password or account name", using <= 8 chars it works fine (couldn't check git clone on https because I only have an internal IP without NAT/proxy).
>
> So maybe it would make sense to define NO_GETPASS and use compat/getpass.c on Solaris in the Makefile?
>

Actually, I'm thinking that we should avoid ever using getpass: it
(and MAX_PASS) seems to have been deprecated from POSIX long ago, and
is even removed from the latest version of the specification. Instead,
we should make our own function (based on your most recent patch?)
that fills a caller-specified strbuf instead (git_getpass already have
a static strbuf that we can fill).

By the way, I gave merging the POSIX and Win32 code-paths a stab, by
implementing minimal tc[gs]etattr :
http://repo.or.cz/w/git/kusma.git/shortlog/refs/heads/work/win32-termios

It's close to working, but the fact that we set stdin to binary mode
by default makes it misbehave and append '\r' to the end of the input.
I have some patches to try to avoid the nasty _setmode(...,
_O_BINARY)-hack in our mingw main-wrapper; perhaps this is the right
timing to finish those?

Another thing I tried, was to make the call to fopen use the path
"con" (which is the path to the terminal on Windows) instead of
"/dev/tty"; this made SetConsoleMode fail, claiming that the handle
was invalid. This failure baffles me, because the handle was valid a
few lines earlier, when I called GetConsoleMode... The idea was that
the handle would be explicitly opened in text-mode (since there's no
'b'-character in the mode-string), but I forgot that we also set
_fmode to _O_BINARY. Ugghhh, Git's handling of new-lines on Windows is
hacky... :P

So, it seems to me that the _setmode-hack should be killed to get this
code POSIX/Windows-unified (or the _fmode-hack and the
SetConsoleMode-failure should be combated).

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-20 10:48                     ` Erik Faye-Lund
@ 2011-05-20 17:18                       ` Junio C Hamano
  2011-05-20 17:26                         ` Erik Faye-Lund
  0 siblings, 1 reply; 19+ messages in thread
From: Junio C Hamano @ 2011-05-20 17:18 UTC (permalink / raw)
  To: kusmabite; +Cc: Rafael Gieschke, Git Mailing List, Johannes Schindelin

Erik Faye-Lund <kusmabite@gmail.com> writes:

> Actually, I'm thinking that we should avoid ever using getpass:

Good thinking.

> Instead,
> we should make our own function (based on your most recent patch?)
> that fills a caller-specified strbuf instead (git_getpass already have
> a static strbuf that we can fill).

Heh, I thought you earlier felt "a bit pointless" to "a properly
abstracted common version" I outlined earlier in the thread ;-)

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH] compat: add a getpass() compatibility function
  2011-05-20 17:18                       ` Junio C Hamano
@ 2011-05-20 17:26                         ` Erik Faye-Lund
  0 siblings, 0 replies; 19+ messages in thread
From: Erik Faye-Lund @ 2011-05-20 17:26 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Rafael Gieschke, Git Mailing List, Johannes Schindelin

On Fri, May 20, 2011 at 7:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Erik Faye-Lund <kusmabite@gmail.com> writes:
>> Instead,
>> we should make our own function (based on your most recent patch?)
>> that fills a caller-specified strbuf instead (git_getpass already have
>> a static strbuf that we can fill).
>
> Heh, I thought you earlier felt "a bit pointless" to "a properly
> abstracted common version" I outlined earlier in the thread ;-)

Well, if we're going to change git_getpass to not use getpass, then we
need to do something; the mingw-version is a getpass-interface.

Sure, we could continue to use the getpass-interface for the
POSIX-version, but it feels silly to limit the password-length when we
could just pass in that strbuf that is already there (for the
GIT_GETPASS-case). The Windows-version still should be fixed to avoid
the leak that is already there - passing the strbuf in from the caller
would solve that.

I'm fine with just having two implementations, one for POSIX and one
for Windows. In fact, that's probably the right thing to do; my
experiment lead to more lines of code, not less.

My patches were more of an experiment than a proposal :)

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2011-05-20 17:27 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 11:37 [PATCH] compat: add a getpass() compatibility function Rafael Gieschke
2011-05-19 12:17 ` Erik Faye-Lund
2011-05-19 16:30   ` Junio C Hamano
2011-05-19 17:01   ` Rafael Gieschke
2011-05-19 17:27     ` Junio C Hamano
2011-05-19 18:07       ` Erik Faye-Lund
2011-05-19 19:16         ` Rafael Gieschke
2011-05-19 19:19           ` Erik Faye-Lund
2011-05-19 19:42             ` Rafael Gieschke
2011-05-19 20:12               ` Erik Faye-Lund
2011-05-19 21:16                 ` Erik Faye-Lund
2011-05-20 10:06                   ` Rafael Gieschke
2011-05-20 10:48                     ` Erik Faye-Lund
2011-05-20 17:18                       ` Junio C Hamano
2011-05-20 17:26                         ` Erik Faye-Lund
2011-05-19 12:21 ` Erik Faye-Lund
2011-05-19 15:14   ` Jonathan Nieder
2011-05-19 15:29     ` Erik Faye-Lund
2011-05-19 17:17     ` Junio C Hamano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.