From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933078Ab1ESMxh (ORCPT ); Thu, 19 May 2011 08:53:37 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:50749 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932433Ab1ESMxg convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2011 08:53:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=etXJxene0oiCMSB2P5iXy0vewG2PPH7jot0ZsD8HRYZ3hv+BoMtYQOSQy06Sc1P99O AoDovwrpfMP9QkdaYPt/T5ODGAqKN4rK5ceZ6nQ2OwOpla1q76ZZhfQuFzJJ0XJF++TE T4X5OQqNGx1sUGyvWuuW1NhPzIT17dnnBUn2A= MIME-Version: 1.0 In-Reply-To: <20110519104330.GA25179@zod.rchland.ibm.com> References: <1305753895-24845-1-git-send-email-ericvh@gmail.com> <1305753895-24845-4-git-send-email-ericvh@gmail.com> <20110519104330.GA25179@zod.rchland.ibm.com> Date: Thu, 19 May 2011 07:53:34 -0500 Message-ID: Subject: Re: [PATCH 4/7] [RFC] enable L1_WRITETHROUGH mode for BG/P From: Eric Van Hensbergen To: Josh Boyer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bg-linux@lists.anl-external.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2011 at 5:43 AM, Josh Boyer wrote: > On Wed, May 18, 2011 at 04:24:52PM -0500, Eric Van Hensbergen wrote: >> >>+config L1_WRITETHROUGH >>+      bool "Blue Gene/P enabled writethrough mode" >>+      depends on BGP >>+      default y > > You add this config option here, named generically, but then make it > depend on BGP.  It sees it should be named BGP_L1_WRITETHROUGH, and then > just selected by the BGP platform.  But then.... > >> endmenu >>diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype >>index 111138c..3a3c711 100644 >>--- a/arch/powerpc/platforms/Kconfig.cputype >>+++ b/arch/powerpc/platforms/Kconfig.cputype >>@@ -329,9 +329,13 @@ config NOT_COHERENT_CACHE >>       bool >>       depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON >>       default n if PPC_47x >>+      default n if BGP >>       default y >> >> config CHECK_CACHE_COHERENCY >>       bool >> >>+config L1_WRITETHROUGH >>+      bool > > You add an identical option down here.  Confused. > Yeah, this was copied from the original patches and it confused me as well, but I had never modified Kconfig.cputype before so I wasn't sure if there were some weird rules. I'm happy to remove the vestigial one and make the changes you suggest to make the naming BGP specific. -eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f51.google.com (mail-bw0-f51.google.com [209.85.214.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 90DB01007D5 for ; Thu, 19 May 2011 22:53:39 +1000 (EST) Received: by bwz10 with SMTP id 10so2630943bwz.38 for ; Thu, 19 May 2011 05:53:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110519104330.GA25179@zod.rchland.ibm.com> References: <1305753895-24845-1-git-send-email-ericvh@gmail.com> <1305753895-24845-4-git-send-email-ericvh@gmail.com> <20110519104330.GA25179@zod.rchland.ibm.com> Date: Thu, 19 May 2011 07:53:34 -0500 Message-ID: Subject: Re: [PATCH 4/7] [RFC] enable L1_WRITETHROUGH mode for BG/P From: Eric Van Hensbergen To: Josh Boyer Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, bg-linux@lists.anl-external.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 19, 2011 at 5:43 AM, Josh Boyer wr= ote: > On Wed, May 18, 2011 at 04:24:52PM -0500, Eric Van Hensbergen wrote: >> >>+config L1_WRITETHROUGH >>+ =A0 =A0 =A0bool "Blue Gene/P enabled writethrough mode" >>+ =A0 =A0 =A0depends on BGP >>+ =A0 =A0 =A0default y > > You add this config option here, named generically, but then make it > depend on BGP. =A0It sees it should be named BGP_L1_WRITETHROUGH, and the= n > just selected by the BGP platform. =A0But then.... > >> endmenu >>diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platfo= rms/Kconfig.cputype >>index 111138c..3a3c711 100644 >>--- a/arch/powerpc/platforms/Kconfig.cputype >>+++ b/arch/powerpc/platforms/Kconfig.cputype >>@@ -329,9 +329,13 @@ config NOT_COHERENT_CACHE >> =A0 =A0 =A0 bool >> =A0 =A0 =A0 depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COM= MON >> =A0 =A0 =A0 default n if PPC_47x >>+ =A0 =A0 =A0default n if BGP >> =A0 =A0 =A0 default y >> >> config CHECK_CACHE_COHERENCY >> =A0 =A0 =A0 bool >> >>+config L1_WRITETHROUGH >>+ =A0 =A0 =A0bool > > You add an identical option down here. =A0Confused. > Yeah, this was copied from the original patches and it confused me as well, but I had never modified Kconfig.cputype before so I wasn't sure if there were some weird rules. I'm happy to remove the vestigial one and make the changes you suggest to make the naming BGP specific. -eric