From mboxrd@z Thu Jan  1 00:00:00 1970
From: Graeme Russ <graeme.russ@gmail.com>
Date: Wed, 29 Jun 2011 14:36:26 +1000
Subject: [U-Boot] [PATCH v1 (WIP) 08/16] [Timer]Create new userland
	timer API
In-Reply-To: <CAPnjgZ2e42WeZdH3moKO+EfP0f7huo-Kjsg7Rz0SqyAHFjTQAg@mail.gmail.com>
References: <1309261269-4363-1-git-send-email-graeme.russ@gmail.com>
	<1309261269-4363-9-git-send-email-graeme.russ@gmail.com>
	<CAPnjgZ2e42WeZdH3moKO+EfP0f7huo-Kjsg7Rz0SqyAHFjTQAg@mail.gmail.com>
Message-ID: <BANLkTinz2vriE2+1rqLDGMg9Hf=rtHf_ug@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Wed, Jun 29, 2011 at 2:31 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Graeme,
>
> What a mammoth effort and what a fantastic clean up.
>
> I'm a bit unsure of this patch which seems to have two prototypes for
> the since functions:
>

[snip]

>> +u32 time_now_ms(void);
>> +u32 time_since_ms(u32 from, u32 to);
>> +u32 time_max_since_ms(u32 from, u32 to);
>
> Here they have two parameters
>

[snip]

>> +
>> +u32 time_since_ms(u32 from)
>
> and here only one (which is what I expect).
>
> Can you please explain what I am missing?

The fact I haven't tried to build it yet ;)

I'll add that to the list of fixes for v2 - Thanks

Regards,

Graeme