From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758AbcI2LFJ convert rfc822-to-8bit (ORCPT ); Thu, 29 Sep 2016 07:05:09 -0400 Received: from 212-186-180-163.static.upcbusiness.at ([212.186.180.163]:47914 "EHLO cgate.sperl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbcI2LFA (ORCPT ); Thu, 29 Sep 2016 07:05:00 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors From: Martin Sperl In-Reply-To: <1475085056-5205-4-git-send-email-noralf@tronnes.org> Date: Thu, 29 Sep 2016 13:05:01 +0200 Cc: wsa@the-dreams.de, Stephen Warren , Eric Anholt , linux-rpi-kernel , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1475085056-5205-1-git-send-email-noralf@tronnes.org> <1475085056-5205-4-git-send-email-noralf@tronnes.org> To: =?utf-8?Q?Noralf_Tr=C3=B8nnes?= X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.09.2016, at 19:50, Noralf Trønnes wrote: > > Writing to an AT24C32 generates on average 2x i2c transfer errors per > 32-byte page write. Which amounts to a lot for a 4k write. This is due > to the fact that the chip doesn't respond during it's internal write > cycle when the at24 driver tries and retries the next write. > Only a handful drivers use dev_err() on transfer error, so switch to > dev_dbg() instead. > > Signed-off-by: Noralf Trønnes Reviewed-by: Martin Sperl From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin@sperl.org (Martin Sperl) Date: Thu, 29 Sep 2016 13:05:01 +0200 Subject: [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors In-Reply-To: <1475085056-5205-4-git-send-email-noralf@tronnes.org> References: <1475085056-5205-1-git-send-email-noralf@tronnes.org> <1475085056-5205-4-git-send-email-noralf@tronnes.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28.09.2016, at 19:50, Noralf Tr?nnes wrote: > > Writing to an AT24C32 generates on average 2x i2c transfer errors per > 32-byte page write. Which amounts to a lot for a 4k write. This is due > to the fact that the chip doesn't respond during it's internal write > cycle when the at24 driver tries and retries the next write. > Only a handful drivers use dev_err() on transfer error, so switch to > dev_dbg() instead. > > Signed-off-by: Noralf Tr?nnes Reviewed-by: Martin Sperl