From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guy Harris Subject: Re: [RFC] 0-length PPDU reporting Date: Tue, 19 Jun 2018 15:50:02 -0700 Message-ID: References: <1529332670.3490.50.camel@sipsolutions.net> <00986C20-9443-40FC-9A7E-DE636A743951@superduper.net> <1529349637.3092.8.camel@sipsolutions.net> <3028EC8F-6CFD-4F52-8349-D49B1F37AC22@alum.mit.edu> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <3028EC8F-6CFD-4F52-8349-D49B1F37AC22-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> Sender: radiotap-owner-sUITvd46vNxg9hUCZPvPmw@public.gmane.org List-Unsubscribe: To: Johannes Berg Cc: Simon Barber , radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org List-Id: radiotap@radiotap.org On Jun 19, 2018, at 2:20 PM, Guy Harris wrote: > On Jun 18, 2018, at 12:20 PM, Johannes Berg = wrote: >=20 >> A wireshark patch should be pretty simple, just don't call through to >> the 802.11 dissector? >=20 > Yes, although if it has radio information you should call through to = the "802.11 radio" dissector (so that it shows the radio information in = a pseudo-header-independent format) and pass along information to let it = know that *it* shouldn't call through to the 802.11 frame dissector. Tcpdump would also need to be changed not to call ieee802_11_print() at = the end of ieee802_11_radio_print() in print-802_11.c - just return = "len" for 0-length PPDUs.