From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 285E0C43217 for ; Wed, 11 May 2022 14:41:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.327001.549694 (Exim 4.92) (envelope-from ) id 1nonWe-0000jB-Ik; Wed, 11 May 2022 14:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327001.549694; Wed, 11 May 2022 14:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWe-0000j4-Ey; Wed, 11 May 2022 14:41:16 +0000 Received: by outflank-mailman (input) for mailman id 327001; Wed, 11 May 2022 14:41:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWd-0000iw-0l for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:41:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1b::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6823e8be-d138-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:41:14 +0200 (CEST) Received: from AS9PR06CA0543.eurprd06.prod.outlook.com (2603:10a6:20b:485::6) by AS8PR08MB7012.eurprd08.prod.outlook.com (2603:10a6:20b:34f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 14:41:12 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:485:cafe::3a) by AS9PR06CA0543.outlook.office365.com (2603:10a6:20b:485::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:11 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 11 May 2022 14:41:10 +0000 Received: from a1ebac394442.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CC68837E-7FDB-435F-B279-3D3844203F0B.1; Wed, 11 May 2022 14:41:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a1ebac394442.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:41:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4391.eurprd08.prod.outlook.com (2603:10a6:20b:73::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 14:41:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:41:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6823e8be-d138-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RwlnS9lZjTMdKRWW+lmIMCfpUGGa6crnU8toIjoToD3qFfGT5uoYUWUJopxOmuKYXwc1JDocihQYNLSNKA6hBBcgPxkGsOiKlyEblvQ95QozruUwNSS4Kf77DAz0Mn0vgENmhG7WOk6rOqvG8EHTMwh1PK5iUArT57s8smAXFlgnj1nXq65Rl463tFPeP5uw2rWAM5Ly44UJjNAnArHDsVG5tfPAoB1bk5B48vmQUj+etDG9i4TapLzgZh/pUrj2JyGJlEmqXDZc1JUFAeJLUoX6JdOMaqKhGsGO+hKEWJqck2+2QLXaRCW0ktpSgGH0xjEPQC0+boTl7u4B3I/5lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=CBEyz1K5GbD+cSBLU04t0mkvK3qSnC6waOiQ7bnywhMlGkNMz02WziTY3P4n/QE6Vb8cLHfOSuWAPU3afGuBt5XmlKTbuVsemyNpE1Nzsp7rd1mh6Pm9MH6KabaCHKKHFEDn+7LEY51cKZQKThXAY4wDO8l4Cpnz+Apwq/3hDtSkWd4Ty6Sw2VL05hY26GaKcZlrE1MUS2XRfUUo0Fm046MUcginZZbnBN7RmMqHVw8On0ZJtqKUB2KWWNSMdJqHa3i1lmqSMyohpOLCvlnRI6aN7xi2SmOtKwfE3SzZi/3aZBfdulrj3iF8ro98IRnoBWkV++zB5KGMnE1jeE8sug== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=AYGo7gMfUeeQbv494TL9izexPczy+9WvFM7UvNTjU2J0rk4UBJQyeN7+qZfqIO/fKwknST55EyB3rf7twzhb3ZFPkAj/w+ZiyJ1SGJFVdTGlDo4kuDZOogNN7dI0ImYDLbzTBzPrgT7zBLy1H4PANrEM39q1RmpdhSDhX3ClL6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 9af7d9cd5fbeda94 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGdcTJ0qha+Cawd2DGnqP3WOqsP3yMBzYxTDCZqUyWC21nM9R5r4OPo7uPBfaMVBKO0SgZXRPXNNq1zmDVguUCmcNXZrCxgqfAxRXL+fm4nOeoJuYe4vOiDshWT/DbNaSW6oEgE91nomxg/R/XBV8WTTSj/ZTGhcovtcKSKaGqRFJyo0GAl6cUaRVGCiR2GVL+TR0j86pNF2Uxj1NpUZFwErQGmTZvtKn0oPSZAlzytc64vTEovfbcVSHzyjDFq73irmr2hPL5N7TdVGO+Yvy3etjgOHyw3lTnYYZmvYneC0CRWs5EYBEcXsUsQs/ZhMjcUY8j9r8UgoocvrPAOFhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=bRz8CvWgDIsgCUBILbwygqqvkEzVQ1zVlHeTZTsGREk9HbNxB2u4MwyIiBM9KeE3qA5SQcd3UYRGO7prxR6zoZ1omkIKjtWrHc/9E2w8fM2pV1lnD9BkvR4xjc+4/FO323L1WBO4y7wNhCWc60LgBtvcGxswONQBPLVpFiF8Miujav/snwE21pRYBrV71H7Z6mChsAs8A7oJoAmGAkp3cZ7bItxGjJengsOGjrWL5+BHeDap0bSxmugo6uMEy/OIqVnvDX21yTY5QhlFPEt/yT1NT30/c9JshHeXijRg6LnYSm9PMkuHghp8RR8QcNaKvYJ+gjDZTz6IUcVP7EQEvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=AYGo7gMfUeeQbv494TL9izexPczy+9WvFM7UvNTjU2J0rk4UBJQyeN7+qZfqIO/fKwknST55EyB3rf7twzhb3ZFPkAj/w+ZiyJ1SGJFVdTGlDo4kuDZOogNN7dI0ImYDLbzTBzPrgT7zBLy1H4PANrEM39q1RmpdhSDhX3ClL6c= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduA Date: Wed, 11 May 2022 14:41:02 +0000 Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 32cd3fa0-92e4-4d8a-99fb-08da335c4acc x-ms-traffictypediagnostic: AM6PR08MB4391:EE_|VE1EUR03FT022:EE_|AS8PR08MB7012:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rmyE8PgMG0rdiXZfZMgYs/zbHf3NrHkhoqEUfh/j9yagfU9TQsWNJ6YWcfukA3J6nr+9zp7PDx35O8IHCg6sMCckp2n/3pu38F2N9ydbpJkCfj6FrhunUJkuwVaB1FQ8+VEJd4HZ6QSbZZmVtBafC077pgOR10UOiO91Df0xvmBTQ2UGvmoEhh4B0uTJzxLJoeCvgwcVvKhsd9OXXbHeVTnGPdJFDlbteaLmAohqbb9TmfzN9UxxEgQCuLBy9MBW6wZh0igmt0l6qeoiTTImIT1YRIYWC7XWlYUNEP912X4GvIi6br8jKqaGk4uTj7NkLXzZW6gP+LEnxwxFa3kIau/XRRphI3IEiCGANwA0tVnO6V+UsUyPnZduH5fSwooje6PEp3a/f0vFfcPckNpm2LpL7Nz+Y/J++mw/fGqGLzqGwurjrL2oc0Ih6wKlRN81rVAY8bi+bz4QOxmahcDLcxA1oHh4MDcbsl0Yi79zw7ns0+zE6t+eJ59o3bHmhQgVE0sJoYkEqBTvL4aIchN0eooeEZOcXQABLt9F0Xuuf5q16RPl7pM5iECdlt/6FqVn8gfWZNB8m7wTn+kuHIRM9r7iNmi7RYzIHRZiWgQY+6XxgmqdDY3Z5buifOhon3neEo0L694CnT8ndrtujEVGhWgVTJlzW1i0b+hpM2+m9G7ITzpnjrs9UUjN1S4fFSZGQQu05iEU/yJZ3HGmjeBsIoVic3y1WpOLEsu/6E202Ireqre1r7xO+Eq7TtdMTMBh X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(36756003)(2906002)(38070700005)(38100700002)(8936002)(5660300002)(186003)(508600001)(33656002)(66946007)(8676002)(91956017)(2616005)(66556008)(64756008)(66446008)(66476007)(76116006)(83380400001)(316002)(54906003)(53546011)(6916009)(6506007)(6486002)(6512007)(26005)(71200400001)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <39DC5A6C76B87B4CBBD8DCF379A8692B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4391 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99ef6ae9-41a5-46ea-ff95-08da335c4570 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ba1//UXGNr1edcec/EexpLH+KonBJQdGghPQ0/BbvEf2yU4HsBg+gqNoEKxJ2g4HkksjRBdz3mELxUXg07i5RhY/GnVjKDxvCnaapfSmtNjhX5UvoS5+XLgomowh8MI/sex2V22UtREKVDl+f2yr0hDm9CwpAjgEotDn8CVO3XNrLVzQfylb+6dHhYEEmfO9UrCfDa3OLbiYEARS0o6vwapqLJ3CvxgAe/IMMAPNwmtzUpPOsHhA9j2cXiD/GZ7gfFEh5azorhFkaMzhkahn0OeuwehzqpBlwYkSeX1KbZB07W/nhPLw35Ws9Xj2MmZcz7dXM1jIyYnpNrIR22mD17L72oSjF2UutZFnWg5DLTE1gp1j6PrtOAoI31HXgWxIwKN5nKRA/RIb8LkXP9lY8TQli1JwLVgCPvrfKCVjo3MKpKCEbryXqmuiEM/XWuCPA6yH49W4AAZ7vi6CwRRygRraf5JSGJYm1c8lMUD81OeNqiG4UeHH3ywBLQqDGJmzEhsMPh13IZw3YpSbkGtaoUb2H+GglTZgFRwf8rcRbNi4kMm2U7XmwG1v0IfLg0N1Kqznn40Y1k2FruU4GQwXLlxbE/irdWd+WKuX17PxET3KFBS257Vg+MTrQQJFLGJTZkkgn1JEnGqVJaNNKk/3aQ+beyH7tAwFV2zzhFaJ9AeG8YH02k/ryvzDI5FxnIGT X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(336012)(186003)(81166007)(356005)(83380400001)(316002)(2906002)(47076005)(36860700001)(8936002)(36756003)(5660300002)(33656002)(6486002)(82310400005)(54906003)(70586007)(70206006)(6862004)(2616005)(53546011)(6506007)(26005)(6512007)(4326008)(8676002)(40460700003)(508600001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:41:11.0183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32cd3fa0-92e4-4d8a-99fb-08da335c4acc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7012 > On 10 May 2022, at 03:03, Stefano Stabellini wro= te: >=20 > On Wed, 4 May 2022, Julien Grall wrote: >>> Do I understand right that it is ok for you if I push one patch mention= ing >>> all the commits done in Linux corresponding to the changes (instead of = one >>> patch per commit) ? >>=20 >> For this case yes. >=20 > I managed to do a review of the patch by doing a diff of the relevant > portion of Xen cpufeature.c with Linux cpufeature.c (from commit > b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux > sysregs.h (diff -E -b -u). >=20 > Everything checks out. >=20 > In my opinion, this patch should be split in 2 patches: the changes to > cpufeature.c and sysregs.c that come from the Linux sources; and the > updates to cpufeature.h that do not. If you do that you can add my > reviewed-by to the first patch with the changes from Linux. >=20 > The list of individual commit IDs would be nice, but thanksfully the two > source files are still "diffable" so in my opinion are not required. I agree with that. Julien: Do you agree if I just put the changes to cpufeature.h in a separat= e patch ? I started to list the commit IDs corresponding to the changes in Linux and = this would end up with 5 or more which I do not think would be that useful as the diff= can be easily done as Stefano mentioned. >=20 > I have a couple of comments on the changes to cpufeature.h (the ones not > from Linux) which I'll reply directly to the patch. I will answer to them. Cheers Bertrand=