From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 85D3DDDD0B for ; Sat, 17 Feb 2007 07:25:01 +1100 (EST) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01C75208.8316573B" Subject: MPC85xx git branch - problem with Marvel SATA driver... Date: Fri, 16 Feb 2007 15:25:10 -0500 Message-ID: From: "Morrison, Tom" To: Cc: Geary Sean-R60898 , Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. ------_=_NextPart_001_01C75208.8316573B Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am looking for ideas here about a problem I am having. =20 I am working with a new git branch that is supposed to PCI Express on the CDS. =20 I have a MPC8548E CDS system plugged into an Arcadia motherboard. I=20 have a PCI Marvel Sata Card plugged into the same Arcadia mother board. =20 The driver works flawless when there is NO actual SATA Drive plugged into this card (the sata_mv driver recognizes and enumerates the ports on marvel card).=20 =20 The problem comes when I plug a SATA drive into one of the SATA ports on this card. When I boot the kernel after doing this and as the sata/ata driver starts probing the Sata card/jport for devices - it jumps off to 'never never land' (never returns from the=20 second write flush of the control register (writing 0x301 to SCR_CONTROL (and=20 reading it back) and then writing 0x300 to same register - it never actually returns from the writefl of that 0x300 value to the SCR_Control. =20 =20 FWIW, I have cross ported this driver (and its slightly different ata infrastructure to a x86 platform (running a 2.6.19.x kernel) and it does work in that environment . Further,=20 I have cross ported the original working 2.6.19.1 driver to this git branch - and it fails=20 in exactly the same spot. =20 It smells that there is some type of interrupt / configuration mismatch for the PCI bus for the=20 CDS that is executed upon this probe sequence of a valid SATA/ATA Port? =20 Has anyone experienced this problem themselves? What can I do? Thanks in advance=20 for all of your support! Tom Morrison Principal Software Engineer EMPIRIX=20 20 Crosby Drive - Bedford, MA 01730 p: 781.266.3567 f: 781.266.3670=20 email: tmorrison@empirix.com =20 www.empirix.com =20 =20 ------_=_NextPart_001_01C75208.8316573B Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I am looking for ideas here about a problem I am = having.

I am working with a new git branch that is supposed = to PCI Express on the CDS.

I have a MPC8548E CDS system plugged into an = Arcadia = motherboard. I

have a PCI Marvel Sata Card plugged into the same = Arcadia mother = board.

The driver works flawless when there is NO actual = SATA = Drive plugged into

this card (the sata_mv driver recognizes and = enumerates the ports on marvel card).

The problem comes when I plug a SATA drive into one = of the SATA ports on this card.

When I boot the kernel after doing this and as the = sata/ata driver starts probing the

Sata card/jport for devices – it jumps off to = ‘never never land’ (never returns from the

second write flush of the control register (writing = 0x301 to SCR_CONTROL (and

reading it back) and then writing 0x300 to same register – it never actually returns

from the writefl of that 0x300 value to the SCR_Control.

FWIW, I have cross ported this driver (and its = slightly different ata infrastructure to a

x86 platform (running a 2.6.19.x kernel) and it does = work in that environment . Further,

I have cross ported the original working 2.6.19.1 = driver to this git branch – and it fails

in exactly the same = spot.

It smells that there is some type of interrupt / configuration mismatch for the PCI bus for the =

CDS that is executed upon this probe sequence of a = valid SATA/ATA Port?

Has anyone experienced this problem themselves? What = can I do? Thanks in advance

for all of your support!

Tom Morrison
Principal = Software Engineer

EMPIRIX<= /font>
20 Crosby = Drive = - Bedford, MA 01730=
p: 781.266.3567 f: 781.266.3670 =
email:<= /font> tmorrison@empirix.com=
www.empirix.com

------_=_NextPart_001_01C75208.8316573B-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw02.freescale.net (de01egw02.freescale.net [192.88.165.103]) by ozlabs.org (Postfix) with ESMTP id B8675DDD0D for ; Sat, 17 Feb 2007 07:43:25 +1100 (EST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: From: Andy Fleming Subject: Re: MPC85xx git branch - problem with Marvel SATA driver... Date: Fri, 16 Feb 2007 14:43:16 -0600 To: "Morrison, Tom" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 16, 2007, at 14:25, Morrison, Tom wrote: > It smells that there is some type of interrupt / configuration > mismatch for the PCI bus for the > > CDS that is executed upon this probe sequence of a valid SATA/ATA > Port? Which slot is the CDS carrier card in, and which slot is the SATA card in. And what interrupt is it trying to register for? More importantly, what version of u-boot are you running on the board, and what versions of the Carrier Card and Arcadia are you using? U-Boot rearranges the interrupt-map for PCI based on the slot the CDS Carrier Card is in (which has to be set by a switch on the card). The code in the tree on opensource.freescale.com only works on the 3.1 Arcadia (assuming you also used the DTS that came with it). Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 07094DDDFF for ; Sat, 17 Feb 2007 09:02:51 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: RE: MPC85xx git branch - problem with Marvel SATA driver... Date: Fri, 16 Feb 2007 17:02:50 -0500 Message-ID: In-Reply-To: References:

From: "Morrison, Tom" To: "Andy Fleming" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Andy, CDS is in slot #2, marvel sata card is in Slot #5 I am using the new u-boot git branch from freescale for=20 the MPC85xx_cds. I was told to use this with the new=20 software - which is also using the device tree as well... Can't tell what version of Arcadia board - where is this located? All switches on all boards (mother/carrier/cds) are believed to be in default position as referenced in the cds manual: mpc8548_cds_reference.pdf We haven't done any rocket science here! Tom -----Original Message----- From: Andy Fleming [mailto:afleming@freescale.com]=20 Sent: Friday, February 16, 2007 3:43 PM To: Morrison, Tom Cc: linuxppc-dev@ozlabs.org; Geary Sean-R60898; Zhang Wei-r63237 Subject: Re: MPC85xx git branch - problem with Marvel SATA driver... On Feb 16, 2007, at 14:25, Morrison, Tom wrote: > It smells that there is some type of interrupt / configuration =20 > mismatch for the PCI bus for the > > CDS that is executed upon this probe sequence of a valid SATA/ATA =20 > Port? Which slot is the CDS carrier card in, and which slot is the SATA =20 card in. And what interrupt is it trying to register for? More importantly, what version of u-boot are you running on the =20 board, and what versions of the Carrier Card and Arcadia are you =20 using? U-Boot rearranges the interrupt-map for PCI based on the slot =20 the CDS Carrier Card is in (which has to be set by a switch on the =20 card). The code in the tree on opensource.freescale.com only works on the =20 3.1 Arcadia (assuming you also used the DTS that came with it). Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw01.freescale.net (de01egw01.freescale.net [192.88.165.102]) by ozlabs.org (Postfix) with ESMTP id 33186DDDF3 for ; Wed, 21 Feb 2007 06:41:26 +1100 (EST) In-Reply-To: References:

Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> From: Andy Fleming Subject: Re: MPC85xx git branch - problem with Marvel SATA driver... Date: Tue, 20 Feb 2007 13:41:16 -0600 To: "Morrison, Tom" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 16, 2007, at 16:02, Morrison, Tom wrote: > Andy, > > CDS is in slot #2, marvel sata card is in Slot #5 > > I am using the new u-boot git branch from freescale for > the MPC85xx_cds. I was told to use this with the new > software - which is also using the device tree as well... > > Can't tell what version of Arcadia board - where is this located? Sorry for the delay. I wasn't quite sure how to find that information. However, back channels have indicated you may be using a 3.0 Arcadia. In that case, you need to use the dts in arch/powerpc/ boot/dts/mpc8548cds_legacy.dts. It's not a very useful name (sorry), but that's what it's called internally right now. The interrupt maps for 3.0 and 3.1 PCI are different, and that would explain your problem, I hope. Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 9433FDDDF7 for ; Wed, 21 Feb 2007 07:59:07 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: RE: MPC85xx git branch - problem with Marvel SATA driver... Date: Tue, 20 Feb 2007 15:58:57 -0500 Message-ID: In-Reply-To: <8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> From: "Morrison, Tom" To: "Andy Fleming" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Will try this out and let you know! t -----Original Message----- From: Andy Fleming [mailto:afleming@freescale.com]=20 Sent: Tuesday, February 20, 2007 2:41 PM To: Morrison, Tom Cc: linuxppc-dev@ozlabs.org; Geary Sean-R60898; Zhang Wei-r63237 Subject: Re: MPC85xx git branch - problem with Marvel SATA driver... On Feb 16, 2007, at 16:02, Morrison, Tom wrote: > Andy, > > CDS is in slot #2, marvel sata card is in Slot #5 > > I am using the new u-boot git branch from freescale for > the MPC85xx_cds. I was told to use this with the new > software - which is also using the device tree as well... > > Can't tell what version of Arcadia board - where is this located? Sorry for the delay. I wasn't quite sure how to find that =20 information. However, back channels have indicated you may be using =20 a 3.0 Arcadia. In that case, you need to use the dts in arch/powerpc/=20 boot/dts/mpc8548cds_legacy.dts. It's not a very useful name (sorry), =20 but that's what it's called internally right now. The interrupt maps =20 for 3.0 and 3.1 PCI are different, and that would explain your =20 problem, I hope. Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 5351BDDEC2 for ; Sat, 24 Feb 2007 06:57:47 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Date: Fri, 23 Feb 2007 14:57:38 -0500 Message-ID: In-Reply-To: <8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> From: "Morrison, Tom" To: "Andy Fleming" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , All, I have yet to successfully gone through full initialization /=20 registration of this driver for this board. I have both a Marvell PCI SATA Card (with 6042 chip)=20 and a Marvell PCI Express SATA card (with 7042 chip). PCI/6042 Chip Marvel SATA Card =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D On PCI Bus - the card is probed, and finds the SATA drive -=20 goes through an ata add device process - up to adding scsi device - even goes all the way to checking the file system -and lastly says: SCSI device sda: write cache: enabled, read cache: enabled,=20 sda: unknown partition table sd 0:0:0:0: Attached scsi disk sda After full boot (I am nfs mounting my root file system until I get this working), I try to mount drive - no good - I can't mount it (it also doesn't create a /dev/sda or /dev/sda1 device - I assume=20 that if it knew the partitioning table - it would actually create these devices and Yes, I have ms-dos file system support compiled in? Is there anything else that=20 PCI Express/7042 Marvell Sata Card: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D On PCI Express Bus - it never performs the probe - even though the bus was scanned and device was found ("lspci" shows this device) FYI, I tried the PCI Express SATA Card in an X86 running Fedora Core 6 (2.6.19.1-2xxx) and this seemingly is the same behavior on this platform? Are there other things I need to configure or initialize to=20 allow the to recognize/probe the SATA drive on the PCI Express bus? Or there has to be other PCI Express SATA Cards out there that Do NOT have this problem? How do they get around this? Am I really missing something here or just going crazy? Thank you for all your suggestions!!! Sincerely, Tom Morrison Principal Software Engineer EMPIRIX=20 20 Crosby Drive - Bedford, MA 01730 p: 781.266.3567 f: 781.266.3670=20 email: tmorrison@empirix.com=20 www.empirix.comz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id 62D57DDF0D for ; Sat, 24 Feb 2007 07:19:08 +1100 (EST) Date: Fri, 23 Feb 2007 14:29:21 -0600 To: "Morrison, Tom" Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Message-ID: <20070223202921.GA22331@lixom.net> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: From: olof@lixom.net (Olof Johansson) Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Feb 23, 2007 at 02:57:38PM -0500, Morrison, Tom wrote: > PCI Express/7042 Marvell Sata Card: > =================================== > On PCI Express Bus - it never performs the probe - even though > the bus was scanned and device was found ("lspci" shows this device) > > FYI, I tried the PCI Express SATA Card in an X86 running Fedora > Core 6 (2.6.19.1-2xxx) and this seemingly is the same behavior > on this platform? A patch went into 2.6.20 quite late to add the PCI ids for at least one 7042 controller (Highpoint). You might have to add the ids of your controller as well. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id C91FDDDEC9 for ; Sat, 24 Feb 2007 09:47:29 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Subject: RE: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Date: Fri, 23 Feb 2007 17:47:22 -0500 Message-ID: References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <20070223202921.GA22331@lixom.net> From: "Morrison, Tom" To: "Olof Johansson" Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Olof, Are you saying that it must 'know' about the PCI id(s) for this SATA card before it even probes that device??? Even though the module is compiled into the kernel and=20 I've verified that: a) the pci scan bus has detected this device b) that the sata_mv driver is registering itself as a PCI Device driver? ???? Also, fyi, its also complaining about the PCI Express=20 Root Bridge on the MPC8548 as an unknown device... manufacturer: 0x1957 (aka: Freescale) class: 0xFFFF although that doesn't explain why the same PCI=20 Express SATA card / ~same sata_mv driver on an=20 Intel X86 platform doesn't get recognized either. Thank you for any additional insight you have on this Olof! Tom -----Original Message----- From: Olof Johansson [mailto:olof@lixom.net] Sent: Fri 2/23/2007 3:29 PM To: Morrison, Tom Cc: Andy Fleming; Geary Sean-R60898; linuxppc-dev@ozlabs.org; Zhang = Wei-r63237 Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with = Marvel SATA driver... =20 On Fri, Feb 23, 2007 at 02:57:38PM -0500, Morrison, Tom wrote: > PCI Express/7042 Marvell Sata Card: > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > On PCI Express Bus - it never performs the probe - even though > the bus was scanned and device was found ("lspci" shows this = device) >=20 > FYI, I tried the PCI Express SATA Card in an X86 running Fedora > Core 6 (2.6.19.1-2xxx) and this seemingly is the same behavior > on this platform? A patch went into 2.6.20 quite late to add the PCI ids for at least one 7042 controller (Highpoint). You might have to add the ids of your controller as well. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id A02DDDDE23 for ; Sat, 24 Feb 2007 14:06:31 +1100 (EST) Date: Fri, 23 Feb 2007 21:16:49 -0600 To: "Morrison, Tom" Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Message-ID: <20070224031649.GA26751@lixom.net> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <20070223202921.GA22331@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: From: olof@lixom.net (Olof Johansson) Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Feb 23, 2007 at 05:47:22PM -0500, Morrison, Tom wrote: > Olof, > > Are you saying that it must 'know' about the PCI id(s) > for this SATA card before it even probes that device??? > > Even though the module is compiled into the kernel and > I've verified that: > > a) the pci scan bus has detected this device > b) that the sata_mv driver is registering itself > as a PCI Device driver? Yes. There's the device on the bus, and there's the PCI bus code that will walk all busses and enumerate all devices. Then there's the driver. All drivers have a small table that they use to specify which PCI devices they are usable with, so if the device isn't listed, the driver won't get involved. See the sata_mv sources for more info, search for '7042' and you'll find the table, at least if you're looking at the 2.6.20 sources. > Also, fyi, its also complaining about the PCI Express > Root Bridge on the MPC8548 as an unknown device... > > manufacturer: 0x1957 (aka: Freescale) > class: 0xFFFF What complains? lspci? Or the kernel? lspci is just a high-level program that has a database that maps the numerical codes to manufacturers and devices. The database might be out of date, or someone forgot to submit the device IDs to it. It happens all the time. > although that doesn't explain why the same PCI > Express SATA card / ~same sata_mv driver on an > Intel X86 platform doesn't get recognized either. Same thing -- PCI id missing from the driver. > Thank you for any additional insight you have on this Olof! -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 81372DDDEC for ; Sat, 24 Feb 2007 19:25:19 +1100 (EST) Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... From: Benjamin Herrenschmidt To: "Morrison, Tom" In-Reply-To: References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> Content-Type: text/plain Date: Sat, 24 Feb 2007 09:25:05 +0100 Message-Id: <1172305505.1902.27.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Geary Sean-R60898 , linuxppc-dev@ozlabs.org, Zhang Wei-r63237 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2007-02-23 at 14:57 -0500, Morrison, Tom wrote: > All, > > I have yet to successfully gone through full initialization / > registration of this driver for this board. > > I have both a Marvell PCI SATA Card (with 6042 chip) > and a Marvell PCI Express SATA card (with 7042 chip). > > PCI/6042 Chip Marvel SATA Card > ============================== > On PCI Bus - the card is probed, and finds the SATA drive - > goes through an ata add device process - up to adding scsi device - > even goes all the way to checking the file system -and lastly says: > > SCSI device sda: write cache: enabled, read cache: enabled, > sda: unknown partition table > sd 0:0:0:0: Attached scsi disk sda > > After full boot (I am nfs mounting my root file system until I get > this working), I try to mount drive - no good - I can't mount it > (it also doesn't create a /dev/sda or /dev/sda1 device - I assume > that if it knew the partitioning table - it would actually create > these devices and Yes, I have ms-dos file system support compiled in? The above looks like it's working and you don't have a proper partition table on the disk or you haven't compiled in support for the right type of partition map (this is different from the filesystem type).... Make sure you enable MS-DOS partition type support in addition to file system type. Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw01.freescale.net (az33egw01.freescale.net [192.88.158.102]) by ozlabs.org (Postfix) with ESMTP id D22FADDEE3 for ; Mon, 26 Feb 2007 11:18:37 +1100 (EST) Message-ID: <45E22753.2020809@freescale.com> Date: Sun, 25 Feb 2007 18:18:27 -0600 From: Timur Tabi MIME-Version: 1.0 To: "Morrison, Tom" Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <1172305505.1902.27.camel@localhost.localdomain> In-Reply-To: <1172305505.1902.27.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Benjamin Herrenschmidt wrote: > The above looks like it's working and you don't have a proper partition > table on the disk or you haven't compiled in support for the right type > of partition map (this is different from the filesystem type).... > > Make sure you enable MS-DOS partition type support in addition to file > system type. Yeah, I made the same mistake once too. The trick is not to confuse a file system with a partition type. They're completely separate options. You can select any combination of file systems and partition types, even combinations that can never exist in the real world. So if you turn on MS-DOS file system support, you also need to turn on MS-DOS partition support. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 4DA97DDEC8 for ; Tue, 27 Feb 2007 04:02:52 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: RE: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Date: Mon, 26 Feb 2007 12:01:28 -0500 Message-ID: In-Reply-To: <45E22753.2020809@freescale.com> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <1172305505.1902.27.camel@localhost.localdomain> <45E22753.2020809@freescale.com> From: "Morrison, Tom" To: "Timur Tabi" Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Yup, missed that! Thank you=20 -----Original Message----- From: Timur Tabi [mailto:timur@freescale.com]=20 Sent: Sunday, February 25, 2007 7:18 PM To: Morrison, Tom Cc: linuxppc-dev@ozlabs.org Subject: Re: Update on: MPC85xx git/MPC8548cds - PCI/PCIE problemS with Marvel SATA driver... Benjamin Herrenschmidt wrote: > The above looks like it's working and you don't have a proper partition > table on the disk or you haven't compiled in support for the right type > of partition map (this is different from the filesystem type).... >=20 > Make sure you enable MS-DOS partition type support in addition to file > system type. Yeah, I made the same mistake once too. The trick is not to confuse a file system with a partition type.=20 They're completely separate options. You can select any combination of=20 file systems and partition types, even combinations that can never exist in the real world. So if you turn on MS-DOS file system support, you=20 also need to turn on MS-DOS partition support. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from empbedex1.empirix.com (empbedex1.empirix.com [12.38.203.54]) by ozlabs.org (Postfix) with ESMTP id 16B35DDDFF for ; Wed, 28 Feb 2007 03:45:37 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: Another Update (SUCCESS) on: MPC85xx git/MPC8548cds - PCI/PCIE problemS w/ Marvel SATA driver... Date: Tue, 27 Feb 2007 11:45:28 -0500 Message-ID: In-Reply-To: <45E22753.2020809@freescale.com> References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <1172305505.1902.27.camel@localhost.localdomain> <45E22753.2020809@freescale.com> From: "Morrison, Tom" To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , As indicated before, I got the SATA drive fully=20 accessed via the PCI interface (that uses the Marvell=20 6042 chip). With some help from Freescale and based upon the CDS/Carrier/ Motherboard combination that I have (2.2/1.2/3.0), I was required to merge the PCI Express piece of the Standard=20 DTS file into the legacy version. Further, I modified=20 the standard sata_mv.c to recognize the Marvell 7042 chip=20 as a valid/supportable id. The question now is: What do I do with these changes? I am assuming that someone from Freescale will update the DTS changes, but what about the change to sata_mv.c? It is a one line change to add the Marvell version of=20 7042 chip to the pci_device_id table (mv_pci_tbl): { PCI_VDEVICE(MARVELL, 0x7042), chip_7042 }, I know that for Marvell, the only difference between the=20 PCI version (6042) and PCI Express version (7042) is=20 the external bridge interface (PCI to PCI bridge for the=20 6042 & PCI to PCI Express bridge for the 7042) which is transparent to this driver anyways. Thus, I am=20 pretty sure it's a safe change? But, I've never submitted a change and/or I do not=20 want to step on anyone else's toes (J.G. comes in mind)=20 if they are already staging this change. Suggestions/Comments? Thanks in advance... Tom Morrison Principal Software Engineer EMPIRIX=20 20 Crosby Drive - Bedford, MA 01730 p: 781.266.3567 f: 781.266.3670=20 email: tmorrison@empirix.com=20 www.empirix.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nommos.sslcatacombnetworking.com (nommos.sslcatacombnetworking.com [67.18.224.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 21E7ADDE29 for ; Wed, 28 Feb 2007 04:17:47 +1100 (EST) In-Reply-To: References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <1172305505.1902.27.camel@localhost.localdomain> <45E22753.2020809@freescale.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <3B3A3CDA-4450-449E-9171-8E5B87E531E3@kernel.crashing.org> From: Kumar Gala Subject: Re: Another Update (SUCCESS) on: MPC85xx git/MPC8548cds - PCI/PCIE problemS w/ Marvel SATA driver... Date: Tue, 27 Feb 2007 11:16:54 -0600 To: "Morrison, Tom" Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 27, 2007, at 10:45 AM, Morrison, Tom wrote: > As indicated before, I got the SATA drive fully > accessed via the PCI interface (that uses the Marvell > 6042 chip). > > With some help from Freescale and based upon the CDS/Carrier/ > Motherboard combination that I have (2.2/1.2/3.0), I was > required to merge the PCI Express piece of the Standard > DTS file into the legacy version. Further, I modified > the standard sata_mv.c to recognize the Marvell 7042 chip > as a valid/supportable id. > > The question now is: What do I do with these changes? > > I am assuming that someone from Freescale will update the > DTS changes, but what about the change to sata_mv.c? For the sata_mv.c change I would create a patch as per Documentation/ SubmittingPatches and email Jeff Garzik with the patch and copy linux- ide@vger.kernel.org. > It is a one line change to add the Marvell version of > 7042 chip to the pci_device_id table (mv_pci_tbl): > > { PCI_VDEVICE(MARVELL, 0x7042), chip_7042 }, > > I know that for Marvell, the only difference between the > PCI version (6042) and PCI Express version (7042) is > the external bridge interface (PCI to PCI bridge for the > 6042 & PCI to PCI Express bridge for the 7042) which > is transparent to this driver anyways. Thus, I am > pretty sure it's a safe change? > > But, I've never submitted a change and/or I do not > want to step on anyone else's toes (J.G. comes in mind) > if they are already staging this change. > > Suggestions/Comments? > > Thanks in advance... > > Tom Morrison > Principal Software Engineer > EMPIRIX > 20 Crosby Drive - Bedford, MA 01730 > p: 781.266.3567 f: 781.266.3670 > email: tmorrison@empirix.com > www.empirix.com > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from az33egw01.freescale.net (az33egw01.freescale.net [192.88.158.102]) by ozlabs.org (Postfix) with ESMTP id 60235DDE29 for ; Thu, 1 Mar 2007 02:38:49 +1100 (EST) In-Reply-To: References:

<8B9F6546-0D85-4AD0-A196-25F0F9C1A5A0@freescale.com> <1172305505.1902.27.camel@localhost.localdomain> <45E22753.2020809@freescale.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <114EA8BE-428F-4602-A6B1-63C9EF0CB722@freescale.com> From: Andy Fleming Subject: Re: Another Update (SUCCESS) on: MPC85xx git/MPC8548cds - PCI/PCIE problemS w/ Marvel SATA driver... Date: Wed, 28 Feb 2007 09:38:38 -0600 To: "Morrison, Tom" Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 27, 2007, at 10:45, Morrison, Tom wrote: > As indicated before, I got the SATA drive fully > accessed via the PCI interface (that uses the Marvell > 6042 chip). > > With some help from Freescale and based upon the CDS/Carrier/ > Motherboard combination that I have (2.2/1.2/3.0), I was > required to merge the PCI Express piece of the Standard > DTS file into the legacy version. Further, I modified > the standard sata_mv.c to recognize the Marvell 7042 chip > as a valid/supportable id. > > The question now is: What do I do with these changes? > > I am assuming that someone from Freescale will update the > DTS changes, but what about the change to sata_mv.c? Actually, if you could send a patch for this, I'd appreciate it. I'm not completely clear on which changes you made, here. I want to make sure we get them all. Andy