From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dr. Philipp Tomsich Date: Fri, 13 Jul 2018 12:26:30 +0200 Subject: [U-Boot] [PATCH v3 4/4] rk3288: Convert register defines to const uintptr_t In-Reply-To: References: <20180611190051.6897-1-carlo@caione.org> <20180611190051.6897-5-carlo@caione.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de > On 9 Jul 2018, at 05:05, Simon Glass wrote: >=20 > On 11 June 2018 at 13:00, Carlo Caione wrote: >> From: Carlo Caione >>=20 >> No functional change but at least we can now guarantee type safety. >>=20 >> Signed-off-by: Carlo Caione >> --- >> arch/arm/mach-rockchip/rk3288-board.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > Reviewed-by: Simon Glass >=20 > I'm not sure this affects type safety. The value in the #define has > the same value (and type) as your variables. I prefer this as locally defined const variables, so I=E2=80=99ve squashed = this onto 2/4. Philipp.