From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40556 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PXBdC-0007zH-KV
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 06:53:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PXBcg-00082L-7m
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 06:52:49 -0500
Received: from mailout-de.gmx.net ([213.165.64.23]:37947 helo=mail.gmx.net)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PXBcf-00080c-QB
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 06:52:18 -0500
Message-ID: <BDFC073B34644070B80B48B127187FB3@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <1292879604-22268-1-git-send-email-agraf@suse.de>
	<1292879604-22268-2-git-send-email-agraf@suse.de>
	<AANLkTikVe+NV5Lsr78JA8+V1b5bK-hghwH640BWpBeqH@mail.gmail.com>
	<C4772645-F624-47C0-B608-AAB3EF5D3C9D@suse.de>
In-Reply-To: <C4772645-F624-47C0-B608-AAB3EF5D3C9D@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/8] ahci: split ICH9 from core
Date: Mon, 27 Dec 2010 12:51:38 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Alexander Graf wrote:
> Am 23.12.2010 um 09:23 schrieb Stefan Hajnoczi <stefanha@gmail.com>:
> 
> > On Mon, Dec 20, 2010 at 9:13 PM, Alexander Graf <agraf@suse.de> wrote:
> >> From: Sebastian Herbszt <herbszt@gmx.de>
> >> 
> >> There are multiple ahci devices out there. The currently implemented ich-9
> >> is only one of the many. So let's split that one out into a separate file
> >> to stress the difference.
> >> 
> >> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> >> Signed-off-by: Alexander Graf <agraf@suse.de>
> >> ---
> >>  Makefile.objs |    1 +
> >>  hw/ide/ahci.c |  305 +-------------------------------------------------------
> >>  hw/ide/ahci.h |  309 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  hw/ide/ich.c  |   61 +++++++++++
> >>  4 files changed, 375 insertions(+), 301 deletions(-)
> >>  create mode 100644 hw/ide/ahci.h
> >>  create mode 100644 hw/ide/ich.c
> > 
> > Do you want to add copyright headers on the new files?
> 
> That's what patch 2 does :)

Alex, feel free to merge patch 1 and 2 if it's more reasonable.

Sebastian