All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Michal Hocko <mhocko@kernel.org>,
	John Hubbard <jhubbard@nvidia.com>,
	mtk.manpages@gmail.com, cl@linux.com, akpm@linux-foundation.org,
	linux-man@vger.kernel.org, linux-api@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes
Date: Fri, 6 Dec 2019 13:00:18 -0500	[thread overview]
Message-ID: <BE1B9B9B-17C2-4093-A332-183DF3B6F2A3@lca.pw> (raw)
In-Reply-To: <5384814f-c937-9622-adbe-c03e199e0267@linux.alibaba.com>



> On Dec 6, 2019, at 12:31 PM, Yang Shi <yang.shi@linux.alibaba.com> wrote:
> 
> It looks since commit e78bbfa82624 ("mm: stop returning -ENOENT from sys_move_pages() if nothing got migrated") too, which reset err to 0 unconditionally. It seems it is on purpose by that commit the syscall caller should check status for the details according to the commit log.

I don’t read it on purpose. “There is no point in returning -ENOENT from sys_move_pages() if all pages
were already on the right node”, so this is only taking about the pages in the desired node. Anyway, but now it is probably the best time to think outside the box redesigning this syscalls and nuke this whole mess.

  reply	other threads:[~2019-12-06 18:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06  1:34 [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes Yang Shi
2019-12-06  1:47 ` John Hubbard
2019-12-06  1:47   ` John Hubbard
2019-12-06  7:47 ` Michal Hocko
2019-12-06  8:25 ` John Hubbard
2019-12-06  8:25   ` John Hubbard
2019-12-06  9:45   ` Michal Hocko
2019-12-06 17:31     ` Yang Shi
2019-12-06 18:00       ` Qian Cai [this message]
2019-12-06 18:19         ` Christopher Lameter
2019-12-06 18:19           ` Christopher Lameter
2019-12-06 17:26   ` Yang Shi
2019-12-14  1:55     ` Michael Kerrisk (man-pages)
2019-12-18  7:36       ` John Hubbard
2019-12-18  7:36         ` John Hubbard
2019-12-18 10:17         ` Michal Hocko
2019-12-31  3:00           ` Yang Shi
2019-12-31  3:49             ` Eric W. Biederman
2019-12-31  3:49               ` Eric W. Biederman
2019-12-31  3:49               ` Eric W. Biederman
2020-01-02 22:15               ` Yang Shi
2019-12-31  2:49         ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1B9B9B-17C2-4093-A332-183DF3B6F2A3@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.