From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v3 3/4] net/mlx5: use port sibling iterators
Date: Wed, 3 Apr 2019 18:07:45 +0000
Message-ID: <BE3D930D-A196-4C8E-B947-027638E066B1@mellanox.com>
References: <20181130002716.27325-1-thomas@monjalon.net>
 <20190401022700.1570-1-thomas@monjalon.net>
 <20190401022700.1570-4-thomas@monjalon.net>
 <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Shahaf Shuler <shahafs@mellanox.com>, Thomas Monjalon
 <thomas@monjalon.net>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr30082.outbound.protection.outlook.com [40.107.3.82])
 by dpdk.org (Postfix) with ESMTP id A8FF11B47E
 for <dev@dpdk.org>; Wed,  3 Apr 2019 20:07:47 +0200 (CEST)
In-Reply-To: <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com>
Content-Language: en-US
Content-ID: <9FBC9CC7FC39724BBCD35898F3B2C05A@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Apr 3, 2019, at 7:19 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>=20
> On 4/1/2019 3:26 AM, Thomas Monjalon wrote:
>> Iterating over siblings was done with RTE_ETH_FOREACH_DEV()
>> which skips the owned ports.
>> The new iterators RTE_ETH_FOREACH_DEV_SIBLING()
>> and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct.
>>=20
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>=20
> Hi Shahaf, Yongseok,
>=20
> Any comment on this patch?

Sorry for late reply.
I know it has been merged but it looks okay to me.

Thanks,
Yongseok