From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
Subject: Re: [PATCH] lcore: make semantics of lcore role function
 more intuitive
Date: Thu, 26 Apr 2018 14:44:06 +0000
Message-ID: <BE54F058557D9A4FAC1D84E2FC6D87570EE2DACC@fmsmsx115.amr.corp.intel.com>
References: <b25e9076c53da76cc658363bab8de60ebd69d10b.1524745985.git.anatoly.burakov@intel.com>
 <2584582.pWCQVUZt55@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Neil Horman <nhorman@tuxdriver.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko"
 <marko.kovacevic@intel.com>, Robert Sanford <rsanford@akamai.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Burakov, Anatoly"
 <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 909CD8D3C
 for <dev@dpdk.org>; Thu, 26 Apr 2018 16:44:09 +0200 (CEST)
In-Reply-To: <2584582.pWCQVUZt55@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks,  Anatoly and Thomas.  I had also considered the following chunk for=
 the release notes:

diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/=
release_18_05.rst
index 04ff4fe..127a7e2 100644                                              =
    =20
--- a/doc/guides/rel_notes/release_18_05.rst                               =
    =20
+++ b/doc/guides/rel_notes/release_18_05.rst                               =
    =20
@@ -72,6 +72,11 @@ API Changes                                             =
    =20
    Also, make sure to start the actual text at the margin.                =
    =20
    =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D                  =20
                                                                           =
    =20
+* **rte_lcore_has_role() return values changed**                          =
    =20
+                                                                          =
    =20
+  This function now returns 1 or 0 for true or false, respectively, rather=
       =20
+  than 0 or <0 for success or failure to make use of the function more    =
    =20
+  intuitive.                                                              =
    =20
                                                                           =
    =20
 ABI Changes                                                               =
    =20
 -----------

Do we want this note?  Also, it looks like the Doxygen documentation of the=
 function in the header file didn't get updated.

Regards,
Erik

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, April 26, 2018 9:31 AM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org; Neil Horman <nhorman@tuxdriver.com>; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Robert Sanford <rsanford@akamai.com>;
> Carrillo, Erik G <erik.g.carrillo@intel.com>; olivier.matz@6wind.com;
> shreyansh.jain@nxp.com
> Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role funct=
ion
> more intuitive
>=20
> 26/04/2018 15:42, Anatoly Burakov:
> > rte_lcore_has_role() returns 0 if role of lcore matches requested
> > role. The return value of the API is confusing, and this is a known
> > problem with a deprecation notice announcing the change to more
> > intuitive semantics:
> >
> > Commit 064518f68d48 ("doc: announce EAL API change to lcore role
> > function")
> > Cc: erik.g.carrillo@intel.com
> >
> > Implement changes announced in the deprecation notice, and remove it.
> > Also, fix usages of this API to reflect the change. Control thread
> > patches expected new behavior and were broken before, now they are
> fixed as well.
> >
> > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > Cc: olivier.matz@6wind.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>=20
> Applied, thanks
>=20
>=20