From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jin Zhengxiong-R64188 <R64188@freescale.com>
Date: Fri, 30 Sep 2011 09:10:45 +0000
Subject: [U-Boot] The command "nand write.yaffs" is not working correctly
In-Reply-To: <CAGQXtZHPE-ddKMgjXQDFpFP=_k6dzP=P=u_vGE1vnPwMmiADqw@mail.gmail.com>
References: <CAGQXtZHPE-ddKMgjXQDFpFP=_k6dzP=P=u_vGE1vnPwMmiADqw@mail.gmail.com>
Message-ID: <BE72CBA69B1D6F44B0680DF984332A32291DCC@039-SN1MPN1-005.039d.mgd.msft.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> Behalf Of Peter Pan
> Sent: Wednesday, September 21, 2011 9:09 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] The command "nand write.yaffs" is not working correctly
> 
> I'm recently facing a yaffs2 image write problem in u-boot.
> 
> In u-boot console, I write the yaffs2 image in ram to an already erased nand
> flash with command "nand write.yaffs ${loadaddr} ${nandrootoffset} ${filesize}".
> After that, if I boot using a ramdisk and mount that yaffs2 partition, I can
> only see a folder of "lost+fount". I seems nothing has been written into that
> partition.
> 
> But if now I write this image using "nandwrite -a -o /dev/mtd4 yaffs2.img" and
> mount that partition, it's working.
> 
> Anyone met that problem already? Or if I did anything wrong?

[Jin Zhengxiong-R64188] 
I once met the similar issue with 2011.03 base and fixed it with following patch, But 
I didn't do a detail checking for that, FYI...

@@ -499,6 +499,7 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
 		return -EINVAL;
 	}
 
+#ifndef CONFIG_CMD_NAND_YAFFS
 	if (!need_skip) {
 		rval = nand_write (nand, offset, length, buffer);
 		if (rval == 0)
@@ -509,13 +510,12 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
 			offset, rval);
 		return rval;
 	}
-
+#endif
 	while (left_to_write > 0) {
 		size_t block_offset = offset & (nand->erasesize - 1);
 		size_t write_size;
 
 		WATCHDOG_RESET ();
-
 		if (nand_block_isbad (nand, offset & ~(nand->erasesize - 1))) {
 			printf ("Skip bad block 0x%08llx\n",
 				offset & ~(nand->erasesize - 1));
@@ -546,7 +546,7 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
 				ops.oobbuf = ops.datbuf + pagesize;
 
 				rval = nand->write_oob(nand, offset, &ops);
-				if (!rval)
+				if ( rval != 0)
 					break;
 
 				offset += pagesize;