From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Shin (jonshin)" Subject: Re: [PATCH] lib/librte_ether: error handling on MAC address replay Date: Fri, 20 Jan 2017 02:30:21 +0000 Message-ID: References: <20170119184721.22348-1-jonshin@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" To: Igor Ryzhov Return-path: Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id E71482E8A for ; Fri, 20 Jan 2017 03:32:46 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VGhhbmtzIElnb3IgZm9yIHlvdXIgY29tbWVudHMhDQoNCkEgZ29vZCBwb2ludCBvbiB0aGUgZmly c3QgaXRlbS4NCkZvciB0aGUgc2Vjb25kIHF1ZXN0aW9uLCBJIHdhbGtlZCB0aHJvdWdoIGRldmlj ZSBpbml0aWFsaXphdGlvbiByb3V0aW5lcyB0byBzZWUgYW55IG90aGVyIHBvdGVudGlhbCBpc3N1 ZS4NCkkgZm91bmQgb25lIGNhc2Ugd2hlcmUgaW5kZXggMCBpcyBzdGlsbCByZXF1aXJlZCB0byBy ZXBsYXkgTUFDIGFkZHJlc3M7IGV4KSBNQUMgYWRkcmVzcyBjaGFuZ2Ugb24gdGhlIFBIWSBwb3J0 IOKAkyBpbmRleCAwDQpObyBjb2RlIHBhdGggd2FzIGZvdW5kIHRvIHJlc3RvcmUgYSBjaGFuZ2Vk IE1BQyB2YWx1ZSB3aXRoIGluZGV4IDAuIFRoZXJlZm9yZSwgd2UgbWF5IGhhdmUgdG8gdXNlIHRo ZSBleGlzdGluZyBydGVfZXRoX2Rldl9jb25maWdfcmVzdG9yZSgpIGZ1bmN0aW9uIHRvIHJlcGxh eSAwIGluZGV4ZWQgTUFDLg0KQ3VycmVudGx5IHJ0ZV9ldGhfZGV2X2RlZmF1bHRfbWFjX2FkZHJf c2V0KCkgaXMgY2FsbGVkIHRvIHByb2dyYW0gUEhZIE1BQyB3aXRob3V0IHNldHRpbmcgbWFjX3Bv b2xfc2VsIGZvciAwIGluZGV4Lg0KU28gdGhlIGZvbGxvd2luZyBjb2RlIGlzIGFsc28gcmVxdWly ZWQgaW5zaWRlIHJ0ZV9ldGhfZGV2X2RlZmF1bHRfbWFjX2FkZHJfc2V0KCkgcm91dGluZSBhcyBh IGNvbXBsZXRlIHNvbHV0aW9uOg0KQEAgLTIyMzcsNiArMjIzNCw5IEBAIHN0cnVjdCBydGVfZXRo X2RldiAqDQoNCiAgICAgICAgKCpkZXYtPmRldl9vcHMtPm1hY19hZGRyX3NldCkoZGV2LCBhZGRy KTsNCg0KKyAgICAgICAvKiBVcGRhdGUgcG9vbCBiaXRtYXAgaW4gTklDIGRhdGEgc3RydWN0dXJl ICovDQorICAgICAgIGRldi0+ZGF0YS0+bWFjX3Bvb2xfc2VsWzBdID0gMTsNCisNCiAgICAgICAg cmV0dXJuIDA7DQoNCkFueSB0aG91Z2h0cyB3b3VsZCBiZSBhcHByZWNpYXRlZC4NCg0KUmVnYXJk cywNClN0ZXZlDQoNCkZyb206IElnb3IgUnl6aG92IDxpcnl6aG92QG5md2FyZS5jb20+DQpEYXRl OiBUaHVyc2RheSwgSmFudWFyeSAxOSwgMjAxNyBhdCAyOjM5IFBNDQpUbzogU3RldmUgU2hpbiA8 am9uc2hpbkBjaXNjby5jb20+DQpDYzogImRldkBkcGRrLm9yZyIgPGRldkBkcGRrLm9yZz4sICJm ZXJydWgueWlnaXRAaW50ZWwuY29tIiA8ZmVycnVoLnlpZ2l0QGludGVsLmNvbT4NClN1YmplY3Q6 IFJlOiBbZHBkay1kZXZdIFtQQVRDSF0gbGliL2xpYnJ0ZV9ldGhlcjogZXJyb3IgaGFuZGxpbmcg b24gTUFDIGFkZHJlc3MgcmVwbGF5DQoNCkhlbGxvIFN0ZXZlLA0KDQpUaGFuayB5b3UgZm9yIHRo ZSBwYXRjaC4NCg0KSSB0aGluayBhIGNvdXBsZSBvZiBpbXByb3ZlbWVudHMgY2FuIGJlIGRvbmU6 DQoxLiBGdW5jdGlvbiBleGlzdGVuY2UgY2hlY2sg4oCTIGlmICgqZGV2LT5kZXZfb3BzLT5tYWNf YWRkcl9hZGQpIOKAkyBjYW4gYmUgdGFrZW4gb3V0IG9mIHRoZSBsb29wLiBXZSBkb24ndCBuZWVk IHRvIGNoZWNrIGl0IG9uIGVhY2ggaXRlcmF0aW9uLg0KMi4gSSdtIG5vdCBjb21wbGV0ZWx5IHN1 cmUsIGJ1dCBJIHRoaW5rIGxvb3AgY2FuIGJlIHN0YXJ0ZWQgZnJvbSAxLCBub3QgZnJvbSAwLCBi ZWNhdXNlIG1hY19wb29sX3NlbFswXSBpcyBhbHdheXMgemVyby4gQW0gSSByaWdodD8NCg0KQmVz dCByZWdhcmRzLA0KSWdvcg0KDQpPbiBUaHUsIEphbiAxOSwgMjAxNyBhdCAxMDozNSBQTSwgU3Rl dmUgU2hpbiAoam9uc2hpbikgPGpvbnNoaW5AY2lzY28uY29tPG1haWx0bzpqb25zaGluQGNpc2Nv LmNvbT4+IHdyb3RlOg0KRGVhciBtYWludGFpbmVyLA0KDQpTb3JyeSB0aGF0IEkgZm9yZ290IHRv IGFkZCDigJxGaXhlczrigJ0gbGluZSBhcyBmb2xsb3dzOg0KDQogICAgICAgRml4ZXM6IDRiZGVm YWFkZTZkMSAoImV0aGRldjogVk1EUSBlbmhhbmNlbWVudHMiKQ0KDQpDYW4geW91IHBsZWFzZSBh ZGQgdGhlIGFib3ZlIGxpbmUgYXMgcGFydCBvZiBjb21tZW50Pw0KDQpUaGFua3MsDQpTdGV2ZQ0K DQpPbiAxLzE5LzE3LCAxMDo0NyBBTSwgIlN0ZXZlIFNoaW4gKGpvbnNoaW4pIiA8am9uc2hpbkBj aXNjby5jb208bWFpbHRvOmpvbnNoaW5AY2lzY28uY29tPj4gd3JvdGU6DQoNCiAgICBUaGlzIHBh dGNoIGZpeGVzIGEgYnVnIGluIHJlcGxheWluZyBNQUMgYWRkcmVzcyB0byB0aGUgaGFyZHdhcmUN CiAgICBpbiBydGVfZXRoX2Rldl9jb25maWdfcmVzdG9yZSgpIHJvdXRpbmUuDQoNCiAgICBTaWdu ZWQtb2ZmLWJ5OiBTdGV2ZSBTaGluIDxqb25zaGluQGNpc2NvLmNvbTxtYWlsdG86am9uc2hpbkBj aXNjby5jb20+Pg0KICAgIC0tLQ0KICAgICBsaWIvbGlicnRlX2V0aGVyL3J0ZV9ldGhkZXYuYyB8 IDEwICsrKysrKy0tLS0NCiAgICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkNCg0KICAgIGRpZmYgLS1naXQgYS9saWIvbGlicnRlX2V0aGVyL3J0ZV9ldGhk ZXYuYyBiL2xpYi9saWJydGVfZXRoZXIvcnRlX2V0aGRldi5jDQogICAgaW5kZXggNDc5MGZhZi4u N2UwMWYxMCAxMDA2NDQNCiAgICAtLS0gYS9saWIvbGlicnRlX2V0aGVyL3J0ZV9ldGhkZXYuYw0K ICAgICsrKyBiL2xpYi9saWJydGVfZXRoZXIvcnRlX2V0aGRldi5jDQogICAgQEAgLTk1MSwxMCAr OTUxLDEyIEBAIHJ0ZV9ldGhfZGV2X2NvbmZpZ19yZXN0b3JlKHVpbnQ4X3QgcG9ydF9pZCkNCiAg ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KDQogICAgICAgICAgICAgICAgLyogYWRk IGFkZHJlc3MgdG8gdGhlIGhhcmR3YXJlICovDQogICAgLSAgICAgICAgICAgaWYgICgqZGV2LT5k ZXZfb3BzLT5tYWNfYWRkcl9hZGQgJiYNCiAgICAtICAgICAgICAgICAgICAgICAgIChkZXYtPmRh dGEtPm1hY19wb29sX3NlbFtpXSAmICgxVUxMIDw8IHBvb2wpKSkNCiAgICAtICAgICAgICAgICAg ICAgICAgICgqZGV2LT5kZXZfb3BzLT5tYWNfYWRkcl9hZGQpKGRldiwgJmFkZHIsIGksIHBvb2wp Ow0KICAgIC0gICAgICAgICAgIGVsc2Ugew0KICAgICsgICAgICAgICAgIGlmICAoKmRldi0+ZGV2 X29wcy0+bWFjX2FkZHJfYWRkKSB7DQogICAgKyAgICAgICAgICAgICAgICAgICBpZiAoZGV2LT5k YXRhLT5tYWNfcG9vbF9zZWxbaV0gJiAoMVVMTCA8PCBwb29sKSkNCiAgICArICAgICAgICAgICAg ICAgICAgICAgICAgICAgKCpkZXYtPmRldl9vcHMtPm1hY19hZGRyX2FkZCkoZGV2LCAmYWRkciwg aSwgcG9vbCk7DQogICAgKyAgICAgICAgICAgICAgICAgICBlbHNlDQogICAgKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KICAgICsgICAgICAgICAgIH0gZWxzZSB7DQogICAg ICAgICAgICAgICAgICAgICAgICBSVEVfUE1EX0RFQlVHX1RSQUNFKCJwb3J0ICVkOiBNQUMgYWRk cmVzcyBhcnJheSBub3Qgc3VwcG9ydGVkXG4iLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBvcnRfaWQpOw0KICAgICAgICAgICAgICAgICAgICAgICAgLyogZXhpdCB0 aGUgbG9vcCBidXQgbm90IHJldHVybiBhbiBlcnJvciAqLw0KICAgIC0tDQogICAgMi45LjMNCg0K DQoNCg==