From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dr. Philipp Tomsich Date: Wed, 13 Sep 2017 10:10:16 +0200 Subject: [U-Boot] [PATCH 05/10] rockchip: spl: rk3399: implement chip-specific board_spl_was_booted_from() In-Reply-To: References: <1505131150-39480-1-git-send-email-philipp.tomsich@theobroma-systems.com> <1505131150-39480-6-git-send-email-philipp.tomsich@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de > On 13 Sep 2017, at 06:25, Simon Glass wrote: > > On 11 September 2017 at 05:59, Philipp Tomsich > wrote: >> To support the new "same-as-spl" specifier in the boot-order on the >> RK3399, this implements the chip-specific mapping from the information >> obtainable from the BROM to a OF path name. >> >> Signed-off-by: Philipp Tomsich >> --- >> >> arch/arm/mach-rockchip/rk3399-board-spl.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) > > Reviewed-by: Simon Glass > > This feels a bit klugey. Does SPL not have access to the same DT? If > so then (at some point when we add support) perhaps it could pass its > name through? This is for the SPL stage (I may have not made this sufficiently clear in the documentation): ‘same-as-spl’ is really intended to direct the SPL stage to search for the full U-Boot stage in the same device the SPL was loaded from. We use this feature for our boot-override slider (the BIOS_DISABLE) signal to allow us to inject the “same device the SPL was loaded from” early on in the search-order for the FIT image containing the ATF, FDT and full U-Boot. Injecting this info (and also the expanded name of the entry in the search-order that was finally used) into the DT later on would be a nice future enhancement that would allow later stages (and the full OS) to know about where things were booted from. Regard, Philipp.