All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Santhapuri, Damodar" <damodar.santhapuri-l0cyMroinI0@public.gmane.org>
To: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Balbi, Felipe" <balbi-l0cyMroinI0@public.gmane.org>,
	"Gupta, Ajay Kumar" <ajay.gupta-l0cyMroinI0@public.gmane.org>
Subject: RE: [PATCH v2 1/3] arm: omap: hwmod: add new memory resource for usb phy control
Date: Thu, 12 Jul 2012 08:52:07 +0000	[thread overview]
Message-ID: <BF1B1853A762164888C918AB089265E4282FCD@DBDE01.ent.ti.com> (raw)
In-Reply-To: <4FFD7533.8010807-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>


Hi,
> 
> Hello.
> 
> On 11-07-2012 14:29, Damodar Santhapuri wrote:
> 
> > From: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
> 
> > Added usb_ctrl0 and usb_ctrl1 base address as new memory resources
> > which will be used at am335x musb driver glue layer to turn on or
> > off builin PHY untill we have a separate system control module
> > driver.
> 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
> > Singed-off-by: Damodar Santhapuri <x0132156-l0cyMroinI0@public.gmane.org>
> > ---
> > Changes from v0:
> > Reordered the layout based on Kishon's comment on not using
> > platform_get_resources_by_name.
> 
> >   arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   12 ++++++++++++
> >   1 files changed, 12 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-
> omap2/omap_hwmod_33xx_data.c
> > index df888fe..ec9e9df 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > @@ -3269,11 +3269,23 @@ static struct omap_hwmod_addr_space
> am33xx_usbss_addr_space[] = {
> >   		.flags		= ADDR_TYPE_RT
> >   	},
> >   	{
> > +		.name		= "usb_ctrl0",
> > +		.pa_start	= 0x44E10620,
> > +		.pa_end		= 0x44E10624,
> 
>    Not 0x44E10623?
> 
> > +		.flags		= ADDR_TYPE_RT
> > +	},
> > +	{
> >   		.name		= "musb1",
> >   		.pa_start	= 0x47401800,
> >   		.pa_end		= 0x47401800 + SZ_2K - 1,
> >   		.flags		= ADDR_TYPE_RT
> >   	},
> > +	{
> > +		.name		= "usb_ctrl1",
> > +		.pa_start	= 0x44E10628,
> > +		.pa_end		= 0x44E1062c,
> 
>     Not 0x44E1062B?

I will fix this and send you updated patch.

Damodar .
> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2012-07-12  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 10:29 [PATCH v2 1/3] arm: omap: hwmod: add new memory resource for usb phy control Damodar Santhapuri
2012-07-11 10:29 ` [PATCH v2 2/3] usb: musb: dsps: add phy control logic to glue Damodar Santhapuri
2012-07-11 10:45   ` ABRAHAM, KISHON VIJAY
2012-07-11 10:48     ` Gupta, Ajay Kumar
     [not found] ` <1342002598-30633-1-git-send-email-x0132156-l0cyMroinI0@public.gmane.org>
2012-07-11 10:29   ` [PATCH v2 3/3] usb: musb: dsps: enable phy control for am335x Damodar Santhapuri
2012-07-11 12:44   ` [PATCH v2 1/3] arm: omap: hwmod: add new memory resource for usb phy control Sergei Shtylyov
     [not found]     ` <4FFD7533.8010807-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-07-12  8:52       ` Santhapuri, Damodar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF1B1853A762164888C918AB089265E4282FCD@DBDE01.ent.ti.com \
    --to=damodar.santhapuri-l0cymroini0@public.gmane.org \
    --cc=ajay.gupta-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.