All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: "keosung.park@samsung.com" <keosung.park@samsung.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: core: Do not open code SZ_x
Date: Wed, 31 May 2023 05:05:35 +0000	[thread overview]
Message-ID: <BL0PR04MB6564EDDD9F558026951BCA4FFC489@BL0PR04MB6564.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20230530140809epcms2p3aff4826012218b0e937e02aa3e30bec2@epcms2p3>

> >int ufshcd_memory_alloc(struct ufs_hba *hba)
> >
> >       /*
> >        * Allocate memory for UTP Transfer descriptors
> >-       * UFSHCI requires 1024 byte alignment of UTRD
> >+       * UFSHCI requires 1KB alignment of UTRD
> >        */
> >       utrdl_size = (sizeof(struct utp_transfer_req_desc) * hba->nutrs);
> >       hba->utrdl_base_addr = dmam_alloc_coherent(hba->dev, @@ -3773,7
> >+3773,7 @@ static int ufshcd_memory_alloc(struct ufs_hba *hba)
> >                                                  &hba->utrdl_dma_addr,
> >                                                  GFP_KERNEL);
> >       if (!hba->utrdl_base_addr ||
> >-          WARN_ON(hba->utrdl_dma_addr & (1024 - 1))) {
> >+          WARN_ON(hba->utrdl_dma_addr & (SZ_1K - 1))) {
> 
> How about changing the UTMRD part inside ufshcd_memory_alloc() as well?
Oops - missed that.
Thanks,
Avri

> 
> Best Regards,
> Keoseong

      reply	other threads:[~2023-05-31  5:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  7:50 [PATCH] scsi: ufs: core: Do not open code SZ_x Avri Altman
2023-05-30 11:11 ` Bean Huo
2023-05-30 13:35   ` Stanley Chu
     [not found] ` <CGME20230530075120epcas2p10917546a2e01da2a17c34b7460f85eef@epcms2p3>
2023-05-30 14:08   ` Keoseong Park
2023-05-31  5:05     ` Avri Altman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR04MB6564EDDD9F558026951BCA4FFC489@BL0PR04MB6564.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=keosung.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.