From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DEAC433EF for ; Fri, 10 Jun 2022 07:19:19 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 232AE4069C; Fri, 10 Jun 2022 09:19:18 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 258EB40689 for ; Fri, 10 Jun 2022 09:19:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654845556; x=1686381556; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=sQxLwcqr86HFbX4PfhdNRnYYQN6gIQIcd+KwAU8wc1Q=; b=Xg8PbVvxG0xwpj5nLvDbqaLIxqMs32rAvw/Qzvswur8oz+mi0eeDRI41 Jn0R1zlkEB42UJCLj2Cj7Q1mXWdASF2yZkFxNZkx75WPqEfEpIiWxEoEp kKwcEVTGOLGT9lidRcl8opSlflEd8NColz4IQFA3JnREFcQ/0VvXMVwxN vJq4omnBBM+AmVirfNJiK+pE8gzTngZFCoGCUILdTgyXmRYMI8QJkOk0D 4/0N9BvP5ecJVYWI73Rv6uFkPVoqK/uHWif2+BonmeBiFZInUNqr13cUH o62oQJ2w8lamW1O4DTV7GHh5467inA+yExJGoNQTMdi8qMr8Kb3S6Jjxg A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="278683252" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="278683252" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 00:19:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="684400608" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 10 Jun 2022 00:19:14 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 00:19:14 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 00:19:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 10 Jun 2022 00:19:13 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 10 Jun 2022 00:19:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhhcdeDSk3F84Di9J+pNeU9K7AorS/W39GPHLTgXxaC1sBdHm1vfA2EZQYmBbqDGd2aMnVVF8iANO817o56zHHxlz6JETA7lFDtpq9gNWBxi4Br9teGO8mNXDci/jiSmfmvf0GOHE6KRe5S/HdmZumzI7TkZPdq2GnjkFVouu+CKu1atjqEkqmeLfYbPIZA41gD4Bg473lVzi+LBkHq5WAsny+SeySomWfPuKjoRye9H/ZuO6icNGRC0YXIsb0xf81d8dRpTFk1gAFU8ocbkYIjhQ6JzLBxZ9iOLww2ruxS5ZfotAt8Ot1L1nKUUwToFiZxUx+qhjY02kGZcxjaNxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sQxLwcqr86HFbX4PfhdNRnYYQN6gIQIcd+KwAU8wc1Q=; b=haF3+DMuGPmR+rumGY9SKzXkzzMYW9q20sCraM6XZvud3Xdp5Fb+03AG+exfrpWKeaaHhdaeTy2lVPhMPU1ZpB3uw/ypvsiiK5KqIf9Tlz4rhQodzAgXJPnp2U0lhSqpGKDDEZorVpah7IBO9luQYMlckryHonknsRfMhBZ+ofwU/Bd4z6uzrhOkJYmnaT2AokTM6o266G8e1OfD56M9IWtjvxXCgqhJXa+aQuOVVU4g/LIvFf0mUwq0fAnrvES5JeunUNadBYCmuY70Tg6bBxjDyoauSn3BNFa3pcLC08riw5BoFBJ6qzUNwYaF3UEjFlg93NDwGrMZoNq7UO9K2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL0PR11MB3187.namprd11.prod.outlook.com (2603:10b6:208:67::19) by CO1PR11MB5169.namprd11.prod.outlook.com (2603:10b6:303:95::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Fri, 10 Jun 2022 07:19:10 +0000 Received: from BL0PR11MB3187.namprd11.prod.outlook.com ([fe80::914f:e4e5:adad:3551]) by BL0PR11MB3187.namprd11.prod.outlook.com ([fe80::914f:e4e5:adad:3551%6]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 07:19:10 +0000 From: "Jiang, Cheng1" To: "Xia, Chenbo" , Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "Matz, Olivier" , "Ma, WenwuX" , "Zhang, Yuying" , "Singh, Aman Deep" Subject: RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path Thread-Topic: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path Thread-Index: AQHYezZXF2VWLR/Yb0SiRX6w8kvTFK1IA3wggAAxIeA= Date: Fri, 10 Jun 2022 07:19:10 +0000 Message-ID: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-6-maxime.coquelin@redhat.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 887c6905-337d-4238-400c-08da4ab1836b x-ms-traffictypediagnostic: CO1PR11MB5169:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CcgZu1XFbFf59MH0ZpVswAEg8nyPvPUodeCmZ2uuA9IUzHwVqwejYksd1+mflisk1yehFhYH/h2JStCXIuBpdkMQOxkA4ualm3ShqjX9tU20We8iFIlOB1oNa5lp7wXe1VLdaN6b7x6Jh/wf8+5BOYMjZ/bm9UpE26Fg4IRALNOB6CJH0NjWxgGzfkKKUvoXRD8xF9WGuXYeafi6P6r2SMm4p1NM1uDIsSdnGZf0PB44vjbTBt6j9VuFi3MJmAy+i3A+/UldkN3xkFI87RsQhSASbIpiIOz9vdsayLnqYC3VEt9HW9Eyw2nR9tGpZrz0xPKVPn2nkh6J3bcC1g+jTfxtzstJLPDrNHm+5vZuS2FCIftoOD+h3ss9pfimYhxHL+RdIRMe4bM3IU4l/6FxcfWWKC9DzhO/XXCxjjhMb1fC0Q2yaOMuUWAzdq5unzHzXmUEADzfSEV90pHVJSfdGj4tm7D3R+Rqp6LuYCf2btFPW8unWqe3dmdXgBDtMXY0/a0eC56mvhlQTkxVlh+HkwwG2018vCEIHV2aNggZypvFOV8/+pZ+6rluFkZyk/rNYpuCx2edCgiBelcs40rR1xBuTDP/QukbgJehaDuVF3OXrswOMltdds5cSUlEsVqTTyzzH1tQBxaGlJesrmzrIFsG3o7srT5KCvo5kcivP+2B7tMO840q+Yc+PeOqlC2RaGeH4CXhsKwI6l6WnN0Ja/wKF1nFgX2UcnAhuK2k0G0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3187.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(71200400001)(921005)(66446008)(66476007)(66556008)(66946007)(64756008)(5660300002)(110136005)(8676002)(7696005)(186003)(38100700002)(86362001)(83380400001)(55016003)(52536014)(8936002)(6636002)(6506007)(2906002)(82960400001)(9686003)(508600001)(53546011)(33656002)(122000001)(316002)(26005)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7k6g3fO3L+Nzg2e9w40rEqKEsrLueY2GpiQ5bU9bVbkD5hBbhX5NFTE2dcRz?= =?us-ascii?Q?6dDeBHo/O6Hc2LBhd58RrZI9NLYeYVQZFj606I17tqt5cCr+S9jeCwibOiP+?= =?us-ascii?Q?HGs9beAgfrTbNhte0uSmSmySv8LHFqyRnwCE/al09C5GbJN2Tn1EIHGBQNUv?= =?us-ascii?Q?1d7VP+SqhzxwTlJsS7obH7tWze0sH6aXsnD4nw+4uLjGcUTi6xQwDY2C/vjQ?= =?us-ascii?Q?cJLDwyXDZB9nQblfGkggJi0V0SjoY6POkrttbY8Z8drKt8vphvhZdGpZso8j?= =?us-ascii?Q?35D1P9fhbwlHeIQlPX/v4Dn22D7nlU3QxxCdGVWAs1T+fqzcq+QodazN6eVz?= =?us-ascii?Q?u3KoioKB9tp0aVuBc9GgVpegzxU1tZaQVDjZcsymc7/j69apOehwW4klWk4b?= =?us-ascii?Q?K7IUl784nbRjVJg5vZXtAM85mQhINgYuEl5NljPM4ceYu/9Zep8MgkyuHCVq?= =?us-ascii?Q?EOe/kMHmdQO4iWjt3fXwD0U8FVfy9S+fJVFOlQpb5KhjwglsUlhUTi9RYCSj?= =?us-ascii?Q?1Wc6t6vrsVOwhFeoI9o98q4GSVg+/berbfopz87q3OKosMKxhldQWrEbREQY?= =?us-ascii?Q?QlpUKp3g30s0auP9F9TZz4ulOF2h+moXkTbi++hh3xT7mJSnGQfpxY/wuOZf?= =?us-ascii?Q?Mkksa794MihyszOhfiS1qAmfiebecC7XHz53N1ntFo5KHHV/SvIu+Fhd2DyL?= =?us-ascii?Q?x594JFfw6XQXNlEN8zOzyphsuDX7Pn7mCglvkFvIyglO3A7GTG5W9NZcbH7X?= =?us-ascii?Q?LLcRf/FpsMKFFuIU382I0EGew91q6o7nDntRaQ9oVrm4TvtH5y64VSNg5F1s?= =?us-ascii?Q?xy+U83PAymZ6333JcIIOp85qjRMhzvi9qwLLYlUA2jCi7nOJ6pHQhaYruZrs?= =?us-ascii?Q?/QLcMI2qnchk/NloioPkmXNfr6jl3JCq3zwyp2ro4/PxeYFHlwQd6M+t5Xcf?= =?us-ascii?Q?u/dOdePfCcvwKOvqI8Ti0fea91ZEv81hUF6+qDtXYiHTBsakkLdoeXwMLKSj?= =?us-ascii?Q?lSYy6Er+8T1Hfs8bqUBMr0IzEwKFDqA0HMmyCsAtnDT8QJ/xbkchsDV1Xa+E?= =?us-ascii?Q?h7awdSlsCkzz0vs5VtC3L5zb8orq67fyvduYQdNmRT2N1fMvOlx8PyHLYUPr?= =?us-ascii?Q?5fohYav4A9WLK7NDkbi+lGG4lntW6z+dACDmD3f3zPgcLHd8O7GLcq3CFRq2?= =?us-ascii?Q?AECfV1PRJ0B4F1GTssqslnAFKcAgJ7gz2CycXTgs2ERtxCNjkYB9xZ15HKaU?= =?us-ascii?Q?1Qr1rqGkZbg6wbMNennDJNAOzRFxyLZFLIZllds5Cq9u+TEFanl1otF/O7/n?= =?us-ascii?Q?f+5Wdxja22TS3x3cUfJmqVoSPpX8ELbrfssYXmBTS87CZR/SoIFzHu6HrFuZ?= =?us-ascii?Q?MVB7Zo/TSTOv09PdVpn7Gd5DS7wvgrLuzE6xGb8CYcasPfQ+hvPQqZUslqcr?= =?us-ascii?Q?pFmmcB1tZSaqKpy/JDGXwtgCHiAxi8o/0XfawYl8DiPuuW/VgfTkm6+2CnCQ?= =?us-ascii?Q?7X6920TQlYjCmea2lMt/s8dhCqF8KoRKn5/K+HHo4FyfmeGurpKdV5HJm7aN?= =?us-ascii?Q?6e3eQXmtRuanvk/kYM09w1p7y28LPYPnD64JvlABAGqkdSWEhU+Cq5WS0dUF?= =?us-ascii?Q?bqZ+LdEs5NzQ1+HmgNolEk+DQj+Hmele1UzFtphWgFEB1L3aW4F28DbY0psR?= =?us-ascii?Q?k2On1WfQ/fAXMcPQBLnKuvAb9l0Azj4zMBKXBmNGVqjz1mTfcl9m+giS+MQL?= =?us-ascii?Q?Lr+crc5wlg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3187.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 887c6905-337d-4238-400c-08da4ab1836b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 07:19:10.0232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I8knxNKPSXfYvSnhFIbFK7yKMiHP7gZ6+1jZBHlaTtzdLKXCllFGOtV1shBQzb2A6NcYz37UAofMLVC2HTOwEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5169 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Maxime, > -----Original Message----- > From: Xia, Chenbo > Sent: Friday, June 10, 2022 11:49 AM > To: Maxime Coquelin ; dev@dpdk.org; > jasowang@redhat.com; david.marchand@redhat.com; Matz, Olivier > ; Ma, WenwuX ; Zhang, > Yuying ; Singh, Aman Deep > ; Jiang, Cheng1 > Subject: RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path >=20 > + Cheng for review >=20 > > -----Original Message----- > > From: Maxime Coquelin > > Sent: Wednesday, June 8, 2022 8:50 PM > > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo > > ; david.marchand@redhat.com; Matz, Olivier > > ; Ma, WenwuX ; > Zhang, > > Yuying ; Singh, Aman Deep > > > > Cc: Maxime Coquelin > > Subject: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path > > > > Virtio specification supports host checksum offloading for L4, which > > is enabled with VIRTIO_NET_F_CSUM feature negotiation. However, the > > Vhost PMD does not advertise Rx checksum offload capabilities, so we > > can end-up with the VIRTIO_NET_F_CSUM feature being negotiated, > > implying the Vhost library returns packets with checksum being > > offloaded while the application did not request for it. > > > > Advertising these offload capabilities at the ethdev level is not > > enough, because we could still end-up with the application not > > enabling these offloads while the guest still negotiate them. > > > > This patch advertises the Rx checksum offload capabilities, and > > introduces a compatibility layer to cover the case VIRTIO_NET_F_CSUM > > has been negotiated but the application does not configure the Rx > > checksum offloads. This function performis the L4 Rx checksum in SW > > for UDP and TCP. Note that it is not needed to calculate the > > pseudo-header checksum, because the Virtio specification requires that > > the driver do it. > > > > This patch does not advertise SCTP checksum offloading capability for > > now, but it could be handled later if the need arises. > > > > Reported-by: Jason Wang > > Signed-off-by: Maxime Coquelin > > --- > > Reviewed-by: Cheng Jiang