All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Belanger <nitram_67@hotmail.com>
To: linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, hare@suse.de, axboe@fb.com, hch@lst.de,
	sagi@grimberg.me, Martin Belanger <martin.belanger@dell.com>
Subject: [PATCH 4/4] nvme-fabrics: add explicit deregistration on disconnect.
Date: Tue, 25 Jan 2022 09:59:56 -0500	[thread overview]
Message-ID: <BL0PR13MB4291B32271567EB19DC312B79C5F9@BL0PR13MB4291.namprd13.prod.outlook.com> (raw)
In-Reply-To: <20220125145956.14746-1-nitram_67@hotmail.com>

From: Martin Belanger <martin.belanger@dell.com>

Per TP8010, a host explicitly registered with a Discovery
Controller (DC) must deregister on disconnect. This patch
sends a DIM PDU to DCs to deregister the host on disconnect.

Signed-off-by: Martin Belanger <martin.belanger@dell.com>
---
 drivers/nvme/host/tcp.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 970b7df574a4..804d927b4b81 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2176,6 +2176,16 @@ static void nvme_tcp_teardown_ctrl(struct nvme_ctrl *ctrl, bool shutdown)
 
 static void nvme_tcp_delete_ctrl(struct nvme_ctrl *ctrl)
 {
+	if (ctrl->opts->explicit_registration &&
++	    ((ctrl->dctype == NVME_DCTYPE_DDC) ||
+	     (ctrl->dctype == NVME_DCTYPE_CDC))) {
+		/* Deregister from discovery controller */
+		union nvmf_tsas tsas = {.tcp.sectype = NVMF_TCP_SECTYPE_NONE};
+
+		nvmf_disc_info_mgmt(ctrl, NVME_TAS_DEREGISTER, NVMF_TRTYPE_TCP,
+				    nvme_get_adrfam(ctrl), "", &tsas);
+	}
+
 	nvme_tcp_teardown_ctrl(ctrl, true);
 }
 
-- 
2.34.1



  parent reply	other threads:[~2022-01-25 15:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220125145956.14746-1-nitram_67@hotmail.com>
2022-01-25 14:59 ` [PATCH 1/4] nvme-fabrics: add discovery controller type Martin Belanger
2022-01-27  9:16   ` Hannes Reinecke
2022-01-27 13:37     ` Belanger, Martin
2022-01-27 13:16   ` Sagi Grimberg
2022-01-25 14:59 ` [PATCH 2/4] nvme: add host symbolic name Martin Belanger
2022-01-27  9:18   ` Hannes Reinecke
2022-01-27 13:20   ` Sagi Grimberg
2022-01-25 14:59 ` [PATCH 3/4] nvme-fabrics: add tp8010 support Martin Belanger
2022-01-27  9:30   ` Hannes Reinecke
2022-01-27 13:12     ` Sagi Grimberg
2022-01-27 13:30       ` Belanger, Martin
2022-01-27 14:28         ` Hannes Reinecke
2022-01-27 21:59         ` Sagi Grimberg
2022-01-28 17:55           ` Belanger, Martin
2022-01-28 21:49             ` Hannes Reinecke
2022-01-28 23:02               ` Belanger, Martin
2022-01-29  8:43                 ` Hannes Reinecke
2022-01-29 12:23                   ` Belanger, Martin
2022-01-29 12:47                     ` Hannes Reinecke
2022-01-30  8:46                       ` Sagi Grimberg
2022-01-30 13:18                         ` Sagi Grimberg
2022-01-31 12:08                         ` Belanger, Martin
2022-01-31 16:05                           ` Sagi Grimberg
2022-01-31 16:16                             ` Belanger, Martin
2022-01-31 18:56                               ` Sagi Grimberg
2022-02-02  8:36                               ` Hannes Reinecke
2022-01-31 17:03   ` John Meneghini
2022-01-31 17:17     ` Belanger, Martin
2022-01-31 18:28       ` John Meneghini
2022-01-25 14:59 ` Martin Belanger [this message]
2022-01-27  9:31   ` [PATCH 4/4] nvme-fabrics: add explicit deregistration on disconnect Hannes Reinecke
2022-01-27 13:14     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR13MB4291B32271567EB19DC312B79C5F9@BL0PR13MB4291.namprd13.prod.outlook.com \
    --to=nitram_67@hotmail.com \
    --cc=axboe@fb.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.belanger@dell.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.