From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F068EC43381 for ; Mon, 25 Mar 2019 16:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD82E20828 for ; Mon, 25 Mar 2019 16:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="f7IOZeF4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729713AbfCYQ36 (ORCPT ); Mon, 25 Mar 2019 12:29:58 -0400 Received: from mail-eopbgr690072.outbound.protection.outlook.com ([40.107.69.72]:33614 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbfCYQ36 (ORCPT ); Mon, 25 Mar 2019 12:29:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRNm0Gq1UrFuUo3bxNT8iLJiPeg/PiTdTslL7YXi8DQ=; b=f7IOZeF4icCuw7txdYEEHb9MQZsm9XCL0cpTPI0PovWJ4YcsP2TS0X2S7cao71DUmUGQET58NSzZE++r/k+KnriTQ5+g7eCSy/5HFfZU49H8JfOyDilCJQGxJ0pdm08vtng+OLrfEOTmMKPulgLRAHbn+PYl/vr9GiuPcbX2Fkc= Received: from BL0PR1501MB2003.namprd15.prod.outlook.com (52.132.21.33) by BL0PR1501MB2164.namprd15.prod.outlook.com (52.132.22.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18; Mon, 25 Mar 2019 16:29:54 +0000 Received: from BL0PR1501MB2003.namprd15.prod.outlook.com ([fe80::54bc:4aab:4230:3047]) by BL0PR1501MB2003.namprd15.prod.outlook.com ([fe80::54bc:4aab:4230:3047%4]) with mapi id 15.20.1730.019; Mon, 25 Mar 2019 16:29:53 +0000 From: Jon Maloy To: Wei Yongjun , Ying Xue , Hoang Huu Le , Eric Dumazet CC: "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "kernel-janitors@vger.kernel.org" , Hulk Robot Subject: RE: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync() Thread-Topic: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync() Thread-Index: AQHU4tK6byPPyq+kHkuBfwl5aO/W2qYciikg Date: Mon, 25 Mar 2019 16:29:53 +0000 Message-ID: References: <20190321085810.96037-1-weiyongjun1@huawei.com> <20190325063109.173692-1-weiyongjun1@huawei.com> In-Reply-To: <20190325063109.173692-1-weiyongjun1@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jon.maloy@ericsson.com; x-originating-ip: [24.225.233.31] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3eece0c-6187-464e-adf0-08d6b13f1c8f x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BL0PR1501MB2164; x-ms-traffictypediagnostic: BL0PR1501MB2164: x-ld-processed: 92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0987ACA2E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(136003)(346002)(39860400002)(376002)(13464003)(199004)(189003)(52536014)(53546011)(229853002)(6506007)(186003)(105586002)(66066001)(26005)(71200400001)(8936002)(9686003)(53936002)(4326008)(102836004)(33656002)(106356001)(86362001)(6246003)(25786009)(5660300002)(6436002)(8676002)(76176011)(68736007)(81166006)(316002)(99286004)(2906002)(74316002)(44832011)(54906003)(14454004)(14444005)(256004)(6116002)(486006)(476003)(81156014)(3846002)(305945005)(7736002)(478600001)(7696005)(110136005)(55016002)(97736004)(71190400001)(11346002)(446003);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR1501MB2164;H:BL0PR1501MB2003.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8OBxiJtRs2O3t3+L7C6HCra4HJV6bZ1JK/wsRxjcAQi5RK+zrVCPrK87h/XvrD7Zn5ySEvFSKTwZr0XXveWJsnTWuQ4W8twIixv4uVpwFi/09TgUu+3+fUAgW693Z6IRMDqor5hzUv3LhlrVf6y4bSRBKa+ncG6rR0hLmzuiMxpHNBGIWBEQX0/5qhyuLQzu3X51x9DL8Fe18TeWPhMltlu9sT0u8X5pSu/7n+hjAV80OQnQTQ/Kg3xf6fVQtWjJQ1IK/mh0fTQWvN33ob6EA/G/XqhXqOJK9p7Qy5NOzbPGOzRMN6yT+ZORw113F2W8z7nXX7mgXMBdQ9LrMnfx9Pm95RtL25jrfHUXwi1X5UaRURmsQb+Pz+k+sPj+KJ+3CGwnUCVkDyM53LSKmVlzV3WN4z9akSAZNM/iUqvuUKE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3eece0c-6187-464e-adf0-08d6b13f1c8f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2019 16:29:53.8467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB2164 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Acked-by: Jon Maloy > -----Original Message----- > From: netdev-owner@vger.kernel.org > On Behalf Of Wei Yongjun > Sent: 25-Mar-19 07:31 > To: Jon Maloy ; Ying Xue > ; Hoang Huu Le ; > Eric Dumazet > Cc: Wei Yongjun ; netdev@vger.kernel.org; > tipc-discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org; H= ulk > Robot > Subject: [PATCH net-next v2] tipc: fix return value check in > tipc_mcast_send_sync() >=20 > Fix the return value check which testing the wrong variable in > tipc_mcast_send_sync(). >=20 > Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast= ") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > v1 -> v2: add reported-by > --- > net/tipc/bcast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index > 88edfb358ae7..76e14dc08bb9 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, > struct sk_buff *skb, >=20 > /* Allocate dummy message */ > _skb =3D tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL); > - if (!skb) > + if (!_skb) > return -ENOMEM; >=20 > /* Preparing for 'synching' header */ >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Maloy Date: Mon, 25 Mar 2019 16:29:53 +0000 Subject: RE: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync() Message-Id: List-Id: References: <20190321085810.96037-1-weiyongjun1@huawei.com> <20190325063109.173692-1-weiyongjun1@huawei.com> In-Reply-To: <20190325063109.173692-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun , Ying Xue , Hoang Huu Le , Eric Dumazet Cc: "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "kernel-janitors@vger.kernel.org" , Hulk Robot Acked-by: Jon Maloy > -----Original Message----- > From: netdev-owner@vger.kernel.org > On Behalf Of Wei Yongjun > Sent: 25-Mar-19 07:31 > To: Jon Maloy ; Ying Xue > ; Hoang Huu Le ; > Eric Dumazet > Cc: Wei Yongjun ; netdev@vger.kernel.org; > tipc-discussion@lists.sourceforge.net; kernel-janitors@vger.kernel.org; Hulk > Robot > Subject: [PATCH net-next v2] tipc: fix return value check in > tipc_mcast_send_sync() > > Fix the return value check which testing the wrong variable in > tipc_mcast_send_sync(). > > Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > v1 -> v2: add reported-by > --- > net/tipc/bcast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index > 88edfb358ae7..76e14dc08bb9 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, > struct sk_buff *skb, > > /* Allocate dummy message */ > _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL); > - if (!skb) > + if (!_skb) > return -ENOMEM; > > /* Preparing for 'synching' header */ > >