From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BD4C4360F for ; Wed, 3 Apr 2019 12:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D5EB20663 for ; Wed, 3 Apr 2019 12:52:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="i0Y9c3Vs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbfDCMwr (ORCPT ); Wed, 3 Apr 2019 08:52:47 -0400 Received: from mail-eopbgr700084.outbound.protection.outlook.com ([40.107.70.84]:22721 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726099AbfDCMwr (ORCPT ); Wed, 3 Apr 2019 08:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IGFKLuBnA6XoDTdLcHynlRkhlqSlAjh9s/qkXInxcPE=; b=i0Y9c3Vs418JWAETRxmx7pn18p1aHZzN+V2l6P/mjcbVCEDOBXF2pUIjtlk0Od11C0EfYXLMnVeO27AT9T55Y8FM66fGQ0gZ3J5yZuYKBZYo4EQewrOn4mo3CoZ52sWgmuO6SLe0O44u+ShwPTJpfpObjlJz0c8hxipIZMFHBrU= Received: from BL0PR1501MB2003.namprd15.prod.outlook.com (52.132.21.33) by BL0PR1501MB1954.namprd15.prod.outlook.com (52.132.21.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Wed, 3 Apr 2019 12:52:43 +0000 Received: from BL0PR1501MB2003.namprd15.prod.outlook.com ([fe80::51f0:298:e1fc:9624]) by BL0PR1501MB2003.namprd15.prod.outlook.com ([fe80::51f0:298:e1fc:9624%4]) with mapi id 15.20.1750.021; Wed, 3 Apr 2019 12:52:43 +0000 From: Jon Maloy To: Hoang Huu Le , "maloy@donjonn.com" , "ying.xue@windriver.com" , "tipc-discussion@lists.sourceforge.net" , "netdev@vger.kernel.org" Subject: RE: [net-next] tipc: add NULL pointer check Thread-Topic: [net-next] tipc: add NULL pointer check Thread-Index: AQHU6eNNaqFhzY4QN0ugMUi5Bw7fpqYqY3DQ Date: Wed, 3 Apr 2019 12:52:43 +0000 Message-ID: References: <20190403060504.3900-1-hoang.h.le@dektech.com.au> In-Reply-To: <20190403060504.3900-1-hoang.h.le@dektech.com.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jon.maloy@ericsson.com; x-originating-ip: [24.225.233.31] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42a64feb-997d-4529-7465-08d6b8334389 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:BL0PR1501MB1954; x-ms-traffictypediagnostic: BL0PR1501MB1954: x-ld-processed: 92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(39860400002)(136003)(346002)(396003)(366004)(199004)(189003)(13464003)(74316002)(486006)(53936002)(476003)(105586002)(110136005)(6506007)(316002)(3846002)(76176011)(2201001)(6246003)(52536014)(86362001)(71200400001)(68736007)(11346002)(14454004)(6116002)(256004)(33656002)(2501003)(305945005)(71190400001)(7736002)(106356001)(25786009)(5660300002)(8676002)(8936002)(478600001)(81156014)(6436002)(81166006)(66066001)(97736004)(229853002)(2906002)(55016002)(446003)(7696005)(186003)(102836004)(99286004)(53546011)(26005)(44832011)(9686003);DIR:OUT;SFP:1101;SCL:1;SRVR:BL0PR1501MB1954;H:BL0PR1501MB2003.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: TJbVpIutwUxBbNiJpGufKDZxXRPZCu624TKKvlEXlvNQhbfExTy/IgL+h3nYJzYrxepASIK4j+X0USP03U5P093oysA7SZX+kUJUlfrqvRG58gHHILJ+yIWCrZmsiz/3KQQFvJJCnG8fZMwgBdY7Pqno7ibfX8y6wqtDPITqKyCpHeUjc2GpvyZRL5N+kc4aLug5al8VtQ70BRQ/urvW+CU827Kb+ne5eneIq539SEU0Q+5TNF7jXPDH0QBdRH8D2dA3ktlMbwMMx/DrOoBiyXoa4PgJa9XlBVjXu3yKcXpQ5K+FvGtpRbZAdFcVFyspzWUkVQlHrwZjV1VM/DlE5SjaIz87ylHhArm5Wr4P/Cebq4pFxbQpJV9qDlXQbVKxIBWdnjFPut7fAUXbCB3dAuQjYf5CxGq6QYxLJo0CWDk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42a64feb-997d-4529-7465-08d6b8334389 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 12:52:43.3957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB1954 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Acked-by: Jon Maloy Although "somehow" is not the good term here,- the reason is obvious when l= ooking into tipc_sk_proto_rcv(). > -----Original Message----- > From: netdev-owner@vger.kernel.org > On Behalf Of Hoang Le > Sent: 3-Apr-19 02:05 > To: Jon Maloy ; maloy@donjonn.com; > ying.xue@windriver.com; tipc-discussion@lists.sourceforge.net; > netdev@vger.kernel.org > Subject: [net-next] tipc: add NULL pointer check >=20 > skb somehow dequeued out of inputq before processing, it causes to NULL > pointer and kernel crashed. >=20 > Add checking skb valid before using. >=20 > Fixes: c55c8edafa9 ("tipc: smooth change between replicast and broadcast"= ) > Reported-by: Tuong Lien Tong > Acked-by: Ying Xue > Signed-off-by: Hoang Le > --- > net/tipc/bcast.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index > 76e14dc08bb9..6c997d4a6218 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -769,6 +769,9 @@ void tipc_mcast_filter_msg(struct net *net, struct > sk_buff_head *defq, > u32 node, port; >=20 > skb =3D skb_peek(inputq); > + if (!skb) > + return; > + > hdr =3D buf_msg(skb); >=20 > if (likely(!msg_is_syn(hdr) && skb_queue_empty(defq))) > -- > 2.17.1